Re: [U-Boot] [PATCH v2 2/3] efi_loader: enumerate disk devices every time

Simon, On Mon, Jan 28, 2019 at 05:46:21PM -0700, Simon Glass wrote: > Hi, > > On Mon, 28 Jan 2019 at 01:55, AKASHI Takahiro > wrote: > > > > On Fri, Jan 25, 2019 at 10:31:20AM +0100, Alexander Graf wrote: > > > > > > > > > On 25.01.19 10:18, AKASHI Takahiro wrote: > > > > On Fri, Jan 25, 2019 at

Re: [U-Boot] [PATCH v2 2/3] efi_loader: enumerate disk devices every time

Hi, On Mon, 28 Jan 2019 at 01:55, AKASHI Takahiro wrote: > > On Fri, Jan 25, 2019 at 10:31:20AM +0100, Alexander Graf wrote: > > > > > > On 25.01.19 10:18, AKASHI Takahiro wrote: > > > On Fri, Jan 25, 2019 at 09:52:31AM +0100, Alexander Graf wrote: > > >> > > >> > > >> On 25.01.19 09:27, AKASHI T

Re: [U-Boot] [PATCH v2 2/3] efi_loader: enumerate disk devices every time

> Am 28.01.2019 um 09:56 schrieb AKASHI Takahiro : > >> On Fri, Jan 25, 2019 at 10:31:20AM +0100, Alexander Graf wrote: >> >> >>> On 25.01.19 10:18, AKASHI Takahiro wrote: On Fri, Jan 25, 2019 at 09:52:31AM +0100, Alexander Graf wrote: > On 25.01.19 09:27, AKASHI Takahiro

Re: [U-Boot] [PATCH v2 2/3] efi_loader: enumerate disk devices every time

On Fri, Jan 25, 2019 at 10:31:20AM +0100, Alexander Graf wrote: > > > On 25.01.19 10:18, AKASHI Takahiro wrote: > > On Fri, Jan 25, 2019 at 09:52:31AM +0100, Alexander Graf wrote: > >> > >> > >> On 25.01.19 09:27, AKASHI Takahiro wrote: > >>> Alex, > >>> > >>> On Wed, Jan 23, 2019 at 10:51:29AM +

Re: [U-Boot] [PATCH v2 2/3] efi_loader: enumerate disk devices every time

On 25.01.19 10:18, AKASHI Takahiro wrote: > On Fri, Jan 25, 2019 at 09:52:31AM +0100, Alexander Graf wrote: >> >> >> On 25.01.19 09:27, AKASHI Takahiro wrote: >>> Alex, >>> >>> On Wed, Jan 23, 2019 at 10:51:29AM +0100, Alexander Graf wrote: On 01/22/2019 08:39 PM, Simon Glass wrote: > Hi

Re: [U-Boot] [PATCH v2 2/3] efi_loader: enumerate disk devices every time

On Fri, Jan 25, 2019 at 09:52:31AM +0100, Alexander Graf wrote: > > > On 25.01.19 09:27, AKASHI Takahiro wrote: > > Alex, > > > > On Wed, Jan 23, 2019 at 10:51:29AM +0100, Alexander Graf wrote: > >> On 01/22/2019 08:39 PM, Simon Glass wrote: > >>> Hi Alex, > >>> > >>> On Tue, 22 Jan 2019 at 22:0

Re: [U-Boot] [PATCH v2 2/3] efi_loader: enumerate disk devices every time

On 25.01.19 09:27, AKASHI Takahiro wrote: > Alex, > > On Wed, Jan 23, 2019 at 10:51:29AM +0100, Alexander Graf wrote: >> On 01/22/2019 08:39 PM, Simon Glass wrote: >>> Hi Alex, >>> >>> On Tue, 22 Jan 2019 at 22:08, Alexander Graf wrote: On 22.01.19 09:29, AKASHI Takahiro wrote: >

Re: [U-Boot] [PATCH v2 2/3] efi_loader: enumerate disk devices every time

Alex, On Wed, Jan 23, 2019 at 10:51:29AM +0100, Alexander Graf wrote: > On 01/22/2019 08:39 PM, Simon Glass wrote: > >Hi Alex, > > > >On Tue, 22 Jan 2019 at 22:08, Alexander Graf wrote: > >> > >> > >>On 22.01.19 09:29, AKASHI Takahiro wrote: > >>>Alex, Simon, > >>> > >>>Apologies for my slow resp

Re: [U-Boot] [PATCH v2 2/3] efi_loader: enumerate disk devices every time

Heinrich, On Thu, Jan 24, 2019 at 10:19:28PM +0100, Heinrich Schuchardt wrote: > On 1/24/19 9:18 PM, Simon Glass wrote: > > Hi Takahiro, > > > > On Thu, 24 Jan 2019 at 13:53, AKASHI Takahiro > > wrote: > >> > >> Simon, > >> > >> On Thu, Jan 24, 2019 at 10:58:53AM +1300, Simon Glass wrote: > >>>

Re: [U-Boot] [PATCH v2 2/3] efi_loader: enumerate disk devices every time

On 1/24/19 9:18 PM, Simon Glass wrote: > Hi Takahiro, > > On Thu, 24 Jan 2019 at 13:53, AKASHI Takahiro > wrote: >> >> Simon, >> >> On Thu, Jan 24, 2019 at 10:58:53AM +1300, Simon Glass wrote: >>> Hi Heinrich, >>> >>> On Wed, 23 Jan 2019 at 10:05, Heinrich Schuchardt >>> wrote: On 1/2

Re: [U-Boot] [PATCH v2 2/3] efi_loader: enumerate disk devices every time

Hi Takahiro, On Thu, 24 Jan 2019 at 13:53, AKASHI Takahiro wrote: > > Simon, > > On Thu, Jan 24, 2019 at 10:58:53AM +1300, Simon Glass wrote: > > Hi Heinrich, > > > > On Wed, 23 Jan 2019 at 10:05, Heinrich Schuchardt > > wrote: > > > > > > On 1/22/19 8:39 PM, Simon Glass wrote: > > > > Hi Alex,

Re: [U-Boot] [PATCH v2 2/3] efi_loader: enumerate disk devices every time

Simon, On Thu, Jan 24, 2019 at 10:58:53AM +1300, Simon Glass wrote: > Hi Heinrich, > > On Wed, 23 Jan 2019 at 10:05, Heinrich Schuchardt wrote: > > > > On 1/22/19 8:39 PM, Simon Glass wrote: > > > Hi Alex, > > > > > > On Tue, 22 Jan 2019 at 22:08, Alexander Graf wrote: > > >> > > >> > > >> > >

Re: [U-Boot] [PATCH v2 2/3] efi_loader: enumerate disk devices every time

Hi Alex, On Wed, 23 Jan 2019 at 22:51, Alexander Graf wrote: > > On 01/22/2019 08:39 PM, Simon Glass wrote: > > Hi Alex, > > > > On Tue, 22 Jan 2019 at 22:08, Alexander Graf wrote: > >> > >> > >> On 22.01.19 09:29, AKASHI Takahiro wrote: > >>> Alex, Simon, > >>> > >>> Apologies for my slow respo

Re: [U-Boot] [PATCH v2 2/3] efi_loader: enumerate disk devices every time

Hi Heinrich, On Wed, 23 Jan 2019 at 10:05, Heinrich Schuchardt wrote: > > On 1/22/19 8:39 PM, Simon Glass wrote: > > Hi Alex, > > > > On Tue, 22 Jan 2019 at 22:08, Alexander Graf wrote: > >> > >> > >> > >> On 22.01.19 09:29, AKASHI Takahiro wrote: > >>> Alex, Simon, > >>> > >>> Apologies for my

Re: [U-Boot] [PATCH v2 2/3] efi_loader: enumerate disk devices every time

On 01/22/2019 08:39 PM, Simon Glass wrote: Hi Alex, On Tue, 22 Jan 2019 at 22:08, Alexander Graf wrote: On 22.01.19 09:29, AKASHI Takahiro wrote: Alex, Simon, Apologies for my slow response on this matter, On Fri, Jan 11, 2019 at 08:57:05AM +0100, Alexander Graf wrote: On 11.01.19 05:29

Re: [U-Boot] [PATCH v2 2/3] efi_loader: enumerate disk devices every time

On 01/23/2019 09:12 AM, AKASHI Takahiro wrote: Alex, On Tue, Jan 22, 2019 at 10:08:53AM +0100, Alexander Graf wrote: On 22.01.19 09:29, AKASHI Takahiro wrote: Alex, Simon, Apologies for my slow response on this matter, On Fri, Jan 11, 2019 at 08:57:05AM +0100, Alexander Graf wrote: On 11.

Re: [U-Boot] [PATCH v2 2/3] efi_loader: enumerate disk devices every time

Alex, On Tue, Jan 22, 2019 at 10:08:53AM +0100, Alexander Graf wrote: > > > On 22.01.19 09:29, AKASHI Takahiro wrote: > > Alex, Simon, > > > > Apologies for my slow response on this matter, > > > > On Fri, Jan 11, 2019 at 08:57:05AM +0100, Alexander Graf wrote: > >> > >> > >> On 11.01.19 05:29

Re: [U-Boot] [PATCH v2 2/3] efi_loader: enumerate disk devices every time

On Tue, Jan 22, 2019 at 10:04:55PM +0100, Heinrich Schuchardt wrote: > On 1/22/19 8:39 PM, Simon Glass wrote: > > Hi Alex, > > > > On Tue, 22 Jan 2019 at 22:08, Alexander Graf wrote: > >> > >> > >> > >> On 22.01.19 09:29, AKASHI Takahiro wrote: > >>> Alex, Simon, > >>> > >>> Apologies for my slow

Re: [U-Boot] [PATCH v2 2/3] efi_loader: enumerate disk devices every time

On 1/22/19 8:39 PM, Simon Glass wrote: > Hi Alex, > > On Tue, 22 Jan 2019 at 22:08, Alexander Graf wrote: >> >> >> >> On 22.01.19 09:29, AKASHI Takahiro wrote: >>> Alex, Simon, >>> >>> Apologies for my slow response on this matter, >>> >>> On Fri, Jan 11, 2019 at 08:57:05AM +0100, Alexander Graf

Re: [U-Boot] [PATCH v2 2/3] efi_loader: enumerate disk devices every time

Hi Alex, On Tue, 22 Jan 2019 at 22:08, Alexander Graf wrote: > > > > On 22.01.19 09:29, AKASHI Takahiro wrote: > > Alex, Simon, > > > > Apologies for my slow response on this matter, > > > > On Fri, Jan 11, 2019 at 08:57:05AM +0100, Alexander Graf wrote: > >> > >> > >> On 11.01.19 05:29, AKASHI T

Re: [U-Boot] [PATCH v2 2/3] efi_loader: enumerate disk devices every time

On 22.01.19 09:29, AKASHI Takahiro wrote: > Alex, Simon, > > Apologies for my slow response on this matter, > > On Fri, Jan 11, 2019 at 08:57:05AM +0100, Alexander Graf wrote: >> >> >> On 11.01.19 05:29, AKASHI Takahiro wrote: >>> Alex, Heinrich and Simon, >>> >>> Thank you for your comments, t

Re: [U-Boot] [PATCH v2 2/3] efi_loader: enumerate disk devices every time

Alex, Simon, Apologies for my slow response on this matter, On Fri, Jan 11, 2019 at 08:57:05AM +0100, Alexander Graf wrote: > > > On 11.01.19 05:29, AKASHI Takahiro wrote: > > Alex, Heinrich and Simon, > > > > Thank you for your comments, they are all valuable but also make me > > confused as

Re: [U-Boot] [PATCH v2 2/3] efi_loader: enumerate disk devices every time

Hi Alex, On Sat, 12 Jan 2019 at 15:00, Alexander Graf wrote: > > > > > Am 12.01.2019 um 22:32 schrieb Simon Glass : > > > > Hi Alex, > > > >> On Fri, 11 Jan 2019 at 00:57, Alexander Graf wrote: > >> > >> > >> > >>> On 11.01.19 05:29, AKASHI Takahiro wrote: > >>> Alex, Heinrich and Simon, > >>> >

Re: [U-Boot] [PATCH v2 2/3] efi_loader: enumerate disk devices every time

> Am 12.01.2019 um 22:32 schrieb Simon Glass : > > Hi Alex, > >> On Fri, 11 Jan 2019 at 00:57, Alexander Graf wrote: >> >> >> >>> On 11.01.19 05:29, AKASHI Takahiro wrote: >>> Alex, Heinrich and Simon, >>> >>> Thank you for your comments, they are all valuable but also make me >>> confused

Re: [U-Boot] [PATCH v2 2/3] efi_loader: enumerate disk devices every time

Hi Alex, On Fri, 11 Jan 2019 at 00:57, Alexander Graf wrote: > > > > On 11.01.19 05:29, AKASHI Takahiro wrote: > > Alex, Heinrich and Simon, > > > > Thank you for your comments, they are all valuable but also make me > > confused as different people have different requirements :) > > I'm not sure

Re: [U-Boot] [PATCH v2 2/3] efi_loader: enumerate disk devices every time

> From: Alexander Graf > Date: Fri, 11 Jan 2019 09:00:27 +0100 > > On 11.01.19 05:51, AKASHI Takahiro wrote: > > On Thu, Jan 10, 2019 at 05:57:11AM -0700, Simon Glass wrote: > >> Hi, > >> > >> > >> Please no. We don't want EFI hooks around the place. EFI should use > >> DM, not the other way arou

Re: [U-Boot] [PATCH v2 2/3] efi_loader: enumerate disk devices every time

On 11.01.19 05:51, AKASHI Takahiro wrote: > On Thu, Jan 10, 2019 at 05:57:11AM -0700, Simon Glass wrote: >> Hi, >> >> On Wed, 9 Jan 2019 at 02:06, Alexander Graf wrote: >>> >>> >>> >>> On 13.12.18 08:58, AKASHI Takahiro wrote: Heinrich, On Tue, Dec 11, 2018 at 08:55:41PM +0100, He

Re: [U-Boot] [PATCH v2 2/3] efi_loader: enumerate disk devices every time

On 11.01.19 05:29, AKASHI Takahiro wrote: > Alex, Heinrich and Simon, > > Thank you for your comments, they are all valuable but also make me > confused as different people have different requirements :) > I'm not sure that all of us share the same *ultimate* goal here. The shared ultimate goal

Re: [U-Boot] [PATCH v2 2/3] efi_loader: enumerate disk devices every time

Heinrich, On Thu, Jan 10, 2019 at 08:22:25PM +0100, Heinrich Schuchardt wrote: > On 1/10/19 10:22 AM, Alexander Graf wrote: > > > > > >> Am 10.01.2019 um 10:16 schrieb AKASHI Takahiro > >> : > >> > >>> On Thu, Jan 10, 2019 at 09:15:36AM +0100, Alexander Graf wrote: > >>> > >>> > > Am 10.01.

Re: [U-Boot] [PATCH v2 2/3] efi_loader: enumerate disk devices every time

On Thu, Jan 10, 2019 at 05:57:11AM -0700, Simon Glass wrote: > Hi, > > On Wed, 9 Jan 2019 at 02:06, Alexander Graf wrote: > > > > > > > > On 13.12.18 08:58, AKASHI Takahiro wrote: > > > Heinrich, > > > > > > On Tue, Dec 11, 2018 at 08:55:41PM +0100, Heinrich Schuchardt wrote: > > >> On 11/15/18 5

Re: [U-Boot] [PATCH v2 2/3] efi_loader: enumerate disk devices every time

Alex, Heinrich and Simon, Thank you for your comments, they are all valuable but also make me confused as different people have different requirements :) I'm not sure that all of us share the same *ultimate* goal here. So, first, let me reply to each of your comments. Through this process, I hope

Re: [U-Boot] [PATCH v2 2/3] efi_loader: enumerate disk devices every time

On 1/10/19 10:22 AM, Alexander Graf wrote: > > >> Am 10.01.2019 um 10:16 schrieb AKASHI Takahiro : >> >>> On Thu, Jan 10, 2019 at 09:15:36AM +0100, Alexander Graf wrote: >>> >>> > Am 10.01.2019 um 09:02 schrieb AKASHI Takahiro > : > > On Thu, Jan 10, 2019 at 08:30:13AM +0100, Ale

Re: [U-Boot] [PATCH v2 2/3] efi_loader: enumerate disk devices every time

Hi, On Wed, 9 Jan 2019 at 02:06, Alexander Graf wrote: > > > > On 13.12.18 08:58, AKASHI Takahiro wrote: > > Heinrich, > > > > On Tue, Dec 11, 2018 at 08:55:41PM +0100, Heinrich Schuchardt wrote: > >> On 11/15/18 5:58 AM, AKASHI Takahiro wrote: > >>> Currently, efi_init_obj_list() scan disk devic

Re: [U-Boot] [PATCH v2 2/3] efi_loader: enumerate disk devices every time

> Am 10.01.2019 um 10:16 schrieb AKASHI Takahiro : > >> On Thu, Jan 10, 2019 at 09:15:36AM +0100, Alexander Graf wrote: >> >> Am 10.01.2019 um 09:02 schrieb AKASHI Takahiro : On Thu, Jan 10, 2019 at 08:30:13AM +0100, Alexander Graf wrote: > On 10.01.19 08:

Re: [U-Boot] [PATCH v2 2/3] efi_loader: enumerate disk devices every time

On Thu, Jan 10, 2019 at 09:15:36AM +0100, Alexander Graf wrote: > > > > Am 10.01.2019 um 09:02 schrieb AKASHI Takahiro : > > > >> On Thu, Jan 10, 2019 at 08:30:13AM +0100, Alexander Graf wrote: > >> > >> > >>> On 10.01.19 08:26, AKASHI Takahiro wrote: > >>> Alex, > >>> > On Thu, Jan 10,

Re: [U-Boot] [PATCH v2 2/3] efi_loader: enumerate disk devices every time

> Am 10.01.2019 um 09:02 schrieb AKASHI Takahiro : > >> On Thu, Jan 10, 2019 at 08:30:13AM +0100, Alexander Graf wrote: >> >> >>> On 10.01.19 08:26, AKASHI Takahiro wrote: >>> Alex, >>> On Thu, Jan 10, 2019 at 07:21:12AM +0100, Alexander Graf wrote: > On 10.01.19 03:13, A

Re: [U-Boot] [PATCH v2 2/3] efi_loader: enumerate disk devices every time

On Thu, Jan 10, 2019 at 08:30:13AM +0100, Alexander Graf wrote: > > > On 10.01.19 08:26, AKASHI Takahiro wrote: > > Alex, > > > > On Thu, Jan 10, 2019 at 07:21:12AM +0100, Alexander Graf wrote: > >> > >> > >> On 10.01.19 03:13, AKASHI Takahiro wrote: > >>> Alex, > >>> > >>> On Wed, Jan 09, 2019

Re: [U-Boot] [PATCH v2 2/3] efi_loader: enumerate disk devices every time

On 10.01.19 08:26, AKASHI Takahiro wrote: > Alex, > > On Thu, Jan 10, 2019 at 07:21:12AM +0100, Alexander Graf wrote: >> >> >> On 10.01.19 03:13, AKASHI Takahiro wrote: >>> Alex, >>> >>> On Wed, Jan 09, 2019 at 10:06:16AM +0100, Alexander Graf wrote: On 13.12.18 08:58, AKASHI Taka

Re: [U-Boot] [PATCH v2 2/3] efi_loader: enumerate disk devices every time

Alex, On Thu, Jan 10, 2019 at 07:21:12AM +0100, Alexander Graf wrote: > > > On 10.01.19 03:13, AKASHI Takahiro wrote: > > Alex, > > > > On Wed, Jan 09, 2019 at 10:06:16AM +0100, Alexander Graf wrote: > >> > >> > >> On 13.12.18 08:58, AKASHI Takahiro wrote: > >>> Heinrich, > >>> > >>> On Tue, De

Re: [U-Boot] [PATCH v2 2/3] efi_loader: enumerate disk devices every time

On 10.01.19 03:13, AKASHI Takahiro wrote: > Alex, > > On Wed, Jan 09, 2019 at 10:06:16AM +0100, Alexander Graf wrote: >> >> >> On 13.12.18 08:58, AKASHI Takahiro wrote: >>> Heinrich, >>> >>> On Tue, Dec 11, 2018 at 08:55:41PM +0100, Heinrich Schuchardt wrote: On 11/15/18 5:58 AM, AKASHI Tak

Re: [U-Boot] [PATCH v2 2/3] efi_loader: enumerate disk devices every time

Alex, On Wed, Jan 09, 2019 at 10:06:16AM +0100, Alexander Graf wrote: > > > On 13.12.18 08:58, AKASHI Takahiro wrote: > > Heinrich, > > > > On Tue, Dec 11, 2018 at 08:55:41PM +0100, Heinrich Schuchardt wrote: > >> On 11/15/18 5:58 AM, AKASHI Takahiro wrote: > >>> Currently, efi_init_obj_list()

Re: [U-Boot] [PATCH v2 2/3] efi_loader: enumerate disk devices every time

On 13.12.18 08:58, AKASHI Takahiro wrote: > Heinrich, > > On Tue, Dec 11, 2018 at 08:55:41PM +0100, Heinrich Schuchardt wrote: >> On 11/15/18 5:58 AM, AKASHI Takahiro wrote: >>> Currently, efi_init_obj_list() scan disk devices only once, and never >>> change a list of efi disk devices. This will

Re: [U-Boot] [PATCH v2 2/3] efi_loader: enumerate disk devices every time

Heinrich, Do you have any further comments here? Otherwise, I'd like to send out v3 shortly. -Takahiro Akashi On Thu, Dec 13, 2018 at 04:58:29PM +0900, AKASHI Takahiro wrote: > Heinrich, > > On Tue, Dec 11, 2018 at 08:55:41PM +0100, Heinrich Schuchardt wrote: > > On 11/15/18 5:58 AM, AKASHI Tak

Re: [U-Boot] [PATCH v2 2/3] efi_loader: enumerate disk devices every time

Heinrich, On Tue, Dec 11, 2018 at 08:55:41PM +0100, Heinrich Schuchardt wrote: > On 11/15/18 5:58 AM, AKASHI Takahiro wrote: > > Currently, efi_init_obj_list() scan disk devices only once, and never > > change a list of efi disk devices. This will possibly result in failing > > to find a removable

Re: [U-Boot] [PATCH v2 2/3] efi_loader: enumerate disk devices every time

On 11/15/18 5:58 AM, AKASHI Takahiro wrote: > Currently, efi_init_obj_list() scan disk devices only once, and never > change a list of efi disk devices. This will possibly result in failing > to find a removable storage which may be added later on. See [1]. > > In this patch, called is efi_disk_up

[U-Boot] [PATCH v2 2/3] efi_loader: enumerate disk devices every time

Currently, efi_init_obj_list() scan disk devices only once, and never change a list of efi disk devices. This will possibly result in failing to find a removable storage which may be added later on. See [1]. In this patch, called is efi_disk_update() which is responsible for re-scanning UCLASS_BLK