Re: [U-Boot] [PATCH v2 2/2] mtd: add altera quadspi driver

2015-11-06 Thread Marek Vasut
On Friday, November 06, 2015 at 09:11:20 AM, Jagan Teki wrote: [...] > >> all these are spi-nor controller which doesn't do any generic spi > >> things but should be in spi-nor subsystem. Even Marek send altera_qspi > >> as spi-nor controller [1] > > > > This is because that thing communicates l

Re: [U-Boot] [PATCH v2 2/2] mtd: add altera quadspi driver

2015-11-06 Thread Thomas Chou
Hi Jagan, On 2015年11月06日 19:48, Jagan Teki wrote: My intention is not to hold this, but once spi-nor is ready will you able to move it from here? Sure, I will look at the new spi-nor interface then. And I will think again if it is good to move. Thanks a lot for your help. Best regards, Thom

Re: [U-Boot] [PATCH v2 2/2] mtd: add altera quadspi driver

2015-11-06 Thread Jagan Teki
Hi Thomas, On 6 November 2015 at 15:22, Jagan Teki wrote: > Hi Thomas, > > On 6 November 2015 at 14:58, Thomas Chou wrote: >> Hi Jagan, >> >> On 2015年11月06日 16:07, Jagan Teki wrote: >>> >>> I appreciate your hardware expertise and am not questioning about that >>> as well. I do agree with the hw

Re: [U-Boot] [PATCH v2 2/2] mtd: add altera quadspi driver

2015-11-06 Thread Jagan Teki
Hi Thomas, On 6 November 2015 at 14:58, Thomas Chou wrote: > Hi Jagan, > > On 2015年11月06日 16:07, Jagan Teki wrote: >> >> I appreciate your hardware expertise and am not questioning about that >> as well. I do agree with the hw logic about altera qspi controller and >> I don't have any questions w

Re: [U-Boot] [PATCH v2 2/2] mtd: add altera quadspi driver

2015-11-06 Thread Thomas Chou
Hi Jagan, On 2015年11月06日 16:07, Jagan Teki wrote: I appreciate your hardware expertise and am not questioning about that as well. I do agree with the hw logic about altera qspi controller and I don't have any questions with hw either. But my main intention here was about the software support si

Re: [U-Boot] [PATCH v2 2/2] mtd: add altera quadspi driver

2015-11-06 Thread Jagan Teki
Hi Marek, On 5 November 2015 at 21:21, Marek Vasut wrote: > On Thursday, November 05, 2015 at 03:57:01 PM, Jagan Teki wrote: >> Hi Thomas, >> >> On 5 November 2015 at 20:15, Thomas Chou wrote: >> > Hi Jagan, >> > >> > On 2015年11月05日 22:25, Jagan Teki wrote: >> >> On 5 November 2015 at 14:17, Tho

Re: [U-Boot] [PATCH v2 2/2] mtd: add altera quadspi driver

2015-11-06 Thread Jagan Teki
Hi Thomas, On 6 November 2015 at 05:48, Thomas Chou wrote: > Hi Jagan, > > On 2015年11月05日 22:57, Jagan Teki wrote: >> >> The altera quad spi core is very special that the hardware handle the >>> >>> spi-nor protocol. The core is designed to replace the CFI flash >>> interface. >>> So there is not

Re: [U-Boot] [PATCH v2 2/2] mtd: add altera quadspi driver

2015-11-05 Thread Thomas Chou
Hi Jagan, On 2015年11月05日 22:57, Jagan Teki wrote: The altera quad spi core is very special that the hardware handle the spi-nor protocol. The core is designed to replace the CFI flash interface. So there is nothing to do with SPI from the parallel flash interface. It is memory mapped. There is

Re: [U-Boot] [PATCH v2 2/2] mtd: add altera quadspi driver

2015-11-05 Thread Marek Vasut
On Thursday, November 05, 2015 at 03:57:01 PM, Jagan Teki wrote: > Hi Thomas, > > On 5 November 2015 at 20:15, Thomas Chou wrote: > > Hi Jagan, > > > > On 2015年11月05日 22:25, Jagan Teki wrote: > >> On 5 November 2015 at 14:17, Thomas Chou wrote: > >>> Add Altera Generic Quad SPI Controller suppo

Re: [U-Boot] [PATCH v2 2/2] mtd: add altera quadspi driver

2015-11-05 Thread Jagan Teki
Hi Thomas, On 5 November 2015 at 20:15, Thomas Chou wrote: > Hi Jagan, > > On 2015年11月05日 22:25, Jagan Teki wrote: >> >> On 5 November 2015 at 14:17, Thomas Chou wrote: >>> >>> Add Altera Generic Quad SPI Controller support. The controller >>> converts SPI NOR flash to parallel flash interface.

Re: [U-Boot] [PATCH v2 2/2] mtd: add altera quadspi driver

2015-11-05 Thread Thomas Chou
Hi Jagan, On 2015年11月05日 22:25, Jagan Teki wrote: On 5 November 2015 at 14:17, Thomas Chou wrote: Add Altera Generic Quad SPI Controller support. The controller converts SPI NOR flash to parallel flash interface. So it is not like other SPI flash, but rather like CFI flash. Can you wait till

Re: [U-Boot] [PATCH v2 2/2] mtd: add altera quadspi driver

2015-11-05 Thread Jagan Teki
On 5 November 2015 at 14:17, Thomas Chou wrote: > Add Altera Generic Quad SPI Controller support. The controller > converts SPI NOR flash to parallel flash interface. So it is > not like other SPI flash, but rather like CFI flash. Can you wait till spi-nor ready? it doesn't make sense to have Ser

[U-Boot] [PATCH v2 2/2] mtd: add altera quadspi driver

2015-11-05 Thread Thomas Chou
Add Altera Generic Quad SPI Controller support. The controller converts SPI NOR flash to parallel flash interface. So it is not like other SPI flash, but rather like CFI flash. Signed-off-by: Thomas Chou --- v2 use memcpy_toio() for mtd_write() as suggested by Chin Liang and Marek. doc/devi