Re: [U-Boot] [PATCH v2 1/3] MX31: Add NAND SPL for i.MX31.

2009-06-01 Thread Magnus Lilja
2009/6/1 Scott Wood : > Magnus Lilja wrote: >> >> 2009/5/30 Magnus Lilja : >>> >>> 2009/5/29 Scott Wood : Does the number of address bytes really need to depend on the size of the flash chip, or can you base it on the number of non-zero bytes in page_address (the chip will

Re: [U-Boot] [PATCH v2 1/3] MX31: Add NAND SPL for i.MX31.

2009-06-01 Thread Scott Wood
Magnus Lilja wrote: > 2009/5/30 Magnus Lilja : >> 2009/5/29 Scott Wood : >>> Does the number of address bytes really need to depend on the size of the >>> flash chip, or can you base it on the number of non-zero bytes in >>> page_address (the chip will know when the address phase is over because >>

Re: [U-Boot] [PATCH v2 1/3] MX31: Add NAND SPL for i.MX31.

2009-06-01 Thread Magnus Lilja
Hi 2009/5/30 Magnus Lilja : > 2009/5/29 Scott Wood : >> On Sun, May 03, 2009 at 09:56:57PM +0200, Magnus Lilja wrote: >>> +static void mx31_nand_page_address(unsigned int page_address) >>> +{ >>> +     unsigned int page_count; >>> + >>> +     writew(0x00, NFC_FLASH_ADDR); >>> +     writew(NFC_ADDR

Re: [U-Boot] [PATCH v2 1/3] MX31: Add NAND SPL for i.MX31.

2009-06-01 Thread Magnus Lilja
Hi 2009/6/1 Scott Wood : > On Sat, May 30, 2009 at 09:54:56AM +0200, Magnus Lilja wrote: >> 2009/5/29 Scott Wood : >> > The bad block location is typically different (offset 0 rather than 5) >> > with large page flash. >> >> I think that's because of the non-standard imlementation of large page >>

Re: [U-Boot] [PATCH v2 1/3] MX31: Add NAND SPL for i.MX31.

2009-06-01 Thread Scott Wood
On Sat, May 30, 2009 at 09:54:56AM +0200, Magnus Lilja wrote: > 2009/5/29 Scott Wood : > > The bad block location is typically different (offset 0 rather than 5) > > with large page flash. > > I think that's because of the non-standard imlementation of large page > support in the i.MX31 NFC. We s

Re: [U-Boot] [PATCH v2 1/3] MX31: Add NAND SPL for i.MX31.

2009-05-30 Thread Magnus Lilja
2009/5/29 Scott Wood : > On Sun, May 03, 2009 at 09:56:57PM +0200, Magnus Lilja wrote: >> This patch adds the NAND SPL framework needed to boot i.MX31 boards >> from NAND. > > Sorry for the delay... Well, better now than the next time I post these patches. >> diff --git a/include/asm-arm/arch-mx3

Re: [U-Boot] [PATCH v2 1/3] MX31: Add NAND SPL for i.MX31.

2009-05-29 Thread Scott Wood
On Sun, May 03, 2009 at 09:56:57PM +0200, Magnus Lilja wrote: > This patch adds the NAND SPL framework needed to boot i.MX31 boards > from NAND. Sorry for the delay... > diff --git a/include/asm-arm/arch-mx31/mx31-regs.h > b/include/asm-arm/arch-mx31/mx31-regs.h > index a8a05c8..3d811d7 100644 >

Re: [U-Boot] [PATCH v2 1/3] MX31: Add NAND SPL for i.MX31.

2009-05-12 Thread Scott Wood
On Tue, May 12, 2009 at 06:03:29AM +0200, Magnus Lilja wrote: > As I said in another email: > "The main purpose of CONFIG_ONENAND_IPL and NAND_SPL in start.S is to > change the behaviour a bit, not so much to save some space." > Given that those CONFIG_s are used in other places as well to indicate

Re: [U-Boot] [PATCH v2 1/3] MX31: Add NAND SPL for i.MX31.

2009-05-11 Thread Magnus Lilja
2009/5/12 Jean-Christophe PLAGNIOL-VILLARD : > On 21:03 Mon 11 May     , Magnus Lilja wrote: >> 2009/5/10 Jean-Christophe PLAGNIOL-VILLARD : >> >> >> + >> >> >> +     } >> >> >> + >> >> >> +     page_count = CFG_NAND_CHIP_SIZE / CFG_NAND_PAGE_SIZE; >> >> > please use CONFIG_SYS_ or CONFIG_ >> >> >>

Re: [U-Boot] [PATCH v2 1/3] MX31: Add NAND SPL for i.MX31.

2009-05-11 Thread Jean-Christophe PLAGNIOL-VILLARD
On 21:03 Mon 11 May , Magnus Lilja wrote: > 2009/5/10 Jean-Christophe PLAGNIOL-VILLARD : > >> >> + > >> >> +     } > >> >> + > >> >> +     page_count = CFG_NAND_CHIP_SIZE / CFG_NAND_PAGE_SIZE; > >> > please use CONFIG_SYS_ or CONFIG_ > >> > >> Will do. > >> > >> > and why not detect it? > >> >

Re: [U-Boot] [PATCH v2 1/3] MX31: Add NAND SPL for i.MX31.

2009-05-11 Thread Magnus Lilja
2009/5/10 Jean-Christophe PLAGNIOL-VILLARD : >> >> + >> >> +     } >> >> + >> >> +     page_count = CFG_NAND_CHIP_SIZE / CFG_NAND_PAGE_SIZE; >> > please use CONFIG_SYS_ or CONFIG_ >> >> Will do. >> >> > and why not detect it? >> >> Might be possible, I'll look into it to see if it's doable. > tks

Re: [U-Boot] [PATCH v2 1/3] MX31: Add NAND SPL for i.MX31.

2009-05-11 Thread Magnus Lilja
2009/5/10 Jean-Christophe PLAGNIOL-VILLARD : > On 21:31 Sun 10 May     , Magnus Lilja wrote: >> 2009/5/9 Jean-Christophe PLAGNIOL-VILLARD : >> > On 21:56 Sun 03 May     , Magnus Lilja wrote: >> >> @@ -32,7 +35,7 @@ >> >>  #include >> >>  .globl _start >> >>  _start: b    reset >> >> -#ifdef CONFIG

Re: [U-Boot] [PATCH v2 1/3] MX31: Add NAND SPL for i.MX31.

2009-05-10 Thread Jean-Christophe PLAGNIOL-VILLARD
On 21:31 Sun 10 May , Magnus Lilja wrote: > 2009/5/9 Jean-Christophe PLAGNIOL-VILLARD : > > On 21:56 Sun 03 May     , Magnus Lilja wrote: > >> @@ -32,7 +35,7 @@ > >>  #include > >>  .globl _start > >>  _start: b    reset > >> -#ifdef CONFIG_ONENAND_IPL > >> +#if defined(CONFIG_ONENAND_IPL) ||

Re: [U-Boot] [PATCH v2 1/3] MX31: Add NAND SPL for i.MX31.

2009-05-10 Thread Magnus Lilja
2009/5/9 Jean-Christophe PLAGNIOL-VILLARD : > On 21:56 Sun 03 May     , Magnus Lilja wrote: >> @@ -32,7 +35,7 @@ >>  #include >>  .globl _start >>  _start: b    reset >> -#ifdef CONFIG_ONENAND_IPL >> +#if defined(CONFIG_ONENAND_IPL) || defined(CONFIG_NAND_SPL) > create a better CONFIG_ > because w

Re: [U-Boot] [PATCH v2 1/3] MX31: Add NAND SPL for i.MX31.

2009-05-09 Thread Jean-Christophe PLAGNIOL-VILLARD
On 21:56 Sun 03 May , Magnus Lilja wrote: > This patch adds the NAND SPL framework needed to boot i.MX31 boards > from NAND. > > The patch is based on the work by Maxim Artamonov > (which was signed-off-by him). so please add it too and please fix the @ > > Signed-off-by: Magnus Lilja > ---

[U-Boot] [PATCH v2 1/3] MX31: Add NAND SPL for i.MX31.

2009-05-03 Thread Magnus Lilja
This patch adds the NAND SPL framework needed to boot i.MX31 boards from NAND. The patch is based on the work by Maxim Artamonov (which was signed-off-by him). Signed-off-by: Magnus Lilja --- cpu/arm1136/start.S | 29 +++-- include/asm-arm/arch-mx31/mx31-regs.h | 90 +