Re: [U-Boot] [PATCH v2 1/2] spl_spi: Read default speed and mode values from DT

2018-12-13 Thread Patrick DELAUNAY
Hi Adam, Thanks for the tests, And sorry for the regression on your board. > From: Adam Ford > Sent: lundi 10 décembre 2018 23:48 > > On Mon, Nov 19, 2018 at 11:55 AM Patrick Delaunay > wrote: > > > > In case of DT boot, don't read default speed and mode for SPI from > > CONFIG_*, instead rea

Re: [U-Boot] [PATCH v2 1/2] spl_spi: Read default speed and mode values from DT

2018-12-10 Thread Adam Ford
On Mon, Nov 19, 2018 at 11:55 AM Patrick Delaunay wrote: > > In case of DT boot, don't read default speed and mode for SPI from > CONFIG_*, instead read from DT node. > > Signed-off-by: Christophe Kerello > Signed-off-by: Patrick Delaunay > --- > > Changes in v2: > - use variables to avoid dupli

Re: [U-Boot] [PATCH v2 1/2] spl_spi: Read default speed and mode values from DT

2018-12-10 Thread Patrick DELAUNAY
Hi Simon, > From: Simon Goldschmidt > Sent: mardi 27 novembre 2018 13:55 > Subject: Re: [PATCH v2 1/2] spl_spi: Read default speed and mode values from > DT > > On Tue, Nov 27, 2018 at 1:33 PM Patrick DELAUNAY > wrote: > > > > Hi Simon, > > > > > From: Simon Goldschmidt > > > Sent: mardi 27 n

Re: [U-Boot] [PATCH v2 1/2] spl_spi: Read default speed and mode values from DT

2018-11-27 Thread Simon Goldschmidt
On Tue, Nov 27, 2018 at 1:33 PM Patrick DELAUNAY wrote: > > Hi Simon, > > > From: Simon Goldschmidt > > Sent: mardi 27 novembre 2018 09:11 > > > > > On Tue, Nov 27, 2018 at 9:06 AM Patrick DELAUNAY > > wrote: > > > > > > Hi Simon, > > > > > > > -Original Message- > > > > From: Simon Gold

Re: [U-Boot] [PATCH v2 1/2] spl_spi: Read default speed and mode values from DT

2018-11-27 Thread Patrick DELAUNAY
Hi Simon, > From: Simon Goldschmidt > Sent: mardi 27 novembre 2018 09:11 > > On Tue, Nov 27, 2018 at 9:06 AM Patrick DELAUNAY > wrote: > > > > Hi Simon, > > > > > -Original Message- > > > From: Simon Goldschmidt > > > Sent: lundi 19 novembre 2018 20:09 > > > > > > On 19.11.2018 18:33,

Re: [U-Boot] [PATCH v2 1/2] spl_spi: Read default speed and mode values from DT

2018-11-27 Thread Simon Goldschmidt
On Tue, Nov 27, 2018 at 9:06 AM Patrick DELAUNAY wrote: > > Hi Simon, > > > -Original Message- > > From: Simon Goldschmidt > > Sent: lundi 19 novembre 2018 20:09 > > > > On 19.11.2018 18:33, Patrick Delaunay wrote: > > > In case of DT boot, don't read default speed and mode for SPI from >

Re: [U-Boot] [PATCH v2 1/2] spl_spi: Read default speed and mode values from DT

2018-11-27 Thread Patrick DELAUNAY
Hi Simon, > -Original Message- > From: Simon Goldschmidt > Sent: lundi 19 novembre 2018 20:09 > > On 19.11.2018 18:33, Patrick Delaunay wrote: > > In case of DT boot, don't read default speed and mode for SPI from > > CONFIG_*, instead read from DT node. > > > > Signed-off-by: Christophe

Re: [U-Boot] [PATCH v2 1/2] spl_spi: Read default speed and mode values from DT

2018-11-19 Thread Simon Goldschmidt
On 19.11.2018 18:33, Patrick Delaunay wrote: In case of DT boot, don't read default speed and mode for SPI from CONFIG_*, instead read from DT node. Signed-off-by: Christophe Kerello Signed-off-by: Patrick Delaunay I was commenting about code duplication, which is better now, so: Reviewed-b

[U-Boot] [PATCH v2 1/2] spl_spi: Read default speed and mode values from DT

2018-11-19 Thread Patrick Delaunay
In case of DT boot, don't read default speed and mode for SPI from CONFIG_*, instead read from DT node. Signed-off-by: Christophe Kerello Signed-off-by: Patrick Delaunay --- Changes in v2: - use variables to avoid duplicated code common/spl/spl_spi.c | 10 -- 1 file changed, 8 inserti