Re: [U-Boot] [PATCH v2] x86: Import the glibc memset implementation

2011-11-12 Thread Graeme Russ
Hi Gabe, On 12/11/11 17:19, Gabe Black wrote: > On Wed, Nov 9, 2011 at 12:47 PM, Mike Frysinger > wrote: > > On Wednesday 09 November 2011 14:12:15 Scott Wood wrote: > > Last I tried, I couldn't get it to work even with USE_PRIVATE_LIBGCC, > > because the co

Re: [U-Boot] [PATCH v2] x86: Import the glibc memset implementation

2011-11-11 Thread Gabe Black
On Wed, Nov 9, 2011 at 12:47 PM, Mike Frysinger wrote: > On Wednesday 09 November 2011 14:12:15 Scott Wood wrote: > > Last I tried, I couldn't get it to work even with USE_PRIVATE_LIBGCC, > > because the compiler was generating calls to things that U-Boot didn't > > implement. > > last i tried, i

Re: [U-Boot] [PATCH v2] x86: Import the glibc memset implementation

2011-11-09 Thread Mike Frysinger
On Wednesday 09 November 2011 14:12:15 Scott Wood wrote: > Last I tried, I couldn't get it to work even with USE_PRIVATE_LIBGCC, > because the compiler was generating calls to things that U-Boot didn't > implement. last i tried, i saw failures only for boards using yaffs as apparently that code t

Re: [U-Boot] [PATCH v2] x86: Import the glibc memset implementation

2011-11-09 Thread Scott Wood
On 11/08/2011 10:55 PM, Mike Frysinger wrote: > On Tuesday 08 November 2011 21:53:04 Graeme Russ wrote: >> Oops, I meant U-Boot implements a subset of (g)libc. I think I understand >> why - U-Boot needs specific implementations of stdio (printf() and friends) >> Because we need to implement _some_

Re: [U-Boot] [PATCH v2] x86: Import the glibc memset implementation

2011-11-08 Thread Graeme Russ
Hi Gabe, [snip] > From what I understand, USE_PRIVATE_LIBGCC was introduced because some > compilers/linkers have ABI compatibility issue (someone more familiar with > the history may be able to correct me) - This sounds _exactly_ what we > have here with x86 - x86 has an ABI incompatibility by u

Re: [U-Boot] [PATCH v2] x86: Import the glibc memset implementation

2011-11-08 Thread Graeme Russ
Hi Wolfgang, On Wed, Nov 9, 2011 at 4:36 PM, Wolfgang Denk wrote: > Dear Graeme Russ, > > In message > you > wrote: >> >> My point is, why does U-Boot implement parts of libgcc so as to not >> link to libgcc, but uses (by default) glibc - Why not always implement >> both, or always (by default

Re: [U-Boot] [PATCH v2] x86: Import the glibc memset implementation

2011-11-08 Thread Wolfgang Denk
Dear Graeme Russ, In message you wrote: > > My point is, why does U-Boot implement parts of libgcc so as to not > link to libgcc, but uses (by default) glibc - Why not always implement > both, or always (by default) link to both? We do NOT link glibc. IF there should beany such case anywhere,

Re: [U-Boot] [PATCH v2] x86: Import the glibc memset implementation

2011-11-08 Thread Gabe Black
On Tue, Nov 8, 2011 at 8:55 PM, Mike Frysinger wrote: > On Tuesday 08 November 2011 21:53:04 Graeme Russ wrote: > > Oops, I meant U-Boot implements a subset of (g)libc. I think I understand > > why - U-Boot needs specific implementations of stdio (printf() and > friends) > > Because we need to im

Re: [U-Boot] [PATCH v2] x86: Import the glibc memset implementation

2011-11-08 Thread Mike Frysinger
On Tuesday 08 November 2011 21:53:04 Graeme Russ wrote: > Oops, I meant U-Boot implements a subset of (g)libc. I think I understand > why - U-Boot needs specific implementations of stdio (printf() and friends) > Because we need to implement _some_ of glibc, we need to implement all (or > at least a

Re: [U-Boot] [PATCH v2] x86: Import the glibc memset implementation

2011-11-08 Thread Graeme Russ
On Wed, Nov 9, 2011 at 12:52 PM, Gabe Black wrote: > > > On Tue, Nov 8, 2011 at 5:25 PM, Graeme Russ wrote: >> >> On Wed, Nov 9, 2011 at 12:15 PM, Gabe Black wrote: >> > >> > >> > On Tue, Nov 8, 2011 at 5:10 PM, Graeme Russ >> > wrote: >> >> >> >> Hi Gabe, >> >> >> >> first up - Please stop top

Re: [U-Boot] [PATCH v2] x86: Import the glibc memset implementation

2011-11-08 Thread Gabe Black
On Tue, Nov 8, 2011 at 5:25 PM, Graeme Russ wrote: > On Wed, Nov 9, 2011 at 12:15 PM, Gabe Black wrote: > > > > > > On Tue, Nov 8, 2011 at 5:10 PM, Graeme Russ > wrote: > >> > >> Hi Gabe, > >> > >> first up - Please stop top-posting > >> > >> On Wed, Nov 9, 2011 at 11:59 AM, Gabe Black > >> wr

Re: [U-Boot] [PATCH v2] x86: Import the glibc memset implementation

2011-11-08 Thread Graeme Russ
On Wed, Nov 9, 2011 at 12:15 PM, Gabe Black wrote: > > > On Tue, Nov 8, 2011 at 5:10 PM, Graeme Russ wrote: >> >> Hi Gabe, >> >> first up - Please stop top-posting >> >> On Wed, Nov 9, 2011 at 11:59 AM, Gabe Black >> wrote: >> > I'm pretty sure u-boot doesn't link with glibc. I'd expect that to

Re: [U-Boot] [PATCH v2] x86: Import the glibc memset implementation

2011-11-08 Thread Gabe Black
On Tue, Nov 8, 2011 at 5:10 PM, Graeme Russ wrote: > Hi Gabe, > > first up - Please stop top-posting > > On Wed, Nov 9, 2011 at 11:59 AM, Gabe Black > wrote: > > I'm pretty sure u-boot doesn't link with glibc. I'd expect that to cause > all > > sorts of problems on top of being really big. There

Re: [U-Boot] [PATCH v2] x86: Import the glibc memset implementation

2011-11-08 Thread Graeme Russ
Hi Gabe, first up - Please stop top-posting On Wed, Nov 9, 2011 at 11:59 AM, Gabe Black wrote: > I'm pretty sure u-boot doesn't link with glibc. I'd expect that to cause all > sorts of problems on top of being really big. There are default, generic > implementations which it can use, or you can

Re: [U-Boot] [PATCH v2] x86: Import the glibc memset implementation

2011-11-08 Thread Gabe Black
I'm pretty sure u-boot doesn't link with glibc. I'd expect that to cause all sorts of problems on top of being really big. There are default, generic implementations which it can use, or you can specialize them to take advantage of architecture specific features like I'm doing here. Gabe On Tue,

Re: [U-Boot] [PATCH v2] x86: Import the glibc memset implementation

2011-11-08 Thread Graeme Russ
Hi Gabe, On Wed, Nov 9, 2011 at 9:40 AM, Gabe Black wrote: > The new implementation is about twice as fast as the old. > I don't get it - If this is the glibc implementation, we aren't we just using the implementation in the glibc library which we link to? Regards, Graeme

[U-Boot] [PATCH v2] x86: Import the glibc memset implementation

2011-11-08 Thread Gabe Black
The new implementation is about twice as fast as the old. Signed-off-by: Gabe Black --- Changes in v2: Update the commit summary as suggested by Mike Frysinger. arch/x86/include/asm/string.h |2 +- arch/x86/lib/Makefile |1 + arch/x86/lib/string.c | 87