Re: [U-Boot] [PATCH v2] gpio: omap_gpio: Fix valid gpio range for AM33XX

2013-06-21 Thread Lubomir Popov
Hi Heiko, Axel, On 21/06/13 11:44, Heiko Schocher wrote: > Hello Lubomir, > > Am 21.06.2013 09:44, schrieb Lubomir Popov: >> One more thing that perhaps seems more reasonable in general: >> >> These OMAP_MAX_GPIO defines could go into the corresponding .../arch-omap*.h >> files, where the base ad

Re: [U-Boot] [PATCH v2] gpio: omap_gpio: Fix valid gpio range for AM33XX

2013-06-21 Thread Axel Lin
2013/6/21 Heiko Schocher : > Hello Lubomir, > > Am 21.06.2013 09:44, schrieb Lubomir Popov: >> One more thing that perhaps seems more reasonable in general: >> >> These OMAP_MAX_GPIO defines could go into the corresponding .../arch-omap*.h >> files, where the base addresses are defined, and the num

Re: [U-Boot] [PATCH v2] gpio: omap_gpio: Fix valid gpio range for AM33XX

2013-06-21 Thread Heiko Schocher
Hello Lubomir, Am 21.06.2013 09:44, schrieb Lubomir Popov: > One more thing that perhaps seems more reasonable in general: > > These OMAP_MAX_GPIO defines could go into the corresponding .../arch-omap*.h > files, where the base addresses are defined, and the number of GPIOs is > implicitly obviou

Re: [U-Boot] [PATCH v2] gpio: omap_gpio: Fix valid gpio range for AM33XX

2013-06-21 Thread Lubomir Popov
One more thing that perhaps seems more reasonable in general: These OMAP_MAX_GPIO defines could go into the corresponding .../arch-omap*.h files, where the base addresses are defined, and the number of GPIOs is implicitly obvious. And we shall have no ugly #ifdefs in the GPIO driver. Tom, what do

Re: [U-Boot] [PATCH v2] gpio: omap_gpio: Fix valid gpio range for AM33XX

2013-06-21 Thread Lubomir Popov
Hi Axel, On 21/06/13 10:13, Axel Lin wrote: > 2013/6/21 Lubomir Popov : >> Hi Axel, >> >> On 21/06/13 06:07, Axel Lin wrote: >>> AM33XX has 4 gpio banks, thus the valid gpio range should be 0 ... 127. >>> >>> Signed-off-by: Axel Lin >>> --- >>> v2: define OMAP_MAX_GPIO and use it. >>> This change

Re: [U-Boot] [PATCH v2] gpio: omap_gpio: Fix valid gpio range for AM33XX

2013-06-21 Thread Axel Lin
2013/6/21 Lubomir Popov : > Hi Axel, > > On 21/06/13 06:07, Axel Lin wrote: >> AM33XX has 4 gpio banks, thus the valid gpio range should be 0 ... 127. >> >> Signed-off-by: Axel Lin >> --- >> v2: define OMAP_MAX_GPIO and use it. >> This change is mainly based on Stefan's comment, however I use >> O

Re: [U-Boot] [PATCH v2] gpio: omap_gpio: Fix valid gpio range for AM33XX

2013-06-21 Thread Lubomir Popov
Hi Axel, On 21/06/13 06:07, Axel Lin wrote: > AM33XX has 4 gpio banks, thus the valid gpio range should be 0 ... 127. > > Signed-off-by: Axel Lin > --- > v2: define OMAP_MAX_GPIO and use it. > This change is mainly based on Stefan's comment, however I use > OMAP_MAX_GPIO instead of CONFIG_OMAP_M

Re: [U-Boot] [PATCH v2] gpio: omap_gpio: Fix valid gpio range for AM33XX

2013-06-20 Thread Stefan Roese
On 21.06.2013 05:07, Axel Lin wrote: > AM33XX has 4 gpio banks, thus the valid gpio range should be 0 ... 127. > > Signed-off-by: Axel Lin Acked-by: Stefan Roese Thanks, Stefan ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman

[U-Boot] [PATCH v2] gpio: omap_gpio: Fix valid gpio range for AM33XX

2013-06-20 Thread Axel Lin
AM33XX has 4 gpio banks, thus the valid gpio range should be 0 ... 127. Signed-off-by: Axel Lin --- v2: define OMAP_MAX_GPIO and use it. This change is mainly based on Stefan's comment, however I use OMAP_MAX_GPIO instead of CONFIG_OMAP_MAX_GPIO because having CONFIG_ prefix seems meaning it can