Re: [U-Boot] [PATCH v2] designware_i2c: Enhance DesignWare I2C driver address support

2014-02-04 Thread Chin Liang See
Hi Heiko, On Thu, 2014-01-30 at 06:20 +0100, Heiko Schocher wrote: > Hello Chin, > > Am 22.01.2014 16:37, schrieb Chin Liang See: > > Thanks Alexey. > > > > Hi Heiko, > > > > I believe this patch should be good for apply. Would need your help > > then. :) Thanks > > > > Chin Liang > > > > > > On

Re: [U-Boot] [PATCH v2] designware_i2c: Enhance DesignWare I2C driver address support

2014-01-29 Thread Heiko Schocher
Hello Chin, Am 22.01.2014 16:37, schrieb Chin Liang See: Thanks Alexey. Hi Heiko, I believe this patch should be good for apply. Would need your help then. :) Thanks Chin Liang On Wed, 2014-01-15 at 15:51 +, Alexey Brodkin wrote: On Wed, 2014-01-15 at 09:45 -0600, Chin Liang See wrote:

Re: [U-Boot] [PATCH v2] designware_i2c: Enhance DesignWare I2C driver address support

2014-01-22 Thread Chin Liang See
Thanks Alexey. Hi Heiko, I believe this patch should be good for apply. Would need your help then. :) Thanks Chin Liang On Wed, 2014-01-15 at 15:51 +, Alexey Brodkin wrote: > On Wed, 2014-01-15 at 09:45 -0600, Chin Liang See wrote: > > Changes for v2 > > - Removed the function check_params

Re: [U-Boot] [PATCH v2] designware_i2c: Enhance DesignWare I2C driver address support

2014-01-15 Thread Alexey Brodkin
On Wed, 2014-01-15 at 09:45 -0600, Chin Liang See wrote: > Changes for v2 > - Removed the function check_params() Ok, so you decided to not add "assert" check instead. I think it's ok - it's not a requirement. Others don't do it as well so let's leave it as it is. Acked-by: Alexey Brodkin Regar

[U-Boot] [PATCH v2] designware_i2c: Enhance DesignWare I2C driver address support

2014-01-15 Thread Chin Liang See
Enhance the DesignWare I2C driver to support address length more than 1 byte. This enhancement is required as some I2C slave device such as EEPROM chip might have 16 bit address byte. Signed-off-by: Chin Liang See Cc: Alexey Brodkin Cc: Tom Rini cc: Armando Visconti Cc: Stefan Roese Cc: Alber