Hi Heiko, On Thu, 2014-01-30 at 06:20 +0100, Heiko Schocher wrote: > Hello Chin, > > Am 22.01.2014 16:37, schrieb Chin Liang See: > > Thanks Alexey. > > > > Hi Heiko, > > > > I believe this patch should be good for apply. Would need your help > > then. :) Thanks > > > > Chin Liang > > > > > > On Wed, 2014-01-15 at 15:51 +0000, Alexey Brodkin wrote: > >> On Wed, 2014-01-15 at 09:45 -0600, Chin Liang See wrote: > >>> Changes for v2 > >>> - Removed the function check_params() > >> > >> Ok, so you decided to not add "assert" check instead. > >> I think it's ok - it's not a requirement. Others don't do it as well so > >> let's leave it as it is. > >> > >> Acked-by: Alexey Brodkin<abrod...@synopsys.com> > >> > >> Regards, > >> Alexey > > Your patch apply not clean to current head > f889cc81c1572f4af0be950fd49bb6b67bc580fb > also checkpatch drops one warning: >
Yup, it caused by a later patch. Let me re-base my patch. > CHECK: Alignment should match open parenthesis > #82: FILE: drivers/i2c/designware_i2c.c:210: > + writel((addr >> (alen * 8)) & 0xff, > + &i2c_regs_p->ic_cmd_data); > > total: 0 errors, 0 warnings, 1 checks, 64 lines checked I overlooked this as I saw no errors. Let me fix that too. Thanks again for your helps. Chin Liang > > Could you please fix this, thanks! > > bye, > Heiko _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
