Re: [U-Boot] [PATCH v1 2/3] lib: rsa: generate additional parameters for public key

2019-10-29 Thread Simon Glass
Hi AKASHI, > > > > > > > > There is precedent for this. It's just that I'm not sure the code is > > > > complicated enough to worry about keeping the comment-free > > > > single-char-variable style? > > > > > > > > +Tom Rini I assume you are OK with this? > > > > > > When we import code from anoth

Re: [U-Boot] [PATCH v1 2/3] lib: rsa: generate additional parameters for public key

2019-10-27 Thread AKASHI Takahiro
Simon, Tom, On Fri, Oct 25, 2019 at 12:29:08PM -0600, Simon Glass wrote: > Hi, > > On Fri, 25 Oct 2019 at 12:27, Tom Rini wrote: > > > > On Thu, Oct 24, 2019 at 03:36:07PM -0600, Simon Glass wrote: > > > Hi, > > > > > > On Tue, 22 Oct 2019 at 23:23, AKASHI Takahiro > > > wrote: > > > > > > > >

Re: [U-Boot] [PATCH v1 2/3] lib: rsa: generate additional parameters for public key

2019-10-25 Thread Simon Glass
Hi, On Fri, 25 Oct 2019 at 12:27, Tom Rini wrote: > > On Thu, Oct 24, 2019 at 03:36:07PM -0600, Simon Glass wrote: > > Hi, > > > > On Tue, 22 Oct 2019 at 23:23, AKASHI Takahiro > > wrote: > > > > > > On Mon, Oct 21, 2019 at 06:17:03PM -0600, Simon Glass wrote: > > > > Hi Takahiro, > > > > > > >

Re: [U-Boot] [PATCH v1 2/3] lib: rsa: generate additional parameters for public key

2019-10-25 Thread Tom Rini
On Thu, Oct 24, 2019 at 03:36:07PM -0600, Simon Glass wrote: > Hi, > > On Tue, 22 Oct 2019 at 23:23, AKASHI Takahiro > wrote: > > > > On Mon, Oct 21, 2019 at 06:17:03PM -0600, Simon Glass wrote: > > > Hi Takahiro, > > > > > > On Tue, 8 Oct 2019 at 23:27, AKASHI Takahiro > > > wrote: > > > > > >

Re: [U-Boot] [PATCH v1 2/3] lib: rsa: generate additional parameters for public key

2019-10-24 Thread Simon Glass
Hi, On Tue, 22 Oct 2019 at 23:23, AKASHI Takahiro wrote: > > On Mon, Oct 21, 2019 at 06:17:03PM -0600, Simon Glass wrote: > > Hi Takahiro, > > > > On Tue, 8 Oct 2019 at 23:27, AKASHI Takahiro > > wrote: > > > > > > In the current implementation of FIT_SIGNATURE, five parameters for > > > a RSA

Re: [U-Boot] [PATCH v1 2/3] lib: rsa: generate additional parameters for public key

2019-10-22 Thread AKASHI Takahiro
On Mon, Oct 21, 2019 at 06:17:03PM -0600, Simon Glass wrote: > Hi Takahiro, > > On Tue, 8 Oct 2019 at 23:27, AKASHI Takahiro > wrote: > > > > In the current implementation of FIT_SIGNATURE, five parameters for > > a RSA public key are required while only two of them are essential. > > (See rsa-m

Re: [U-Boot] [PATCH v1 2/3] lib: rsa: generate additional parameters for public key

2019-10-21 Thread Simon Glass
Hi Takahiro, On Tue, 8 Oct 2019 at 23:27, AKASHI Takahiro wrote: > > In the current implementation of FIT_SIGNATURE, five parameters for > a RSA public key are required while only two of them are essential. > (See rsa-mod-exp.h and uImage.FIT/signature.txt) > This is a result of considering relat

[U-Boot] [PATCH v1 2/3] lib: rsa: generate additional parameters for public key

2019-10-08 Thread AKASHI Takahiro
In the current implementation of FIT_SIGNATURE, five parameters for a RSA public key are required while only two of them are essential. (See rsa-mod-exp.h and uImage.FIT/signature.txt) This is a result of considering relatively limited computer power and resources on embedded systems, while such a