Re: [U-Boot] [PATCH V7 2/3] PMIC: Add dialog pmic support

2011-05-13 Thread Jason Hui
Hi, Stefano On Fri, May 13, 2011 at 4:47 PM, Stefano Babic wrote: > On 05/13/2011 10:41 AM, Jason Liu wrote: > >>> The patch adds several functions that are strictly related to the >>> processor and I am checking with the reference manuals to understand >>> them. I need more time for it. >> >> If

Re: [U-Boot] [PATCH V7 2/3] PMIC: Add dialog pmic support

2011-05-13 Thread Stefano Babic
On 05/13/2011 10:41 AM, Jason Liu wrote: >> The patch adds several functions that are strictly related to the >> processor and I am checking with the reference manuals to understand >> them. I need more time for it. > > If that, can we consider that I just add the basic mx53loco support: > which

Re: [U-Boot] [PATCH V7 2/3] PMIC: Add dialog pmic support

2011-05-13 Thread Jason Liu
Hi, Stefano, 2011/5/13 Stefano Babic : > On 05/13/2011 05:08 AM, Jason Liu wrote: >> Hi, Stefano, > > Hi Jason, > [...] >> >> And BTW, do you have any comments about the 1/3 clock patch? If you >> have, please tell it >> as early as possible and I don't want to let the patch version goes up >> ver

Re: [U-Boot] [PATCH V7 2/3] PMIC: Add dialog pmic support

2011-05-12 Thread Stefano Babic
On 05/13/2011 05:08 AM, Jason Liu wrote: > Hi, Stefano, Hi Jason, >> This is not what I meant. You have duplicated the code, instead of merge >> the two functions together. And I think the switch is wrong. >> This file provides a general access to PMIc using SPI/I2C. There should >> not be #ifdef

Re: [U-Boot] [PATCH V7 2/3] PMIC: Add dialog pmic support

2011-05-12 Thread Jason Liu
Hi, Stefano, 2011/5/12 Stefano Babic : > On 05/11/2011 10:03 AM, Jason Liu wrote: >> This patch add dialog pmic(DA9053) driver with I2C interface support >> In order to not duplicate code and according to the discussion on the >> mail-list, change fsl_pmic.c to spi_i2c_pmic.c.Actaully,spi_i2c_pmic

Re: [U-Boot] [PATCH V7 2/3] PMIC: Add dialog pmic support

2011-05-12 Thread Stefano Babic
On 05/11/2011 10:03 AM, Jason Liu wrote: > This patch add dialog pmic(DA9053) driver with I2C interface support > In order to not duplicate code and according to the discussion on the > mail-list, change fsl_pmic.c to spi_i2c_pmic.c.Actaully,spi_i2c_pmic.c > is just a wrapper for PMIC communication

[U-Boot] [PATCH V7 2/3] PMIC: Add dialog pmic support

2011-05-11 Thread Jason Liu
This patch add dialog pmic(DA9053) driver with I2C interface support In order to not duplicate code and according to the discussion on the mail-list, change fsl_pmic.c to spi_i2c_pmic.c.Actaully,spi_i2c_pmic.c is just a wrapper for PMIC communication when SPI or I2C is used. Signed-off-by: Jason L