Re: [U-Boot] [PATCH V7 0/4] Add disk support to orion5x and edminiv2

2010-08-06 Thread Albert ARIBAUD
Le 06/08/2010 10:18, Prafulla Wadaskar a écrit : > Any System = f(board, soc). > We have board configs header file in place. > Just having soc-config header file would be enough, > We should have included within board config file. > Any unwanted stuff can be undefed below it. > > Regards.. > Praf

Re: [U-Boot] [PATCH V7 0/4] Add disk support to orion5x and edminiv2

2010-08-06 Thread Prafulla Wadaskar
Thursday, August 05, 2010 11:55 PM > >> To: Albert ARIBAUD > >> Cc: u-boot@lists.denx.de > >> Subject: Re: [U-Boot] [PATCH V7 0/4] Add disk support to > >> orion5x and edminiv2 > >> > >> Dear Albert ARIBAUD, > >> > >> In message&l

Re: [U-Boot] [PATCH V7 0/4] Add disk support to orion5x and edminiv2

2010-08-06 Thread Albert ARIBAUD
t; Cc: u-boot@lists.denx.de >> Subject: Re: [U-Boot] [PATCH V7 0/4] Add disk support to >> orion5x and edminiv2 >> >> Dear Albert ARIBAUD, >> >> In message<4c5ad4f7.2030...@free.fr> you wrote: >>> >>> As for the configs, some u-boot boards

Re: [U-Boot] [PATCH V7 0/4] Add disk support to orion5x and edminiv2

2010-08-05 Thread Prafulla Wadaskar
> -Original Message- > From: u-boot-boun...@lists.denx.de > [mailto:u-boot-boun...@lists.denx.de] On Behalf Of Wolfgang Denk > Sent: Thursday, August 05, 2010 11:55 PM > To: Albert ARIBAUD > Cc: u-boot@lists.denx.de > Subject: Re: [U-Boot] [PATCH V7 0/4] Add disk

Re: [U-Boot] [PATCH V7 0/4] Add disk support to orion5x and edminiv2

2010-08-05 Thread Wolfgang Denk
Dear Albert ARIBAUD, In message <4c5ad4f7.2030...@free.fr> you wrote: > > As for the configs, some u-boot boards do commonalize, see for instance > include/configs/spear*.h. That makes sense because there is a board > family, with a common HW design and common external components. This is not act

Re: [U-Boot] [PATCH V7 0/4] Add disk support to orion5x and edminiv2

2010-08-05 Thread Rogan Dawes
On 2010/08/05 5:12 PM, Albert ARIBAUD wrote: > Le 05/08/2010 16:28, Rogan Dawes a écrit : >> On 2010/08/05 4:11 PM, Albert ARIBAUD wrote: >>> Rogan, what other code do you think you'd be duplicating? >>> >>> Amicalement, >> >> In truth, I was really thinking only of the config files, not really the

Re: [U-Boot] [PATCH V7 0/4] Add disk support to orion5x and edminiv2

2010-08-05 Thread Albert ARIBAUD
Le 05/08/2010 16:28, Rogan Dawes a écrit : > On 2010/08/05 4:11 PM, Albert ARIBAUD wrote: >> Rogan, what other code do you think you'd be duplicating? >> >> Amicalement, > > In truth, I was really thinking only of the config files, not really the > code per se. > > I suppose that there is not reall

Re: [U-Boot] [PATCH V7 0/4] Add disk support to orion5x and edminiv2

2010-08-05 Thread Rogan Dawes
On 2010/08/05 4:11 PM, Albert ARIBAUD wrote: > Rogan, what other code do you think you'd be duplicating? > > Amicalement, In truth, I was really thinking only of the config files, not really the code per se. I suppose that there is not really that much else that really is common. Rogan

Re: [U-Boot] [PATCH V7 0/4] Add disk support to orion5x and edminiv2

2010-08-05 Thread Albert ARIBAUD
Le 05/08/2010 15:02, Wolfgang Denk a écrit : > Dear Rogan Dawes, > > In message<4c5ab1a4.3000...@dawes.za.net> you wrote: >> This may be a stupid comment, but from my perspective implementing >> Albert's orion5x changes for my DNS323, all I am doing is copying a lot >> of what Albert is doing for

Re: [U-Boot] [PATCH V7 0/4] Add disk support to orion5x and edminiv2

2010-08-05 Thread Wolfgang Denk
Dear Rogan Dawes, In message <4c5ab1a4.3000...@dawes.za.net> you wrote: > This may be a stupid comment, but from my perspective implementing > Albert's orion5x changes for my DNS323, all I am doing is copying a lot > of what Albert is doing for the edminiv2 verbatim. > > Would it not make sense

Re: [U-Boot] [PATCH V7 0/4] Add disk support to orion5x and edminiv2

2010-08-05 Thread Rogan Dawes
This may be a stupid comment, but from my perspective implementing Albert's orion5x changes for my DNS323, all I am doing is copying a lot of what Albert is doing for the edminiv2 verbatim. Would it not make sense perhaps to define defaults in a SoC config file, and then allow them to be overri

[U-Boot] [PATCH V7 0/4] Add disk support to orion5x and edminiv2

2010-08-05 Thread Albert Aribaud
Patchset history: V1: Initial 4-patch set -- not cleanly submitted (does not appear on gmane for instance) and contained some unrelated changes. V2: Slimmed down to 3 patches and removed unrelated changes. V3: Back to 4 patches (cmd_ide improvement, driver addition, cmd_ide suppo