Re: [U-Boot] [PATCH V2] imx25: Fix reset

2010-10-26 Thread Jason Liu
Hi, 2010/10/26 Matthias Weißer : > Am 26.10.2010 11:27, schrieb Reinhard Meyer: >> Dear Matthias Weisser, >>> This patch fixes the reset command on imx25 >>> >>> Signed-off-by: Matthias Weisser >>> +    writew(0x,®s->wcr); >>> +    writew(0x,®s->wsr); >>> +    writew(0x,®s-

Re: [U-Boot] [PATCH V2] imx25: Fix reset

2010-10-26 Thread Matthias Weißer
Am 26.10.2010 11:27, schrieb Reinhard Meyer: > Dear Matthias Weisser, >> This patch fixes the reset command on imx25 >> >> Signed-off-by: Matthias Weisser >> +writew(0x,®s->wcr); >> +writew(0x,®s->wsr); >> +writew(0x,®s->wsr); > > It might be "nicer" to use 16 Bi

Re: [U-Boot] [PATCH V2] imx25: Fix reset

2010-10-26 Thread Reinhard Meyer
Dear Matthias Weisser, > This patch fixes the reset command on imx25 > > Signed-off-by: Matthias Weisser > + writew(0x, ®s->wcr); > + writew(0x, ®s->wsr); > + writew(0x, ®s->wsr); It might be "nicer" to use 16 Bit constants (with 4 hex digits) here..? Best Re

[U-Boot] [PATCH V2] imx25: Fix reset

2010-10-26 Thread Matthias Weisser
This patch fixes the reset command on imx25 Signed-off-by: Matthias Weisser --- arch/arm/cpu/arm926ejs/mx25/reset.c |8 arch/arm/include/asm/arch-mx25/imx-regs.h | 10 +- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/arch/arm/cpu/arm926ejs/mx25/reset