Re: [U-Boot] [PATCH V2] imx25: Fix reset

[Jason Liu]

Hi,

2010/10/26 Matthias Weißer <weiss...@arcor.de>:
> Am 26.10.2010 11:27, schrieb Reinhard Meyer:
>> Dear Matthias Weisser,
>>> This patch fixes the reset command on imx25
>>>
>>> Signed-off-by: Matthias Weisser<weiss...@arcor.de>
>>> +    writew(0x00000000,&regs->wcr);
>>> +    writew(0x00005555,&regs->wsr);
>>> +    writew(0x0000AAAA,&regs->wsr);
>>
>> It might be "nicer" to use 16 Bit constants (with 4 hex digits)
>> here..?
>
> Sure. Would be nicer. I wait a bit for further comments and will create
> a V3 then.

Add please append to the commit log about why you make such change?
It will be clear to read and understand your change for this patch.

>
> Matthias
> _______________________________________________
> U-Boot mailing list
> U-Boot@lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
>
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot