Re: [U-Boot] [PATCH 6/6] EA20: do not use subpage write for NAND

2011-04-25 Thread Scott Wood
On Fri, 22 Apr 2011 09:13:34 +0200 Stefano Babic wrote: > The only point is we need that the controller checks the parameters > after the tail part, as the tail part scans the chip and sets its > options, as the SUBPAGE flag. We could add a pre_adjust() and > post_adjust() functions to be called

Re: [U-Boot] [PATCH 6/6] EA20: do not use subpage write for NAND

2011-04-22 Thread Stefano Babic
On 04/15/2011 10:29 PM, Scott Wood wrote: > > nand_scan() is broken into head and tail functions. In Linux, the driver > calls these, and can look at the chip info before tail is called. In > U-boot, common code drives this, and the controller driver is not involved > -- but it would be good to

Re: [U-Boot] [PATCH 6/6] EA20: do not use subpage write for NAND

2011-04-15 Thread Scott Wood
On Fri, 15 Apr 2011 19:34:48 +0200 Stefano Babic wrote: > On 04/13/2011 06:24 PM, Scott Wood wrote: > > Hi Scott, > > > Davinci-specific #defines do not belong in nand_base.c[1]. The controller > > driver should be able to set "this isn't supported" options just as well as > > the chip data --

Re: [U-Boot] [PATCH 6/6] EA20: do not use subpage write for NAND

2011-04-15 Thread Stefano Babic
On 04/13/2011 06:24 PM, Scott Wood wrote: Hi Scott, > Davinci-specific #defines do not belong in nand_base.c[1]. The controller > driver should be able to set "this isn't supported" options just as well as > the chip data -- I just don't think it should be limited to this specific > one. surely

Re: [U-Boot] [PATCH 6/6] EA20: do not use subpage write for NAND

2011-04-13 Thread Scott Wood
On Tue, 12 Apr 2011 11:44:26 +0200 Stefano Babic wrote: > On 04/11/2011 09:16 PM, Scott Wood wrote: > > This only controls the davinci driver, so it should be > > CONFIG_SYS_DAVINCI_NAND_NO_SUBPAGE. > > > > Is this really board-specific? > > No, really not. > > > Does the davinci driver ever

Re: [U-Boot] [PATCH 6/6] EA20: do not use subpage write for NAND

2011-04-12 Thread Ben Gardiner
On Tue, Apr 12, 2011 at 5:08 AM, Stefano Babic wrote: > Ben Gardiner wrote: >> Thanks for sharing this patch -- I have been using the "-O 2048" (VID >> header offset) option to prevent subpages here. > > Yes, this works too, at least with Linux. (being picky / for archival purposes) In u-boot, sp

Re: [U-Boot] [PATCH 6/6] EA20: do not use subpage write for NAND

2011-04-12 Thread Stefano Babic
On 04/11/2011 09:16 PM, Scott Wood wrote: > This only controls the davinci driver, so it should be > CONFIG_SYS_DAVINCI_NAND_NO_SUBPAGE. > > Is this really board-specific? No, really not. > Does the davinci driver ever support > subpage? No, it does not. This problem affects all boards using t

Re: [U-Boot] [PATCH 6/6] EA20: do not use subpage write for NAND

2011-04-12 Thread Stefano Babic
On 04/11/2011 04:04 PM, Ben Gardiner wrote: > Hi Stefano, Hi Ben, > > Thanks for sharing this patch -- I have been using the "-O 2048" (VID > header offset) option to prevent subpages here. Yes, this works too, at least with Linux. > > On Sat, Apr 9, 2011 at 2:05 PM, Stefano Babic wrote: >>

Re: [U-Boot] [PATCH 6/6] EA20: do not use subpage write for NAND

2011-04-11 Thread Jon Povey
Ben Gardiner wrote: > "tries to access subpages" is maybe a little too vague; I think Jon > Povey described the problem quite succinctly: That's me, I better wake up! > What's more is that the davinci nand controller could do subpage > writing if the writing operation were informed of the extents

Re: [U-Boot] [PATCH 6/6] EA20: do not use subpage write for NAND

2011-04-11 Thread Scott Wood
On Sat, Apr 09, 2011 at 08:05:35PM +0200, Stefano Babic wrote: > diff --git a/README b/README > index 21cd71b..8d664eb 100644 > --- a/README > +++ b/README > @@ -2907,6 +2907,10 @@ Low Level (hardware related) configuration options: > that is executed before the actual U-Boot. E.g. wh

Re: [U-Boot] [PATCH 6/6] EA20: do not use subpage write for NAND

2011-04-11 Thread Ben Gardiner
Hi Stefano, Thanks for sharing this patch -- I have been using the "-O 2048" (VID header offset) option to prevent subpages here. On Sat, Apr 9, 2011 at 2:05 PM, Stefano Babic wrote: > The NAND controller does not support subpage accessing. This is > not used at all for MLC NAND, but it is set f

[U-Boot] [PATCH 6/6] EA20: do not use subpage write for NAND

2011-04-09 Thread Stefano Babic
The NAND controller does not support subpage accessing. This is not used at all for MLC NAND, but it is set for SLC NAND. UBI tries to access to subpages, and because it fails, it starts "torture tests" on the whole page that are always successful, making an endless loop with the UBI background tas