Re: [U-Boot] [PATCH 5/8] MXC FEC: Resolve speed before configuring gasket

2012-04-12 Thread Timo Ketola
On 12.04.2012 22:59, Troy Kisky wrote: On 4/12/2012 2:33 AM, Timo Ketola wrote: Signed-off-by: Timo Ketola + if (speed == _100BASET) This will break gigabit speed. How about if (speed != _10BASET) Looks fine to me. I'll put it that way in v2. -- Timo ___

Re: [U-Boot] [PATCH 5/8] MXC FEC: Resolve speed before configuring gasket

2012-04-12 Thread Troy Kisky
On 4/12/2012 2:33 AM, Timo Ketola wrote: Signed-off-by: Timo Ketola --- drivers/net/fec_mxc.c | 41 ++--- 1 files changed, 22 insertions(+), 19 deletions(-) diff --git a/drivers/net/fec_mxc.c b/drivers/net/fec_mxc.c index 1fdd071..5d11df2 100644 --- a/dri

Re: [U-Boot] [PATCH 5/8] MXC FEC: Resolve speed before configuring gasket

2012-04-12 Thread Stefano Babic
On 12/04/2012 15:16, Timo Ketola wrote: > On 12.04.2012 15:05, Stefano Babic wrote: >> On 12/04/2012 11:33, Timo Ketola wrote: >>> Signed-off-by: Timo Ketola > >>> --- a/drivers/net/fec_mxc.c >>> +++ b/drivers/net/fec_mxc.c >> >> Please consider to rebase your patch on u-boot-imx, next branch. The

Re: [U-Boot] [PATCH 5/8] MXC FEC: Resolve speed before configuring gasket

2012-04-12 Thread Timo Ketola
On 12.04.2012 15:05, Stefano Babic wrote: On 12/04/2012 11:33, Timo Ketola wrote: Signed-off-by: Timo Ketola --- a/drivers/net/fec_mxc.c +++ b/drivers/net/fec_mxc.c Please consider to rebase your patch on u-boot-imx, next branch. There are already a couple of patches related to gasket and M

Re: [U-Boot] [PATCH 5/8] MXC FEC: Resolve speed before configuring gasket

2012-04-12 Thread Wolfgang Denk
Dear "Timo Ketola", In message <1334223234-23383-6-git-send-email-t...@exertus.fi> you wrote: > Signed-off-by: Timo Ketola > --- > drivers/net/fec_mxc.c | 41 ++--- > 1 files changed, 22 insertions(+), 19 deletions(-) ... > + // FIXME: useless call: miip

Re: [U-Boot] [PATCH 5/8] MXC FEC: Resolve speed before configuring gasket

2012-04-12 Thread Stefano Babic
On 12/04/2012 11:33, Timo Ketola wrote: > Signed-off-by: Timo Ketola > --- Hi Timo, > drivers/net/fec_mxc.c | 41 ++--- > 1 files changed, 22 insertions(+), 19 deletions(-) > > diff --git a/drivers/net/fec_mxc.c b/drivers/net/fec_mxc.c > index 1fdd071..5d1

[U-Boot] [PATCH 5/8] MXC FEC: Resolve speed before configuring gasket

2012-04-12 Thread Timo Ketola
Signed-off-by: Timo Ketola --- drivers/net/fec_mxc.c | 41 ++--- 1 files changed, 22 insertions(+), 19 deletions(-) diff --git a/drivers/net/fec_mxc.c b/drivers/net/fec_mxc.c index 1fdd071..5d11df2 100644 --- a/drivers/net/fec_mxc.c +++ b/drivers/net/fec_mxc