Dear "Timo Ketola", In message <1334223234-23383-6-git-send-email-t...@exertus.fi> you wrote: > Signed-off-by: Timo Ketola <t...@exertus.fi> > --- > drivers/net/fec_mxc.c | 41 ++++++++++++++++++++++------------------- > 1 files changed, 22 insertions(+), 19 deletions(-) ... > + // FIXME: useless call: miiphy_duplex(edev->name, fec->phy_id);
ERROR: do not use C99 // comments > + /* configure gasket for RMII, 50 MHz, no loopback, and no echo > */ WARNING: line over 80 characters > + writew(MIIGSK_CFGR_IF_MODE_RMII, &fec->eth->miigsk_cfgr); > + else > + /* configure gasket for RMII, 5 MHz, no loopback, and no echo */ > + writew(MIIGSK_CFGR_IF_MODE_RMII | MIIGSK_CFGR_FRCONT, > &fec->eth->miigsk_cfgr); WARNING: line over 80 characters Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de "Beware of bugs in the above code; I have only proved it correct, not tried it." - Donald Knuth _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
