Re: [U-Boot] [PATCH 5/6] tegra: nand: Add Tegra NAND driver

2012-04-13 Thread Simon Glass
Hi Scott, On Fri, Apr 13, 2012 at 11:47 AM, Scott Wood wrote: > On 04/13/2012 01:45 PM, Simon Glass wrote: >> Hi Scott, >> >> On Fri, Apr 13, 2012 at 11:34 AM, Scott Wood wrote: >>> On 04/13/2012 01:25 PM, Simon Glass wrote: >>> Has this binding been accepted into Linux's documentation or an

Re: [U-Boot] [PATCH 5/6] tegra: nand: Add Tegra NAND driver

2012-04-13 Thread Scott Wood
On 04/13/2012 01:45 PM, Simon Glass wrote: > Hi Scott, > > On Fri, Apr 13, 2012 at 11:34 AM, Scott Wood wrote: >> On 04/13/2012 01:25 PM, Simon Glass wrote: >> Has this binding been accepted into Linux's documentation or another >> canonical source? > > No It would be go

Re: [U-Boot] [PATCH 5/6] tegra: nand: Add Tegra NAND driver

2012-04-13 Thread Simon Glass
Hi Scott, On Fri, Apr 13, 2012 at 11:34 AM, Scott Wood wrote: > On 04/13/2012 01:25 PM, Simon Glass wrote: >> Hi Scott, >> >> On Fri, Apr 13, 2012 at 11:09 AM, Scott Wood wrote: >>> On 04/13/2012 12:42 PM, Simon Glass wrote: I am not keen on adding cache alignment into every driver - IMO th

Re: [U-Boot] [PATCH 5/6] tegra: nand: Add Tegra NAND driver

2012-04-13 Thread Scott Wood
On 04/13/2012 01:25 PM, Simon Glass wrote: > Hi Scott, > > On Fri, Apr 13, 2012 at 11:09 AM, Scott Wood wrote: >> On 04/13/2012 12:42 PM, Simon Glass wrote: >>> I am not keen on adding cache alignment into every driver - IMO this >>> should happen at the level above as with MMC, USB, etc. A fairl

Re: [U-Boot] [PATCH 5/6] tegra: nand: Add Tegra NAND driver

2012-04-13 Thread Simon Glass
Hi Scott, On Fri, Apr 13, 2012 at 11:09 AM, Scott Wood wrote: > On 04/13/2012 12:42 PM, Simon Glass wrote: >> Hi Scott, >> >> On Fri, Jan 20, 2012 at 2:55 PM, Scott Wood wrote: >>> On 01/13/2012 05:10 PM, Simon Glass wrote: +struct nand_info nand_ctrl; >>> >>> static (or better, dynamic). >

Re: [U-Boot] [PATCH 5/6] tegra: nand: Add Tegra NAND driver

2012-04-13 Thread Scott Wood
On 04/13/2012 12:42 PM, Simon Glass wrote: > Hi Scott, > > On Fri, Jan 20, 2012 at 2:55 PM, Scott Wood wrote: >> On 01/13/2012 05:10 PM, Simon Glass wrote: >>> +struct nand_info nand_ctrl; >> >> static (or better, dynamic). > > Done, what is dynamic? Allocate the structure dynamically in your i

Re: [U-Boot] [PATCH 5/6] tegra: nand: Add Tegra NAND driver

2012-04-13 Thread Simon Glass
Hi Scott, On Fri, Jan 20, 2012 at 2:55 PM, Scott Wood wrote: > On 01/13/2012 05:10 PM, Simon Glass wrote: >> +/* Information about an attached NAND chip */ >> +struct fdt_nand { >> +     struct nand_ctlr *reg; >> +     int enabled;            /* 1 to enable, 0 to disable */ >> +     struct fdt_gp

Re: [U-Boot] [PATCH 5/6] tegra: nand: Add Tegra NAND driver

2012-04-13 Thread Simon Glass
Hi Stephen, On Fri, Jan 20, 2012 at 9:31 AM, Stephen Warren wrote: > On 01/13/2012 04:10 PM, Simon Glass wrote: >> From: Jim Lin >> >> A device tree is used to configure the NAND, including memory >> timings and block/pages sizes. >> >> If this node is not present or is disabled, then NAND will

Re: [U-Boot] [PATCH 5/6] tegra: nand: Add Tegra NAND driver

2012-01-20 Thread Scott Wood
On 01/13/2012 05:10 PM, Simon Glass wrote: > +/* Information about an attached NAND chip */ > +struct fdt_nand { > + struct nand_ctlr *reg; > + int enabled;/* 1 to enable, 0 to disable */ > + struct fdt_gpio_state wp_gpio; /* write-protect GPIO */ > + int width;

Re: [U-Boot] [PATCH 5/6] tegra: nand: Add Tegra NAND driver

2012-01-20 Thread Stephen Warren
On 01/13/2012 04:10 PM, Simon Glass wrote: > From: Jim Lin > > A device tree is used to configure the NAND, including memory > timings and block/pages sizes. > > If this node is not present or is disabled, then NAND will not > be initialized. > > Signed-off-by: Simon Glass > diff --git a/driv

Re: [U-Boot] [PATCH 5/6] tegra: nand: Add Tegra NAND driver

2012-01-15 Thread Jim Lin
/6] tegra: nand: Add Tegra NAND driver * PGP Signed by an unknown key On Saturday 14 January 2012 23:08:45 Simon Glass wrote: > On Sat, Jan 14, 2012 at 8:03 PM, Mike Frysinger wrote: > > On Friday 13 January 2012 18:10:55 Simon Glass wrote: > >> From: Jim Lin > >> &g

Re: [U-Boot] [PATCH 5/6] tegra: nand: Add Tegra NAND driver

2012-01-14 Thread Mike Frysinger
On Saturday 14 January 2012 23:08:45 Simon Glass wrote: > On Sat, Jan 14, 2012 at 8:03 PM, Mike Frysinger wrote: > > On Friday 13 January 2012 18:10:55 Simon Glass wrote: > >> From: Jim Lin > >> > >> A device tree is used to configure the NAND, including memory > >> timings and block/pages sizes.

Re: [U-Boot] [PATCH 5/6] tegra: nand: Add Tegra NAND driver

2012-01-14 Thread Simon Glass
Hi Mike, On Sat, Jan 14, 2012 at 8:03 PM, Mike Frysinger wrote: > On Friday 13 January 2012 18:10:55 Simon Glass wrote: >> From: Jim Lin >> >> A device tree is used to configure the NAND, including memory >> timings and block/pages sizes. >> >> If this node is not present or is disabled, then NA

Re: [U-Boot] [PATCH 5/6] tegra: nand: Add Tegra NAND driver

2012-01-14 Thread Mike Frysinger
On Friday 13 January 2012 18:10:55 Simon Glass wrote: > From: Jim Lin > > A device tree is used to configure the NAND, including memory > timings and block/pages sizes. > > If this node is not present or is disabled, then NAND will not > be initialized. > > Signed-off-by: Simon Glass the Auth

[U-Boot] [PATCH 5/6] tegra: nand: Add Tegra NAND driver

2012-01-13 Thread Simon Glass
From: Jim Lin A device tree is used to configure the NAND, including memory timings and block/pages sizes. If this node is not present or is disabled, then NAND will not be initialized. Signed-off-by: Simon Glass --- arch/arm/include/asm/arch-tegra2/tegra2.h |1 + drivers/mtd/nand/Makefil