Re: [U-Boot] [PATCH 4/6] Unify active vs. redundant environment variable naming

2008-08-31 Thread Wolfgang Denk
Dear Guennadi Liakhovetski, In message <[EMAIL PROTECTED]> you wrote: > > Would it suffice to change the patch description for this patch to be > accepted, or do you still want this patch to be dropped / changes? We > could use fdcur, fdtrg, devcur, devtrg, erasecur, erasetrg to save the > typ

Re: [U-Boot] [PATCH 4/6] Unify active vs. redundant environment variable naming

2008-08-31 Thread Guennadi Liakhovetski
On Sun, 31 Aug 2008, Wolfgang Denk wrote: > Dear Guennadi Liakhovetski, > > In message <[EMAIL PROTECTED]> you wrote: > > > > It's not purely stylistic. For example, previously the code had fd and > > fdr, curdev and otherdev. It used one erase struct for both main and > > redundant copies, th

Re: [U-Boot] [PATCH 4/6] Unify active vs. redundant environment variable naming

2008-08-31 Thread Wolfgang Denk
Dear Guennadi Liakhovetski, In message <[EMAIL PROTECTED]> you wrote: > > It's not purely stylistic. For example, previously the code had fd and > fdr, curdev and otherdev. It used one erase struct for both main and > redundant copies, thus they had to initialise it multiple times to one or >

Re: [U-Boot] [PATCH 4/6] Unify active vs. redundant environment variable naming

2008-08-31 Thread Guennadi Liakhovetski
On Sun, 31 Aug 2008, Wolfgang Denk wrote: > Dear Guennadi Liakhovetski, > > In message <[EMAIL PROTECTED]> you wrote: > > Use consistent naming for active and redundant environment variables, remove > > redundant erase struct initialisation by using separate structs for the > > active and redunda

Re: [U-Boot] [PATCH 4/6] Unify active vs. redundant environment variable naming

2008-08-31 Thread Wolfgang Denk
Dear Guennadi Liakhovetski, In message <[EMAIL PROTECTED]> you wrote: > Use consistent naming for active and redundant environment variables, remove > redundant erase struct initialisation by using separate structs for the > active and redundant environments. This is another sylistic change that

[U-Boot] [PATCH 4/6] Unify active vs. redundant environment variable naming

2008-08-27 Thread Guennadi Liakhovetski
Use consistent naming for active and redundant environment variables, remove redundant erase struct initialisation by using separate structs for the active and redundant environments. Signed-off-by: Guennadi Liakhovetski <[EMAIL PROTECTED]> --- tools/env/fw_env.c | 129 +-