Re: [U-Boot] [PATCH 4/4 v3] xilinx: Add new Zynq board

2012-09-13 Thread Michal Simek
On 09/14/2012 06:03 AM, Joe Hershberger wrote: Hi Michal, On Thu, Aug 16, 2012 at 1:30 AM, Michal Simek wrote: Add support for Xilinx Zynq board. Signed-off-by: Michal Simek --- v2: Forget to also add config file v3: Change name for serial driver Remove lowlevel_init from board folder

Re: [U-Boot] [PATCH 4/4 v3] xilinx: Add new Zynq board

2012-09-13 Thread Joe Hershberger
Hi Michal, On Thu, Aug 16, 2012 at 1:30 AM, Michal Simek wrote: > Add support for Xilinx Zynq board. > > Signed-off-by: Michal Simek > > --- > v2: Forget to also add config file > > v3: Change name for serial driver > Remove lowlevel_init from board folder > Remove XPSS part from timer b

Re: [U-Boot] [PATCH 4/4 v3] xilinx: Add new Zynq board

2012-09-13 Thread Marek Vasut
Dear Michal Simek, > On 09/13/2012 11:35 AM, Marek Vasut wrote: > > Dear Michal Simek, > > > > [...] > > > >> +int board_init(void) > >> +{ > >> + icache_enable(); > > > > Uh oh ... isn't this on by default when CONFIG_ICACHE_OFF isn't present? > > Will check this one. > > >> + return 0; >

Re: [U-Boot] [PATCH 4/4 v3] xilinx: Add new Zynq board

2012-09-13 Thread Michal Simek
On 09/13/2012 11:35 AM, Marek Vasut wrote: Dear Michal Simek, [...] +int board_init(void) +{ + icache_enable(); Uh oh ... isn't this on by default when CONFIG_ICACHE_OFF isn't present? That option is valid just for blackfin. In arm1176 and s3c44b0v is this done in arch_cpu_init() bu

Re: [U-Boot] [PATCH 4/4 v3] xilinx: Add new Zynq board

2012-09-13 Thread Michal Simek
On 09/13/2012 11:35 AM, Marek Vasut wrote: Dear Michal Simek, [...] +int board_init(void) +{ + icache_enable(); Uh oh ... isn't this on by default when CONFIG_ICACHE_OFF isn't present? Will check this one. + return 0; +} + +int board_late_init(void) +{ + return 0; Y

Re: [U-Boot] [PATCH 4/4 v3] xilinx: Add new Zynq board

2012-09-13 Thread Marek Vasut
Dear Michal Simek, [...] > +int board_init(void) > +{ > + icache_enable(); Uh oh ... isn't this on by default when CONFIG_ICACHE_OFF isn't present? > + return 0; > +} > + > +int board_late_init(void) > +{ > + return 0; You don't need this. > +} > + > +#ifdef CONFIG_CMD_NET > +int

Re: [U-Boot] [PATCH 4/4 v3] xilinx: Add new Zynq board

2012-09-12 Thread Michal Simek
On 08/16/2012 08:30 AM, Michal Simek wrote: Add support for Xilinx Zynq board. Signed-off-by: Michal Simek --- v2: Forget to also add config file v3: Change name for serial driver Remove lowlevel_init from board folder Remove XPSS part from timer baseaddr Change name for Zynq g

[U-Boot] [PATCH 4/4 v3] xilinx: Add new Zynq board

2012-08-15 Thread Michal Simek
Add support for Xilinx Zynq board. Signed-off-by: Michal Simek --- v2: Forget to also add config file v3: Change name for serial driver Remove lowlevel_init from board folder Remove XPSS part from timer baseaddr Change name for Zynq gem driver Clean coding style Remove mac +