David Jander wrote:
>
> Hmmm. In that case they should have other names, and one should probably make
> the set complete with all combinations, and I doubt it'll make sense anymore
> then
> This subset of possibilities is too specific to our board I fear.
Ok, I understand. I have thought it
On Friday 20 August 2010 11:51:18 am Stefano Babic wrote:
> Hi David,
>
> in addition to Wolfgang's comments:
> > +static u32 system_rev;
> > +struct io_board_ctrl *mx51_io_board;
>
> Structure is not used, and probably does not match your board. You
> should drop it.
Ok, I was already wondering
David Jander wrote:
> Signed-off-by: David Jander
> ---
Hi David,
in addition to Wolfgang's comments:
> +static u32 system_rev;
> +struct io_board_ctrl *mx51_io_board;
Structure is not used, and probably does not match your board. You
should drop it.
> +#define POUT_HS (PAD_CTL_DRV_HIGH | PAD
Wolfgang Denk wrote:
Hi Wolfgang,
>> +pmic_reg_write(REG_POWER_MISC, GPO4ADIN);
>
> It would really be great if someone cold clean up this mess in
> "include/fsl_pmic.h"
>
> Using an "enum" for register definitions is just horrible.
>
> I am well aware that you did not introduce this code,
Dear Wolfgang,
On Thursday 19 August 2010 03:03:54 pm Wolfgang Denk wrote:
>[...]
> > create mode 100644 board/Protonic/prtlvt2/Makefile
> > create mode 100644 board/Protonic/prtlvt2/config.mk
> > create mode 100644 board/Protonic/prtlvt2/imximage.cfg
> > create mode 100644 board/Protonic/prt
Dear David Jander,
In message
<00b6eb8822a36b67a5e6154fd256e51e605fe47a.1282213859.git.da...@protonic.nl> you
wrote:
>
> board/Protonic/prtlvt2/Makefile | 48
> board/Protonic/prtlvt2/config.mk| 25 ++
> board/Protonic/prtlvt2/imximage.cfg | 171
> board/Protonic/
Signed-off-by: David Jander
---
board/Protonic/prtlvt2/Makefile | 48
board/Protonic/prtlvt2/config.mk| 25 ++
board/Protonic/prtlvt2/imximage.cfg | 171
board/Protonic/prtlvt2/prtlvt2.c| 513 +++
board/Protonic/prtlvt2/prtlvt2.h
7 matches
Mail list logo
