Re: [U-Boot] [PATCH 3/9] openrisc: Add cpu files

2011-11-22 Thread Mike Frysinger
On Monday 21 November 2011 23:46:41 Marek Vasut wrote: > > On Mon, Nov 21, 2011 at 11:50:17PM +0100, Marek Vasut wrote: > > > > + l.addi r3,r3,4 > > > > + l.sfltu r4,r5 > > > > + l.bf.L_reloc > > > > +l.addi r4,r4,4 /* delay slot */ > > > > > > The fo

Re: [U-Boot] [PATCH 3/9] openrisc: Add cpu files

2011-11-22 Thread Scott Wood
On 11/22/2011 08:07 AM, Marek Vasut wrote: >> On Tue, Nov 22, 2011 at 05:46:41AM +0100, Marek Vasut wrote: On Mon, Nov 21, 2011 at 11:50:17PM +0100, Marek Vasut wrote: >> +printf("CPU: OpenRISC-%x00 (rev %d) @ %d MHz\n", >> +ver, rev, (CONFIG_SYS_CLK_FREQ / 10

Re: [U-Boot] [PATCH 3/9] openrisc: Add cpu files

2011-11-22 Thread Marek Vasut
> On Tue, Nov 22, 2011 at 05:46:41AM +0100, Marek Vasut wrote: > > > On Mon, Nov 21, 2011 at 11:50:17PM +0100, Marek Vasut wrote: > > > > > + printf("CPU: OpenRISC-%x00 (rev %d) @ %d MHz\n", > > > > > + ver, rev, (CONFIG_SYS_CLK_FREQ / 100)); > > > > > > > > The CPU won't tel

Re: [U-Boot] [PATCH 3/9] openrisc: Add cpu files

2011-11-21 Thread Stefan Kristiansson
On Tue, Nov 22, 2011 at 05:46:41AM +0100, Marek Vasut wrote: > > On Mon, Nov 21, 2011 at 11:50:17PM +0100, Marek Vasut wrote: > > > > + printf("CPU: OpenRISC-%x00 (rev %d) @ %d MHz\n", > > > > + ver, rev, (CONFIG_SYS_CLK_FREQ / 100)); > > > > > > The CPU won't tell you it

Re: [U-Boot] [PATCH 3/9] openrisc: Add cpu files

2011-11-21 Thread Marek Vasut
> On Mon, Nov 21, 2011 at 11:50:17PM +0100, Marek Vasut wrote: > > > + return (mfspr(SPR_ICCFGR) & SPR_ICCFGR_CBS) ? 32 : 16; > > > > What's mfspr ... if it's some register, then maybe mfspr_read() ? > > It's an instruction, "move from special register", > so I don't think the _read would be appr

Re: [U-Boot] [PATCH 3/9] openrisc: Add cpu files

2011-11-21 Thread Stefan Kristiansson
On Mon, Nov 21, 2011 at 11:50:17PM +0100, Marek Vasut wrote: > > + return (mfspr(SPR_ICCFGR) & SPR_ICCFGR_CBS) ? 32 : 16; > > What's mfspr ... if it's some register, then maybe mfspr_read() ? > It's an instruction, "move from special register", so I don't think the _read would be appropriate i

Re: [U-Boot] [PATCH 3/9] openrisc: Add cpu files

2011-11-21 Thread Marek Vasut
> Signed-off-by: Stefan Kristiansson > --- > arch/openrisc/config.mk| 27 > arch/openrisc/cpu/Makefile | 47 ++ > arch/openrisc/cpu/cache.c | 157 +++ > arch/openrisc/cpu/cpu.c| 157 +++ > arch/openrisc/cpu/exceptions.c | 10

Re: [U-Boot] [PATCH 3/9] openrisc: Add cpu files

2011-11-19 Thread Mike Frysinger
On Saturday 19 November 2011 23:27:34 Stefan Kristiansson wrote: > On Sat, Nov 19, 2011 at 12:59:05AM -0500, Mike Frysinger wrote: > > On Saturday 19 November 2011 00:21:32 Stefan Kristiansson wrote: > > > --- /dev/null > > > +++ b/arch/openrisc/cpu/cache.c > > > > > > +int checkicache(void) > > >

Re: [U-Boot] [PATCH 3/9] openrisc: Add cpu files

2011-11-19 Thread Stefan Kristiansson
On Sat, Nov 19, 2011 at 12:59:05AM -0500, Mike Frysinger wrote: > On Saturday 19 November 2011 00:21:32 Stefan Kristiansson wrote: > > --- /dev/null > > +++ b/arch/openrisc/cpu/cache.c > > > > +int checkicache(void) > > +int checkdcache(void) > > these should be static > > > --- /dev/null > > +++

Re: [U-Boot] [PATCH 3/9] openrisc: Add cpu files

2011-11-18 Thread Mike Frysinger
On Saturday 19 November 2011 00:21:32 Stefan Kristiansson wrote: > --- /dev/null > +++ b/arch/openrisc/config.mk > > \ No newline at end of file might want to fix that > --- /dev/null > +++ b/arch/openrisc/cpu/cache.c > > +int checkicache(void) > +int checkdcache(void) these should be static >

[U-Boot] [PATCH 3/9] openrisc: Add cpu files

2011-11-18 Thread Stefan Kristiansson
Signed-off-by: Stefan Kristiansson --- arch/openrisc/config.mk| 27 arch/openrisc/cpu/Makefile | 47 ++ arch/openrisc/cpu/cache.c | 157 +++ arch/openrisc/cpu/cpu.c| 157 +++ arch/openrisc/cpu/exceptions.c | 109