Re: [U-Boot] [PATCH 3/8] sbc8548: enable access to second bank of flash

2009-09-23 Thread Paul Gortmaker
[Re: [U-Boot] [PATCH 3/8] sbc8548: enable access to second bank of flash] On 23/09/2009 (Wed 22:48) Wolfgang Denk wrote: > Dear Paul Gortmaker, > > In message <4aba81da.8020...@windriver.com> you wrote: > > > > I'd considered the line length, but there were m

Re: [U-Boot] [PATCH 3/8] sbc8548: enable access to second bank of flash

2009-09-23 Thread Wolfgang Denk
Dear Paul Gortmaker, In message <4aba81da.8020...@windriver.com> you wrote: > > I'd considered the line length, but there were many lines in tlb.c > that were already way past 80 char (see directly under the > comment/* TLB 0 - for temp stack in cache */ ) so I > decided to be consistent wit

Re: [U-Boot] [PATCH 3/8] sbc8548: enable access to second bank of flash

2009-09-23 Thread Paul Gortmaker
Wolfgang Denk wrote: > Dear Kumar Gala, > > In message <47177dab-3638-4978-bd72-78629adcd...@kernel.crashing.org> you > wrote: >> On Sep 18, 2009, at 6:08 PM, Paul Gortmaker wrote: > ... >> applied to 85xx. > > Argh... So how much time do you allow for code reviews? > > I ask you to wait at lea

Re: [U-Boot] [PATCH 3/8] sbc8548: enable access to second bank of flash

2009-09-23 Thread Wolfgang Denk
Dear Kumar Gala, In message <47177dab-3638-4978-bd72-78629adcd...@kernel.crashing.org> you wrote: > > On Sep 18, 2009, at 6:08 PM, Paul Gortmaker wrote: ... > applied to 85xx. Argh... So how much time do you allow for code reviews? I ask you to wait at least 3...5 working days, please. Please

Re: [U-Boot] [PATCH 3/8] sbc8548: enable access to second bank of flash

2009-09-23 Thread Wolfgang Denk
Dear Paul Gortmaker, In message <918ca661b391ce156f39e6c8a086ea93d845caea.1253315004.git.paul.gortma...@windriver.com> you wrote: > The sbc8548 has a 64MB SODIMM flash module off of CS6 that > previously wasn't enumerated by u-boot. There were already > BR6/OR6 settings for it [used by cpu_init

Re: [U-Boot] [PATCH 3/8] sbc8548: enable access to second bank of flash

2009-09-19 Thread Kumar Gala
On Sep 18, 2009, at 6:08 PM, Paul Gortmaker wrote: > The sbc8548 has a 64MB SODIMM flash module off of CS6 that > previously wasn't enumerated by u-boot. There were already > BR6/OR6 settings for it [used by cpu_init_f()] but there > was no TLB entry and it wasn't in the list of flash banks > re

[U-Boot] [PATCH 3/8] sbc8548: enable access to second bank of flash

2009-09-18 Thread Paul Gortmaker
The sbc8548 has a 64MB SODIMM flash module off of CS6 that previously wasn't enumerated by u-boot. There were already BR6/OR6 settings for it [used by cpu_init_f()] but there was no TLB entry and it wasn't in the list of flash banks reported to u-boot. The location of the 64MB flash is "pulled ba