Re: [U-Boot] [PATCH 2/5] MX28: DMA: Prolong the DMA timeout

2012-08-22 Thread Marek Vasut
Dear Fabio Estevam, > On Wed, Aug 22, 2012 at 2:42 PM, Marek Vasut wrote: > > Dear Fabio Estevam, > > > >> On Tue, Aug 21, 2012 at 11:17 PM, Marek Vasut wrote: > >> > int mxs_dma_go(int chan) > >> > { > >> > > >> > - uint32_t timeout = 1; > >> > + uint32_t timeout = 1000;

Re: [U-Boot] [PATCH 2/5] MX28: DMA: Prolong the DMA timeout

2012-08-22 Thread Fabio Estevam
On Wed, Aug 22, 2012 at 2:42 PM, Marek Vasut wrote: > Dear Fabio Estevam, > >> On Tue, Aug 21, 2012 at 11:17 PM, Marek Vasut wrote: >> > int mxs_dma_go(int chan) >> > { >> > >> > - uint32_t timeout = 1; >> > + uint32_t timeout = 1000; >> >> Should we use a proper timeout mec

Re: [U-Boot] [PATCH 2/5] MX28: DMA: Prolong the DMA timeout

2012-08-22 Thread Marek Vasut
Dear Fabio Estevam, > On Tue, Aug 21, 2012 at 11:17 PM, Marek Vasut wrote: > > int mxs_dma_go(int chan) > > { > > > > - uint32_t timeout = 1; > > + uint32_t timeout = 1000; > > Should we use a proper timeout mechanism instead? What would that be? I think 10 seconds is mor

Re: [U-Boot] [PATCH 2/5] MX28: DMA: Prolong the DMA timeout

2012-08-22 Thread Fabio Estevam
On Tue, Aug 21, 2012 at 11:17 PM, Marek Vasut wrote: > int mxs_dma_go(int chan) > { > - uint32_t timeout = 1; > + uint32_t timeout = 1000; Should we use a proper timeout mechanism instead? Reagards, Fabio Estevam ___ U-Boot mail

[U-Boot] [PATCH 2/5] MX28: DMA: Prolong the DMA timeout

2012-08-21 Thread Marek Vasut
Load from SPI flash can create a long DMA chain, which can take long time to transfer. Change the DMA timeout to roughly 10s to prevent such long chains misreporting errors. Signed-off-by: Marek Vasut Cc: Fabio Estevam Cc: Otavio Salvador Cc: Stefano Babic --- drivers/dma/apbh_dma.c |2 +-