Re: [U-Boot] [PATCH 2/2] libavb: Fix build warnings after updating the lib

On Thu, Aug 15, 2019 at 11:04:03PM +0300, Sam Protsenko wrote: > After updating libavb to most recent version from AOSP/master, two new > warnings appear: > > Warning #1: > > lib/libavb/avb_cmdline.c: In function 'avb_append_options': > lib/libavb/avb_cmdline.c:365:15: warning: 'dm_verit

Re: [U-Boot] [PATCH 2/2] libavb: Fix build warnings after updating the lib

Hi, Just to re: > taking into account the amount of time needed (sometimes it can take months, or even years, Sam has good stories about that) to get something applied to AOSP This probably needs to be discussed case by case, as there are ~750 project

Re: [U-Boot] [PATCH 2/2] libavb: Fix build warnings after updating the lib

On Mon, Aug 19, 2019 at 10:28:41AM +0200, Eugeniu Rosca wrote: > Hi all, > > On Fri, Aug 16, 2019 at 11:46:03AM -0400, David Zeuthen wrote: > >Hi, > >As for upstreaming libavb patches, I'd be interested in landing them > >upstream... makes it easier for anyone. > >Our upstream is A

Re: [U-Boot] [PATCH 2/2] libavb: Fix build warnings after updating the lib

On Mon, Aug 19, 2019 at 12:40 PM Igor Opaniuk wrote: > > Hi Eugeniu, > > On Mon, Aug 19, 2019 at 11:28 AM Eugeniu Rosca wrote: > > > > Hi all, > > > > On Fri, Aug 16, 2019 at 11:46:03AM -0400, David Zeuthen wrote: > > >Hi, > > >As for upstreaming libavb patches, I'd be interested in landi

Re: [U-Boot] [PATCH 2/2] libavb: Fix build warnings after updating the lib

Hi Eugeniu, On Mon, Aug 19, 2019 at 11:28 AM Eugeniu Rosca wrote: > > Hi all, > > On Fri, Aug 16, 2019 at 11:46:03AM -0400, David Zeuthen wrote: > >Hi, > >As for upstreaming libavb patches, I'd be interested in landing them > >upstream... makes it easier for anyone. > >Our upstrea

Re: [U-Boot] [PATCH 2/2] libavb: Fix build warnings after updating the lib

Hi all, On Fri, Aug 16, 2019 at 11:46:03AM -0400, David Zeuthen wrote: >Hi, >As for upstreaming libavb patches, I'd be interested in landing them >upstream... makes it easier for anyone. >Our upstream is AOSP and we use gerrit for >code-review: > https://android-review.googles

Re: [U-Boot] [PATCH 2/2] libavb: Fix build warnings after updating the lib

Hi, As for upstreaming libavb patches, I'd be interested in landing them upstream... makes it easier for anyone. Our upstream is AOSP and we use gerrit for code-review: https://android-review.googlesource.com/q/project:platform%252Fexternal%252Favb Here's a guide to contributing: https://source.

Re: [U-Boot] [PATCH 2/2] libavb: Fix build warnings after updating the lib

Hi Sam, CC: LIBAVB people (w.r.t. libavb fixes in U-Boot) I can reproduce the compiler warnings myself and I confirm they are fixed with this patch. More comments below. On Thu, Aug 15, 2019 at 11:04:03PM +0300, Sam Protsenko wrote: > After updating libavb to most recent version from AOSP/master

[U-Boot] [PATCH 2/2] libavb: Fix build warnings after updating the lib

After updating libavb to most recent version from AOSP/master, two new warnings appear: Warning #1: lib/libavb/avb_cmdline.c: In function 'avb_append_options': lib/libavb/avb_cmdline.c:365:15: warning: 'dm_verity_mode' may be used uninitialized in this