Hi Eugeniu, On Mon, Aug 19, 2019 at 11:28 AM Eugeniu Rosca <ero...@de.adit-jv.com> wrote: > > Hi all, > > On Fri, Aug 16, 2019 at 11:46:03AM -0400, David Zeuthen wrote: > > Hi, > > As for upstreaming libavb patches, I'd be interested in landing them > > upstream... makes it easier for anyone. > > Our upstream is AOSP and we use gerrit for > > code-review: > > https://android-review.googlesource.com/q/project:platform%252Fexternal%252Favb > > Here's a guide to > > contributing: https://source.android.com/setup/contribute/submit-patches > > ... > > hope it's not too painful to use the AOSP process! > > Thanks, > > David > > David, thanks for being open about discussing/accepting the fixes. > > U-Boot folks, > > What's your opinion w.r.t. the right/best order between accepting > the libavb fixes locally in U-Boot and pushing them to upstream? > Which should come first? I suppose they can be first applied internally > and replaced later on if they get reworked/optimized during upstreaming. > > -- > Best Regards, > Eugeniu.
IMHO, the best approach here is to upstream fixes to AOSP libavb first, only then port stuff to U-boot. Nevertheless, taking into account the amount of time needed (sometimes it can take months, or even years, Sam has good stories about that) to get something applied to AOSP, I would suggest to proceed internally with commits like this ASAP, but somehow (extended commit message for each "libavb sync" patch with the list of patches out of AOSP tree; or introduce "doc/android/libavb-porting.txt", where we can provide all details about list of commits from AOSP + out-of-tree commits, how-to do porting etc; other ideas?) keep track of changes that are not up-streamed to AOSP yet. Ideally we have to achieve 1:1 mapping (with the only difference - SPDX tags), of [1] in lib/libavb/, otherwise we will fight with constant code divergence (obviously). [1] https://android.googlesource.com/platform/external/avb/+/<revision>/libavb -- Best regards - Freundliche Grüsse - Meilleures salutations Igor Opaniuk mailto: igor.opan...@gmail.com skype: igor.opanyuk +380 (93) 836 40 67 http://ua.linkedin.com/in/iopaniuk _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
