Re: [U-Boot] [PATCH 2/2] Added serial loopback tests accessible via CLI and POST

2010-03-31 Thread Michael Zaidman
Dear Wolfgang, On Wed, Mar 31, 2010 at 12:27 AM, Wolfgang Denk wrote: > > I think this is a consequence of trying to squeeze soemthing into a > framework which doesn't fit.  POST and production test code should be > kept separate. If they share common code, fine. > > Best regards, > > Wolfgang De

Re: [U-Boot] [PATCH 2/2] Added serial loopback tests accessible via CLI and POST

2010-03-30 Thread Wolfgang Denk
Dear Michael Zaidman, In message <660c0f821003230641s5716a04cn2b15becf7c457...@mail.gmail.com> you wrote: > > > Then what is the "uart[t]est" command needed for? > > For two reasons: > 1) It gets parameters such internal/external loopback and COM number > while "diag run uart" performs only loc

Re: [U-Boot] [PATCH 2/2] Added serial loopback tests accessible via CLI and POST

2010-03-23 Thread Michael Zaidman
Dear Wolfgang, On Tue, Mar 23, 2010 at 1:31 PM, Wolfgang Denk wrote: [snip] > Then what is the "uart[t]est" command needed for? For two reasons: 1) It gets parameters such internal/external loopback and COM number while "diag run uart" performs only local loopback through all COMs. Thus, it ca

Re: [U-Boot] [PATCH 2/2] Added serial loopback tests accessible via CLI and POST

2010-03-23 Thread Wolfgang Denk
Dear Michael Zaidman, In message <660c0f821003230315i54c79d5au12377695cb85a...@mail.gmail.com> you wrote: > > Sorry, I meant that this patch is based on the "Serial support > extended up to 6 COMs" patch (See > http://lists.denx.de/pipermail/u-boot/2010-March/068796.html). > > BTW, If one patch

Re: [U-Boot] [PATCH 2/2] Added serial loopback tests accessible via CLI and POST

2010-03-23 Thread Michael Zaidman
On Mon, Mar 22, 2010 at 10:14 PM, Wolfgang Denk wrote: > Dear Michael Zaidman, > > In message <1269267894-15324-1-git-send-email-michael.zaid...@gmail.com> you > wrote: >> Serial loopback internal/external tests. Is based on my previous commit >> 078a9c4898e7802086b362baa44ad48b8ad1baed > > This

Re: [U-Boot] [PATCH 2/2] Added serial loopback tests accessible via CLI and POST

2010-03-22 Thread Wolfgang Denk
Dear Michael Zaidman, In message <1269267894-15324-1-git-send-email-michael.zaid...@gmail.com> you wrote: > Serial loopback internal/external tests. Is based on my previous commit > 078a9c4898e7802086b362baa44ad48b8ad1baed This information is useless - no such commit ID is available in mainline:

[U-Boot] [PATCH 2/2] Added serial loopback tests accessible via CLI and POST

2010-03-22 Thread Michael Zaidman
Serial loopback internal/external tests. Is based on my previous commit 078a9c4898e7802086b362baa44ad48b8ad1baed Signed-off-by: Michael Zaidman --- drivers/serial/serial.c | 87 +++ post/drivers/Makefile |2 +- post/drivers/serial.c | 56 ++