Re: [U-Boot] [PATCH 13/60] ARM: tegra: sort some board file include directives

2016-04-26 Thread Tom Rini
On Tue, Apr 26, 2016 at 02:44:24PM -0600, Stephen Warren wrote: > On 04/26/2016 12:15 PM, Tom Rini wrote: > >On Tue, Apr 26, 2016 at 10:18:06AM -0600, Stephen Warren wrote: > >>On 04/25/2016 05:22 PM, Tom Rini wrote: > >>... > >>>I know company lawyers come up with various policies and some are mor

Re: [U-Boot] [PATCH 13/60] ARM: tegra: sort some board file include directives

2016-04-26 Thread Stephen Warren
On 04/26/2016 12:15 PM, Tom Rini wrote: On Tue, Apr 26, 2016 at 10:18:06AM -0600, Stephen Warren wrote: On 04/25/2016 05:22 PM, Tom Rini wrote: ... I know company lawyers come up with various policies and some are more restrictive than others. Anything about the exact guidelines you can share

Re: [U-Boot] [PATCH 13/60] ARM: tegra: sort some board file include directives

2016-04-26 Thread Wolfgang Denk
In message <20160426181301.92f78100...@atlas.denx.de> I wrote: > Dear Stephen, > > In message <571f94be.2030...@wwwdotorg.org> you wrote: > > > > Guidance on "non-trivial" isn't given. I would take it to mean anything > > other than typos and whitespace fixes. > > recommended search term: Copyri

Re: [U-Boot] [PATCH 13/60] ARM: tegra: sort some board file include directives

2016-04-26 Thread Tom Rini
On Tue, Apr 26, 2016 at 10:18:06AM -0600, Stephen Warren wrote: > On 04/25/2016 05:22 PM, Tom Rini wrote: > ... > >I know company lawyers come up with various policies and some are more > >restrictive than others. Anything about the exact guidelines you can > >share would be appreciated. > > They

Re: [U-Boot] [PATCH 13/60] ARM: tegra: sort some board file include directives

2016-04-26 Thread Tom Rini
On Tue, Apr 26, 2016 at 10:23:36AM -0600, Stephen Warren wrote: > On 04/25/2016 05:22 PM, Tom Rini wrote: > > >Lawyers can argue, but projects have guidelines. I mean heck, I've see > >you remind people to fix the include order in new patches. Do they need > >to add an NVIDIA copyright notice to

Re: [U-Boot] [PATCH 13/60] ARM: tegra: sort some board file include directives

2016-04-26 Thread Wolfgang Denk
Dear Stephen, In message <571f94be.2030...@wwwdotorg.org> you wrote: > > Guidance on "non-trivial" isn't given. I would take it to mean anything > other than typos and whitespace fixes. recommended search term: Copyright Creativity Requirement Best regards, Wolfgang Denk -- DENX Software Eng

Re: [U-Boot] [PATCH 13/60] ARM: tegra: sort some board file include directives

2016-04-26 Thread Stephen Warren
On 04/25/2016 05:22 PM, Tom Rini wrote: Lawyers can argue, but projects have guidelines. I mean heck, I've see you remind people to fix the include order in new patches. Do they need to add an NVIDIA copyright notice too? No, of course not. Well honestly all patch review does contribute to

Re: [U-Boot] [PATCH 13/60] ARM: tegra: sort some board file include directives

2016-04-26 Thread Stephen Warren
On 04/25/2016 05:22 PM, Tom Rini wrote: ... I know company lawyers come up with various policies and some are more restrictive than others. Anything about the exact guidelines you can share would be appreciated. They're simple and I would assume quite standard: 1) When creating a new file, ad

Re: [U-Boot] [PATCH 13/60] ARM: tegra: sort some board file include directives

2016-04-25 Thread Tom Rini
On Mon, Apr 25, 2016 at 11:59:39PM +0200, Wolfgang Denk wrote: > Dear Stephen, > > In message <571e75e2.6020...@wwwdotorg.org> you wrote: > > > > >> /* > > >>* (C) Copyright 2013 > > >>* Avionic Design GmbH > > >> + * Copyright (c) 2016, NVIDIA CORPORATION. All rights reserved. > > >>

Re: [U-Boot] [PATCH 13/60] ARM: tegra: sort some board file include directives

2016-04-25 Thread Wolfgang Denk
Dear Stephen, In message <571e75e2.6020...@wwwdotorg.org> you wrote: > > >> /* > >>* (C) Copyright 2013 > >>* Avionic Design GmbH > >> + * Copyright (c) 2016, NVIDIA CORPORATION. All rights reserved. > >>* > >>* SPDX-License-Identifier: GPL-2.0+ > >>*/ > >> > >> #incl

Re: [U-Boot] [PATCH 13/60] ARM: tegra: sort some board file include directives

2016-04-25 Thread Stephen Warren
On 04/24/2016 04:20 AM, Wolfgang Denk wrote: Dear Stephen, In message <1461099580-3866-14-git-send-email-swar...@wwwdotorg.org> you wrote: --- a/board/avionic-design/common/tamonten-ng.c +++ b/board/avionic-design/common/tamonten-ng.c @@ -1,18 +1,19 @@ /* * (C) Copyright 2013 * Avionic

Re: [U-Boot] [PATCH 13/60] ARM: tegra: sort some board file include directives

2016-04-24 Thread Wolfgang Denk
Dear Stephen, In message <1461099580-3866-14-git-send-email-swar...@wwwdotorg.org> you wrote: > > --- a/board/avionic-design/common/tamonten-ng.c > +++ b/board/avionic-design/common/tamonten-ng.c > @@ -1,18 +1,19 @@ > /* > * (C) Copyright 2013 > * Avionic Design GmbH > + * Copyright (c) 201

Re: [U-Boot] [PATCH 13/60] ARM: tegra: sort some board file include directives

2016-04-20 Thread Simon Glass
On 19 April 2016 at 14:58, Stephen Warren wrote: > From: Stephen Warren > > The order is general includes, general asm includes, arch asm includes, > local files. > > Signed-off-by: Stephen Warren > --- > board/avionic-design/common/tamonten-ng.c | 5 +++-- > board/nvidia/cardhu/cardhu.c

[U-Boot] [PATCH 13/60] ARM: tegra: sort some board file include directives

2016-04-19 Thread Stephen Warren
From: Stephen Warren The order is general includes, general asm includes, arch asm includes, local files. Signed-off-by: Stephen Warren --- board/avionic-design/common/tamonten-ng.c | 5 +++-- board/nvidia/cardhu/cardhu.c | 6 +++--- board/nvidia/jetson-tk1/jetson-tk1.c | 4 +