Re: [U-Boot] [PATCH 12/18] GCC4.6: Squash warnings in smsc95xx.c

2011-10-30 Thread Mike Frysinger
On Sunday 30 October 2011 19:45:43 Marek Vasut wrote: > > On Sunday 30 October 2011 16:48:50 Marek Vasut wrote: > > > > On Tuesday 25 October 2011 05:39:58 Marek Vasut wrote: > > > > > --- a/drivers/usb/eth/smsc95xx.c > > > > > +++ b/drivers/usb/eth/smsc95xx.c > > > > > > > > > > - addr_lo = c

Re: [U-Boot] [PATCH 12/18] GCC4.6: Squash warnings in smsc95xx.c

2011-10-30 Thread Marek Vasut
> On Sunday 30 October 2011 16:48:50 Marek Vasut wrote: > > > On Tuesday 25 October 2011 05:39:58 Marek Vasut wrote: > > > > --- a/drivers/usb/eth/smsc95xx.c > > > > +++ b/drivers/usb/eth/smsc95xx.c > > > > > > > > - addr_lo = cpu_to_le32(*((u32 *)eth->enetaddr)); > > > > + addr_lo = c

Re: [U-Boot] [PATCH 12/18] GCC4.6: Squash warnings in smsc95xx.c

2011-10-30 Thread Mike Frysinger
On Sunday 30 October 2011 16:48:50 Marek Vasut wrote: > > On Tuesday 25 October 2011 05:39:58 Marek Vasut wrote: > > > --- a/drivers/usb/eth/smsc95xx.c > > > +++ b/drivers/usb/eth/smsc95xx.c > > > > > > - addr_lo = cpu_to_le32(*((u32 *)eth->enetaddr)); > > > + addr_lo = cpu_to_le32(*eth->enetaddr)

Re: [U-Boot] [PATCH 12/18] GCC4.6: Squash warnings in smsc95xx.c

2011-10-30 Thread Marek Vasut
> Dear Marek Vasut, > > In message <201110302148.50367.marek.va...@gmail.com> you wrote: > > > > - addr_lo = cpu_to_le32(*((u32 *)eth->enetaddr)); > > > > + addr_lo = cpu_to_le32(*eth->enetaddr); > > > > > > pretty sure this is wrong. enetaddr is a uchar[], so your code now > > > rea

Re: [U-Boot] [PATCH 12/18] GCC4.6: Squash warnings in smsc95xx.c

2011-10-30 Thread Wolfgang Denk
Dear Marek Vasut, In message <201110302148.50367.marek.va...@gmail.com> you wrote: > > > > - addr_lo = cpu_to_le32(*((u32 *)eth->enetaddr)); > > > + addr_lo = cpu_to_le32(*eth->enetaddr); > > > > pretty sure this is wrong. enetaddr is a uchar[], so your code now reads > > only 1 byte instead of

Re: [U-Boot] [PATCH 12/18] GCC4.6: Squash warnings in smsc95xx.c

2011-10-30 Thread Marek Vasut
> On Tuesday 25 October 2011 05:39:58 Marek Vasut wrote: > > --- a/drivers/usb/eth/smsc95xx.c > > +++ b/drivers/usb/eth/smsc95xx.c > > > > - addr_lo = cpu_to_le32(*((u32 *)eth->enetaddr)); > > + addr_lo = cpu_to_le32(*eth->enetaddr); > > pretty sure this is wrong. enetaddr is a uchar[], so y

Re: [U-Boot] [PATCH 12/18] GCC4.6: Squash warnings in smsc95xx.c

2011-10-30 Thread Mike Frysinger
On Tuesday 25 October 2011 05:39:58 Marek Vasut wrote: > --- a/drivers/usb/eth/smsc95xx.c > +++ b/drivers/usb/eth/smsc95xx.c > > - addr_lo = cpu_to_le32(*((u32 *)eth->enetaddr)); > + addr_lo = cpu_to_le32(*eth->enetaddr); pretty sure this is wrong. enetaddr is a uchar[], so your code now

Re: [U-Boot] [PATCH 12/18] GCC4.6: Squash warnings in smsc95xx.c

2011-10-27 Thread Wolfgang Denk
Dear Marek Vasut, In message <1319535604-20831-13-git-send-email-marek.va...@gmail.com> you wrote: > smsc95xx.c: In function 'smsc95xx_write_hwaddr': > smsc95xx.c:380:2: warning: dereferencing type-punned pointer will break > strict-aliasing rules > > Signed-off-by: Marek Vasut > Cc: Wolfgang De

[U-Boot] [PATCH 12/18] GCC4.6: Squash warnings in smsc95xx.c

2011-10-25 Thread Marek Vasut
smsc95xx.c: In function 'smsc95xx_write_hwaddr': smsc95xx.c:380:2: warning: dereferencing type-punned pointer will break strict-aliasing rules Signed-off-by: Marek Vasut Cc: Wolfgang Denk Cc: Simon Glass Cc: Mike Frysinger --- drivers/usb/eth/smsc95xx.c |2 +- 1 files changed, 1 insertion