Re: [U-Boot] [PATCH 10/19] x86: Move ECC initialisation outside RAM initialisation

2010-10-04 Thread Graeme Russ
On Mon, Oct 4, 2010 at 9:21 PM, Wolfgang Denk wrote: > Dear Graeme Russ, > > In message <4ca9a70b.6030...@gmail.com> you wrote: >> >> >> +#if CONFIG_SYS_SDRAM_ECC_ENABLE >> >> +/* Skip ECC initialization if not starting from cold-reset */ >> >> +movl%ebx, %ecx >> >> +andl$GD_FL

Re: [U-Boot] [PATCH 10/19] x86: Move ECC initialisation outside RAM initialisation

2010-10-04 Thread Sergei Shtylyov
Hello. On 04-10-2010 7:37, Graeme Russ wrote: > To allow for 'load anywhere' images, the %ebp return pointer 'hack' must > be removed, so we cannot have two 'calls' to get_mem_size > Signed-off-by: Graeme Russ [...] > diff --git a/arch/i386/cpu/start.S b/arch/i386/cpu/start.S > index cb47ce7..9

Re: [U-Boot] [PATCH 10/19] x86: Move ECC initialisation outside RAM initialisation

2010-10-04 Thread Wolfgang Denk
Dear Graeme Russ, In message <4ca9a70b.6030...@gmail.com> you wrote: > > >> +#if CONFIG_SYS_SDRAM_ECC_ENABLE > >> +/* Skip ECC initialization if not starting from cold-reset */ > >> +movl%ebx, %ecx > >> +andl$GD_FLG_COLD_BOOT, %ecx > >> +jzecc_init_ret > > > >But t

Re: [U-Boot] [PATCH 10/19] x86: Move ECC initialisation outside RAM initialisation

2010-10-04 Thread Graeme Russ
On 04/10/10 20:59, Sergei Shtylyov wrote: > Hello. > > On 04-10-2010 7:37, Graeme Russ wrote: > >> To allow for 'load anywhere' images, the %ebp return pointer 'hack' must >> be removed, so we cannot have two 'calls' to get_mem_size > >> Signed-off-by: Graeme Russ > [...] > >> diff --git a/arch

[U-Boot] [PATCH 10/19] x86: Move ECC initialisation outside RAM initialisation

2010-10-03 Thread Graeme Russ
To allow for 'load anywhere' images, the %ebp return pointer 'hack' must be removed, so we cannot have two 'calls' to get_mem_size Signed-off-by: Graeme Russ --- arch/i386/cpu/sc520/sc520_asm.S | 17 +++-- arch/i386/cpu/start.S | 11 +++ 2 files changed, 14 inse