Re: [U-Boot] [PATCH 1/6] omap4: usb: Add omap-ehci support

2011-12-15 Thread Govindraj
Hi Tom, On Wed, Dec 14, 2011 at 9:30 PM, Tom Rini wrote: > On Wed, Dec 14, 2011 at 5:09 AM, Govindraj.R wrote: >> From: "Govindraj.R" > [snip] >> +/* TLL Register Set */ >> +#define        OMAP_USBTLL_SYSCONFIG_SIDLEMODE                 (1 << 3) > > Globally, please fix all #define to #define.

Re: [U-Boot] [PATCH 1/6] omap4: usb: Add omap-ehci support

2011-12-14 Thread Tom Rini
On Wed, Dec 14, 2011 at 5:09 AM, Govindraj.R wrote: > From: "Govindraj.R" [snip] > +/* TLL Register Set */ > +#define        OMAP_USBTLL_SYSCONFIG_SIDLEMODE                 (1 << 3) Globally, please fix all #define to #define. > +#define        OMAP_USBTLL_SYSCONFIG_AUTOIDLE                  (1

Re: [U-Boot] [PATCH 1/6] omap4: usb: Add omap-ehci support

2011-12-14 Thread Govindraj
Hi Chris, On Wed, Dec 14, 2011 at 7:08 PM, Chris Lalancette wrote: > On Wed, Dec 14, 2011 at 7:09 AM, Govindraj.R wrote: >> From: "Govindraj.R" >> >> Adds ehci-omap and two funcs omap_ehci_hcd_init/omap_ehci_hcd_stop >> Which can be called from any board file implementing the ehci_hcd_init/rese

Re: [U-Boot] [PATCH 1/6] omap4: usb: Add omap-ehci support

2011-12-14 Thread Chris Lalancette
On Wed, Dec 14, 2011 at 7:09 AM, Govindraj.R wrote: > From: "Govindraj.R" > > Adds ehci-omap and two funcs omap_ehci_hcd_init/omap_ehci_hcd_stop > Which can be called from any board file implementing the ehci_hcd_init/reset. > One can pass the port modes from board file and configure the usb host

[U-Boot] [PATCH 1/6] omap4: usb: Add omap-ehci support

2011-12-14 Thread Govindraj.R
From: "Govindraj.R" Adds ehci-omap and two funcs omap_ehci_hcd_init/omap_ehci_hcd_stop Which can be called from any board file implementing the ehci_hcd_init/reset. One can pass the port modes from board file and configure the usb host to ulpi-phy mode or hsic mode. Signed-off-by: Govindraj.R -

[U-Boot] [PATCH 1/6] omap4: usb: Add omap-ehci support

2011-12-14 Thread Govindraj.R
From: "Govindraj.R" Adds ehci-omap and two funcs omap_ehci_hcd_init/omap_ehci_hcd_stop Which can be called from any board file implementing the ehci_hcd_init/reset. One can pass the port modes from board file and configure the usb host to ulpi-phy mode or hsic mode. Signed-off-by: Govindraj.R -