Re: [U-Boot] [PATCH 1/5] net: ll_temac: Add LL TEMAC driver to u-boot

2012-01-17 Thread Stephan Linz
Am Sonntag, den 15.01.2012, 13:47 -0500 schrieb Mike Frysinger: > On Sunday 15 January 2012 13:29:26 Stephan Linz wrote: > > Am Sonntag, den 15.01.2012, 12:28 -0500 schrieb Mike Frysinger: > > > On Sunday 15 January 2012 10:46:02 Stephan Linz wrote: > > > > +/* Data buffer for LL TEMAC Rx and Tx d

Re: [U-Boot] [PATCH 1/5] net: ll_temac: Add LL TEMAC driver to u-boot

2012-01-16 Thread Stephan Linz
Am Montag, den 16.01.2012, 09:14 +0100 schrieb Wolfgang Denk: > Dear Stephan Linz, Hi Wolfgang, you are right in all points. I'll go into the next round and handle all new request. br, Stephan > > In message <1326652166.18981.213.camel@keto> you wrote: > > > > > come code already declares Pkt

Re: [U-Boot] [PATCH 1/5] net: ll_temac: Add LL TEMAC driver to u-boot

2012-01-16 Thread Wolfgang Denk
Dear Stephan Linz, In message <1326656467.18981.225.camel@keto> you wrote: > > OK, I'll try to change the buffer handling as soon as possible in one of > the next optimization stages of this driver. Looks interesting and > important to me ... ... > The alignment is essential for the LL TEMAC drive

Re: [U-Boot] [PATCH 1/5] net: ll_temac: Add LL TEMAC driver to u-boot

2012-01-16 Thread Wolfgang Denk
Dear Stephan Linz, In message <1326652166.18981.213.camel@keto> you wrote: > > > come code already declares PktBuf ... can't you use that ? > > Hm, what do you mean exactly here? > > These are the two DMA transfer buffers. I have no idea if there are > buffers in the upper layer (NET) and how I

Re: [U-Boot] [PATCH 1/5] net: ll_temac: Add LL TEMAC driver to u-boot

2012-01-15 Thread Stephan Linz
Am Sonntag, den 15.01.2012, 13:47 -0500 schrieb Mike Frysinger: > On Sunday 15 January 2012 13:29:26 Stephan Linz wrote: > > Am Sonntag, den 15.01.2012, 12:28 -0500 schrieb Mike Frysinger: > > > On Sunday 15 January 2012 10:46:02 Stephan Linz wrote: > > > > +/* Data buffer for LL TEMAC Rx and Tx d

Re: [U-Boot] [PATCH 1/5] net: ll_temac: Add LL TEMAC driver to u-boot

2012-01-15 Thread Mike Frysinger
On Sunday 15 January 2012 13:29:26 Stephan Linz wrote: > Am Sonntag, den 15.01.2012, 12:28 -0500 schrieb Mike Frysinger: > > On Sunday 15 January 2012 10:46:02 Stephan Linz wrote: > > > +/* Data buffer for LL TEMAC Rx and Tx direction */ > > > +static unsigned char rx_buffer[PKTSIZE_ALIGN] > > > __

Re: [U-Boot] [PATCH 1/5] net: ll_temac: Add LL TEMAC driver to u-boot

2012-01-15 Thread Stephan Linz
Am Sonntag, den 15.01.2012, 12:28 -0500 schrieb Mike Frysinger: > On Sunday 15 January 2012 10:46:02 Stephan Linz wrote: > > +/* Data buffer for LL TEMAC Rx and Tx direction */ > > +static unsigned char rx_buffer[PKTSIZE_ALIGN] > > __attribute((aligned(DMAALIGN))); > > +static unsigned char tx_buf

Re: [U-Boot] [PATCH 1/5] net: ll_temac: Add LL TEMAC driver to u-boot

2012-01-15 Thread Mike Frysinger
On Sunday 15 January 2012 10:46:02 Stephan Linz wrote: > +/* Data buffer for LL TEMAC Rx and Tx direction */ > +static unsigned char rx_buffer[PKTSIZE_ALIGN] > __attribute((aligned(DMAALIGN))); > +static unsigned char tx_buffer[PKTSIZE_ALIGN] > __attribute((aligned(DMAALIGN))); come code already d