On Sunday 15 January 2012 10:46:02 Stephan Linz wrote: > +/* Data buffer for LL TEMAC Rx and Tx direction */ > +static unsigned char rx_buffer[PKTSIZE_ALIGN] > __attribute((aligned(DMAALIGN))); > +static unsigned char tx_buffer[PKTSIZE_ALIGN] > __attribute((aligned(DMAALIGN)));
come code already declares PktBuf ... can't you use that ?
> +static struct ll_temac_info ll_temac_info[] = {
this looks like a struct that should get allocated on the fly based on
arguments given to the driver's registration func
> +int xilinx_ll_temac_initialize(bd_t *bis, struct ll_temac_info *devinf)
> ...
> + dev = calloc(1, sizeof(*dev));
> ...
> + /* Tell u-boot to get the addr from the env */
> + for (i = 0; i < 6; i++)
> + dev->enetaddr[i] = 0;
the memory is already zero-ed by the call to calloc, so this for loop is
useless (and if it wasn't, you'd still use memset())
-mike
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
