Re: [U-Boot] [PATCH 1/3] Add nitrogen6x board

2012-10-08 Thread Troy Kisky
On 10/8/2012 2:03 PM, Stefano Babic wrote: On 08/10/2012 22:30, Troy Kisky wrote: On 10/8/2012 9:05 AM, Eric Nelson wrote: Hi Stefano, On 10/08/2012 05:28 AM, Stefano Babic wrote: + +/* Command definition */ +#include Move CONFIG_CMD_BMODE and CONFIG_CMD_SETEXPR here. That makes perfect se

Re: [U-Boot] [PATCH 1/3] Add nitrogen6x board

2012-10-08 Thread Stefano Babic
On 08/10/2012 22:30, Troy Kisky wrote: > On 10/8/2012 9:05 AM, Eric Nelson wrote: >> Hi Stefano, >> >> On 10/08/2012 05:28 AM, Stefano Babic wrote: + +/* Command definition */ +#include >>> >>> Move CONFIG_CMD_BMODE and CONFIG_CMD_SETEXPR here. >>> >> >> That makes perfect sense. >> > Mov

Re: [U-Boot] [PATCH 1/3] Add nitrogen6x board

2012-10-08 Thread Troy Kisky
On 10/8/2012 9:05 AM, Eric Nelson wrote: Hi Stefano, On 10/08/2012 05:28 AM, Stefano Babic wrote: + +/* Command definition */ +#include Move CONFIG_CMD_BMODE and CONFIG_CMD_SETEXPR here. That makes perfect sense. Moving CONFIG_CMD_BMODE may break MX51 boards. Only mx6 and mx53 define boo

Re: [U-Boot] [PATCH 1/3] Add nitrogen6x board

2012-10-08 Thread Eric Nelson
Hi Stefano, On 10/08/2012 05:54 AM, Stefano Babic wrote: On 05/10/2012 22:03, Eric Nelson wrote: On 10/05/2012 12:00 PM, Tom Rini wrote: On Fri, Oct 05, 2012 at 11:42:19AM -0700, Eric Nelson wrote: On 10/05/2012 10:24 AM, Albert ARIBAUD wrote: Hi Eric, On Thu, 4 Oct 2012 12:49:07 -0700, Er

Re: [U-Boot] [PATCH 1/3] Add nitrogen6x board

2012-10-08 Thread Eric Nelson
Hi Stefano, On 10/08/2012 05:28 AM, Stefano Babic wrote: On 04/10/2012 21:49, Eric Nelson wrote: Signed-off-by: Eric Nelson --- Hi Eric, diff --git a/board/boundary/nitrogen6x/README b/board/boundary/nitrogen6x/README new file mode 100644 index 000..d67cdf0 --- /dev/null +++ b/board/bo

Re: [U-Boot] [PATCH 1/3] Add nitrogen6x board

2012-10-08 Thread Stefano Babic
On 05/10/2012 22:03, Eric Nelson wrote: > On 10/05/2012 12:00 PM, Tom Rini wrote: >> On Fri, Oct 05, 2012 at 11:42:19AM -0700, Eric Nelson wrote: >>> On 10/05/2012 10:24 AM, Albert ARIBAUD wrote: Hi Eric, On Thu, 4 Oct 2012 12:49:07 -0700, Eric Nelson wrote: > Signe

Re: [U-Boot] [PATCH 1/3] Add nitrogen6x board

2012-10-08 Thread Stefano Babic
On 04/10/2012 21:49, Eric Nelson wrote: > Signed-off-by: Eric Nelson > --- Hi Eric, > diff --git a/board/boundary/nitrogen6x/README > b/board/boundary/nitrogen6x/README > new file mode 100644 > index 000..d67cdf0 > --- /dev/null > +++ b/board/boundary/nitrogen6x/README > @@ -0,0 +1,77 @@ >

Re: [U-Boot] [PATCH 1/3] Add nitrogen6x board

2012-10-05 Thread Eric Nelson
On 10/05/2012 12:29 PM, Albert ARIBAUD wrote: Hi Eric, On Fri, 05 Oct 2012 11:42:19 -0700, Eric Nelson wrote: On 10/05/2012 10:24 AM, Albert ARIBAUD wrote: Hi Eric, On Thu, 4 Oct 2012 12:49:07 -0700, Eric Nelson wrote: Signed-off-by: Eric Nelson --- board/boundary/nitrogen6x/Makef

Re: [U-Boot] [PATCH 1/3] Add nitrogen6x board

2012-10-05 Thread Tom Rini
On Fri, Oct 05, 2012 at 01:03:10PM -0700, Eric Nelson wrote: > On 10/05/2012 12:00 PM, Tom Rini wrote: [snip] > >And we can't deal with this by factoring the code differently? > > > Hi Tom, > > There are two bits to this question: > - Can we represent the policy differences outside of a >

Re: [U-Boot] [PATCH 1/3] Add nitrogen6x board

2012-10-05 Thread Eric Nelson
On 10/05/2012 12:00 PM, Tom Rini wrote: On Fri, Oct 05, 2012 at 11:42:19AM -0700, Eric Nelson wrote: On 10/05/2012 10:24 AM, Albert ARIBAUD wrote: Hi Eric, On Thu, 4 Oct 2012 12:49:07 -0700, Eric Nelson wrote: Signed-off-by: Eric Nelson --- board/boundary/nitrogen6x/Makefile | 41

Re: [U-Boot] [PATCH 1/3] Add nitrogen6x board

2012-10-05 Thread Albert ARIBAUD
Hi Eric, On Fri, 05 Oct 2012 11:42:19 -0700, Eric Nelson wrote: > On 10/05/2012 10:24 AM, Albert ARIBAUD wrote: > > Hi Eric, > > > > On Thu, 4 Oct 2012 12:49:07 -0700, Eric Nelson > > wrote: > > > >> Signed-off-by: Eric Nelson > >> --- > >> board/boundary/nitrogen6x/Makefile | 41 ++ >

Re: [U-Boot] [PATCH 1/3] Add nitrogen6x board

2012-10-05 Thread Tom Rini
On Fri, Oct 05, 2012 at 11:42:19AM -0700, Eric Nelson wrote: > On 10/05/2012 10:24 AM, Albert ARIBAUD wrote: > >Hi Eric, > > > >On Thu, 4 Oct 2012 12:49:07 -0700, Eric Nelson > > wrote: > > > >>Signed-off-by: Eric Nelson > >>--- > >> board/boundary/nitrogen6x/Makefile | 41 ++ > >> board/b

Re: [U-Boot] [PATCH 1/3] Add nitrogen6x board

2012-10-05 Thread Eric Nelson
On 10/05/2012 10:24 AM, Albert ARIBAUD wrote: Hi Eric, On Thu, 4 Oct 2012 12:49:07 -0700, Eric Nelson wrote: Signed-off-by: Eric Nelson --- board/boundary/nitrogen6x/Makefile | 41 ++ board/boundary/nitrogen6x/README | 77 +++ board/boundary/nitrogen6x/nitrogen6x.c | 840

Re: [U-Boot] [PATCH 1/3] Add nitrogen6x board

2012-10-05 Thread Albert ARIBAUD
Hi Eric, On Thu, 4 Oct 2012 12:49:07 -0700, Eric Nelson wrote: > Signed-off-by: Eric Nelson > --- > board/boundary/nitrogen6x/Makefile | 41 ++ > board/boundary/nitrogen6x/README | 77 +++ > board/boundary/nitrogen6x/nitrogen6x.c | 840 > > boa

Re: [U-Boot] [PATCH 1/3] Add nitrogen6x board

2012-10-04 Thread Sinan Akman
On 10/04/2012 03:49 PM, Eric Nelson wrote: [..] + +static void setup_iomux_enet(void) +{ + gpio_direction_output(IMX_GPIO_NR(3, 23), 0); + gpio_direction_output(IMX_GPIO_NR(6, 30), 1); + gpio_direction_output(IMX_GPIO_NR(6, 25), 1); + gpio_direction_output(IMX_GPIO_NR(6, 2

Re: [U-Boot] [PATCH 1/3] Add nitrogen6x board

2012-10-04 Thread Fabio Estevam
On Thu, Oct 4, 2012 at 4:49 PM, Eric Nelson wrote: > Signed-off-by: Eric Nelson > --- > board/boundary/nitrogen6x/Makefile | 41 ++ > board/boundary/nitrogen6x/README | 77 +++ > board/boundary/nitrogen6x/nitrogen6x.c | 840 > > boards.cfg

Re: [U-Boot] [PATCH 1/3] Add nitrogen6x board

2012-10-04 Thread Sinan Akman
On 10/04/2012 05:42 PM, Sinan Akman wrote: On 10/04/2012 03:49 PM, Eric Nelson wrote: [..] +gpio_direction_output(IMX_GPIO_NR(6, 24), 1); + +/* Need delay 10ms according to KSZ9021 spec */ +udelay(1000 * 10); +gpio_set_value(IMX_GPIO_NR(3, 23), 1); Don't you need a g

[U-Boot] [PATCH 1/3] Add nitrogen6x board

2012-10-04 Thread Eric Nelson
Signed-off-by: Eric Nelson --- board/boundary/nitrogen6x/Makefile | 41 ++ board/boundary/nitrogen6x/README | 77 +++ board/boundary/nitrogen6x/nitrogen6x.c | 840 boards.cfg |1 + include/configs/nitrogen6x.h