Re: [U-Boot] [PATCH 1/2] mx31: make HSP clock for mx3fb driver available

2011-09-05 Thread Marek Vasut
On Monday, September 05, 2011 01:47:06 PM Helmut Raiger wrote: > This additionally updates mx31/generic.c by > - replacing __REG() macro accesses with readl() and writel() > - providing macros for PDR0 and PLL bit accesses > It also fixes a warning about the prototype of imx_get_uartclk(void) > >

[U-Boot] [PATCH 1/2] mx31: make HSP clock for mx3fb driver available

2011-09-05 Thread Helmut Raiger
This additionally updates mx31/generic.c by - replacing __REG() macro accesses with readl() and writel() - providing macros for PDR0 and PLL bit accesses It also fixes a warning about the prototype of imx_get_uartclk(void) Signed-off-by: Helmut Raiger --- V2: uses macros and readl(), writel(), se

Re: [U-Boot] [PATCH 1/2] mx31: make HSP clock for mx3fb driver available

2011-08-24 Thread Marek Vasut
On Wednesday, August 24, 2011 08:55:03 AM Helmut Raiger wrote: > On 08/22/2011 06:02 PM, Marek Vasut wrote: > > ... _COSMETIC_, while this new mx3fb driver really works nicely ;-) > > Oh my sense for metrosexuality of code really kicks in here ;-) > > Arousal was not my first objective, but delibe

Re: [U-Boot] [PATCH 1/2] mx31: make HSP clock for mx3fb driver available

2011-08-23 Thread Helmut Raiger
On 08/22/2011 06:02 PM, Marek Vasut wrote: > ... _COSMETIC_, while this new mx3fb driver really works nicely ;-) > Oh my sense for metrosexuality of code really kicks in here ;-) Arousal was not my first objective, but deliberately endorsed :-P I'll do what can be done easily concerning the bit ac

Re: [U-Boot] [PATCH 1/2] mx31: make HSP clock for mx3fb driver available

2011-08-22 Thread Marek Vasut
On Monday, August 22, 2011 06:02:10 PM Marek Vasut wrote: > On Monday, August 22, 2011 05:51:05 PM Helmut Raiger wrote: > > On 08/22/2011 05:02 PM, Marek Vasut wrote: > > >> Masks are not defined for i.MX31 (imx-regs.h), so I simply followed > > >> the code, which was in the file. The generic.c fil

Re: [U-Boot] [PATCH 1/2] mx31: make HSP clock for mx3fb driver available

2011-08-22 Thread Stefano Babic
On 08/22/2011 05:51 PM, Helmut Raiger wrote: > On 08/22/2011 05:02 PM, Marek Vasut wrote: >> >>> Masks are not defined for i.MX31 (imx-regs.h), so I simply followed the >>> code, which was in the file. The generic.c file for MX35 however is a >>> different story. >>> >>> To keep things simple, I su

Re: [U-Boot] [PATCH 1/2] mx31: make HSP clock for mx3fb driver available

2011-08-22 Thread Marek Vasut
On Monday, August 22, 2011 05:51:05 PM Helmut Raiger wrote: > On 08/22/2011 05:02 PM, Marek Vasut wrote: > >> Masks are not defined for i.MX31 (imx-regs.h), so I simply followed the > >> code, which was in the file. The generic.c file for MX35 however is a > >> different story. > >> > >> To keep t

Re: [U-Boot] [PATCH 1/2] mx31: make HSP clock for mx3fb driver available

2011-08-22 Thread Helmut Raiger
On 08/22/2011 05:02 PM, Marek Vasut wrote: > >> Masks are not defined for i.MX31 (imx-regs.h), so I simply followed the >> code, which was in the file. The generic.c file for MX35 however is a >> different story. >> >> To keep things simple, I suggest we leave it at that for now. > And noone's gonn

Re: [U-Boot] [PATCH 1/2] mx31: make HSP clock for mx3fb driver available

2011-08-22 Thread Marek Vasut
On Monday, August 22, 2011 05:00:15 PM Helmut Raiger wrote: > On 08/22/2011 04:00 PM, Marek Vasut wrote: > > + u32 pdr0 = __REG(CCM_PDR0); > > Can't we do readl() here? > > > >> + > >> + /* divided by HSP_PODF in PDR0 */ > >> + freq /= ((pdr0>> 11)& 0x7) + 1; > > > > Um, don't we have defin

Re: [U-Boot] [PATCH 1/2] mx31: make HSP clock for mx3fb driver available

2011-08-22 Thread Helmut Raiger
On 08/22/2011 04:00 PM, Marek Vasut wrote: > + u32 pdr0 = __REG(CCM_PDR0); > Can't we do readl() here? > >> + >> +/* divided by HSP_PODF in PDR0 */ >> +freq /= ((pdr0>> 11)& 0x7) + 1; > Um, don't we have defined constants for those magic numbers already? Masks are not defined for i.MX

Re: [U-Boot] [PATCH 1/2] mx31: make HSP clock for mx3fb driver available

2011-08-22 Thread Marek Vasut
On Monday, August 22, 2011 03:41:36 PM Helmut Raiger wrote: > Signed-off-by: Helmut Raiger > --- > arch/arm/cpu/arm1136/mx31/generic.c| 14 ++ > arch/arm/include/asm/arch-mx31/clock.h |1 + > 2 files changed, 15 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/cpu/ar

[U-Boot] [PATCH 1/2] mx31: make HSP clock for mx3fb driver available

2011-08-22 Thread Helmut Raiger
Signed-off-by: Helmut Raiger --- arch/arm/cpu/arm1136/mx31/generic.c| 14 ++ arch/arm/include/asm/arch-mx31/clock.h |1 + 2 files changed, 15 insertions(+), 0 deletions(-) diff --git a/arch/arm/cpu/arm1136/mx31/generic.c b/arch/arm/cpu/arm1136/mx31/generic.c index 248431b