On Monday, August 22, 2011 06:02:10 PM Marek Vasut wrote: > On Monday, August 22, 2011 05:51:05 PM Helmut Raiger wrote: > > On 08/22/2011 05:02 PM, Marek Vasut wrote: > > >> Masks are not defined for i.MX31 (imx-regs.h), so I simply followed > > >> the code, which was in the file. The generic.c file for MX35 however > > >> is a different story. > > >> > > >> To keep things simple, I suggest we leave it at that for now. > > > > > > And noone's gonna fix it later. No please, define the proper constants > > > please. > > > > Do you really expect me to fix code in all the arch/arm/cpu/arm1136/mx31 > > files (2000+ lines) that use that kind of access, because I add 15 lines > > to one of them? There are some 50 other drivers and boards etc. that > > depend on imx-regs.h, which probably use these access methods as-well! > > Hey, calm down, I didn't say anything about fixing gazilion of crap (even > though that'd be nice of you !). > > Actually, I did a quick look and see arch/arm/include/arch-mx35/crm_regs.h > containing PDR0 definitions. Though they don't match your constants. It's > either bug in the crm_regs.h or your code.
Ah sorry, it's mx31. Right, the defines are missing. Do what Stefano said then. And really ... noone wants you to modify gazilions of lines, just your few :) Cheers and sorry for misguiding you about mx35. _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
