Re: [U-Boot] [PATCH 1/2] driver/ddr/fsl: Add general MMDC driver

2016-08-12 Thread Shengzhou Liu
> -Original Message- > From: york sun > Sent: Friday, August 12, 2016 3:45 AM > To: Shengzhou Liu ; u-boot@lists.denx.de > Subject: Re: [PATCH 1/2] driver/ddr/fsl: Add general MMDC driver > > > +#define CMD_ADDR_MSB_MR_OP(x) (x << 24) > > +#define CMD_ADDR_LSB_MR_ADDR(x) (x << 16) > >

Re: [U-Boot] [PATCH 1/2] driver/ddr/fsl: Add general MMDC driver

2016-08-12 Thread Shengzhou Liu
It needs to apply both patches before compiling. The second patch will remove the old board level code and apply common mmdc driver. I understand that in theory we should keep every single patch is compileable, but to make it clean to customer I separated them to two patches. Do I really need to

Re: [U-Boot] [PATCH 1/2] driver/ddr/fsl: Add general MMDC driver

2016-08-12 Thread york sun
I am not suggesting remove the macros. Please try to compile after applying first patch. You will see the errors York Original Message From: Shengzhou Liu Sent: Thursday, August 11, 2016 08:44 PM To: york sun ,u-boot@lists.denx.de Subject: RE: [PATCH 1/2] driver/ddr/fsl: Add

[U-Boot] [PATCH 1/2] driver/ddr/fsl: Add general MMDC driver

2016-08-11 Thread Shengzhou Liu
This patch adds basic support for Freescale MMDC(Multi Mode DDR Controller). Currently MMDC is integrated on ARMv8 LS1012A SoC for DDR3L, there will be a update to this driver to support more flexible configuration if new features (DDR4, multiple controllers/chip selections, etc) are implimented in

Re: [U-Boot] [PATCH 1/2] driver/ddr/fsl: Add general MMDC driver

2016-08-11 Thread york sun
On 08/10/2016 09:55 PM, Shengzhou Liu wrote: > This patch adds basic support for Freescale MMDC(Multi Mode DDR Controller). > Currently MMDC is integrated on ARMv8 LS1012A SoC for DDR3L, there will be a > update to this driver to support more flexible configuration if new features > (DDR4, multiple