Re: [U-Boot] [PATCH 1/2] TI: netdev: add driver for cpsw ethernet device

2011-11-28 Thread Tom Rini
On Mon, Nov 28, 2011 at 1:23 AM, Kumar Nath, Chandan wrote: > Tom, > Can we do cache enabling of cpsw as a follow up patch to this? > As, initial aim is to upstream basic cpsw functional driver first > and then follow on other features like you said cache enable etc. Per Wolfgang in the davinci e

Re: [U-Boot] [PATCH 1/2] TI: netdev: add driver for cpsw ethernet device

2011-11-28 Thread Kumar Nath, Chandan
u-boot- > boun...@lists.denx.de] On Behalf Of Kumar Nath, Chandan > Sent: Friday, November 11, 2011 8:42 PM > To: Tom Rini > Cc: u-boot@lists.denx.de; Chemparathy, Cyril > Subject: Re: [U-Boot] [PATCH 1/2] TI: netdev: add driver for cpsw > ethernet device > > > > &

Re: [U-Boot] [PATCH 1/2] TI: netdev: add driver for cpsw ethernet device

2011-11-11 Thread Kumar Nath, Chandan
> -Original Message- > From: Tom Rini [mailto:tom.r...@gmail.com] > Sent: Friday, November 11, 2011 8:19 PM > To: Kumar Nath, Chandan > Cc: u-boot@lists.denx.de; Chemparathy, Cyril > Subject: Re: [U-Boot] [PATCH 1/2] TI: netdev: add driver for cpsw > ethernet devic

Re: [U-Boot] [PATCH 1/2] TI: netdev: add driver for cpsw ethernet device

2011-11-11 Thread Tom Rini
gt;> >> Sent: Friday, October 21, 2011 9:09 PM >> >> To: Kumar Nath, Chandan >> >> Cc: u-boot@lists.denx.de; Chemparathy, Cyril >> >> Subject: Re: [U-Boot] [PATCH 1/2] TI: netdev: add driver for cpsw >> >> ethernet device >> >> >&

Re: [U-Boot] [PATCH 1/2] TI: netdev: add driver for cpsw ethernet device

2011-11-10 Thread Kumar Nath, Chandan
> -Original Message- > From: Tom Rini [mailto:tom.r...@gmail.com] > Sent: Thursday, November 10, 2011 8:11 PM > To: Kumar Nath, Chandan > Cc: u-boot@lists.denx.de; Chemparathy, Cyril > Subject: Re: [U-Boot] [PATCH 1/2] TI: netdev: add driver for cpsw > ethernet devi

Re: [U-Boot] [PATCH 1/2] TI: netdev: add driver for cpsw ethernet device

2011-11-10 Thread Tom Rini
Subject: Re: [U-Boot] [PATCH 1/2] TI: netdev: add driver for cpsw >> ethernet device >> >> On Fri, Oct 21, 2011 at 12:02 AM, Chandan Nath >> wrote: >> > From: Cyril Chemparathy >> > >> > CPSW is an on-chip ethernet switch that is found on various So

Re: [U-Boot] [PATCH 1/2] TI: netdev: add driver for cpsw ethernet device

2011-11-09 Thread Kumar Nath, Chandan
> -Original Message- > From: Tom Rini [mailto:tom.r...@gmail.com] > Sent: Friday, October 21, 2011 9:09 PM > To: Kumar Nath, Chandan > Cc: u-boot@lists.denx.de; Chemparathy, Cyril > Subject: Re: [U-Boot] [PATCH 1/2] TI: netdev: add driver for cpsw > ethernet devic

Re: [U-Boot] [PATCH 1/2] TI: netdev: add driver for cpsw ethernet device

2011-10-21 Thread Tom Rini
On Fri, Oct 21, 2011 at 12:02 AM, Chandan Nath wrote: > From: Cyril Chemparathy > > CPSW is an on-chip ethernet switch that is found on various SoCs from Texas > Instruments.  This patch adds a simple driver (based on the Linux driver) for > this hardware module. Have you made the driver safe wi

[U-Boot] [PATCH 1/2] TI: netdev: add driver for cpsw ethernet device

2011-10-21 Thread Chandan Nath
From: Cyril Chemparathy CPSW is an on-chip ethernet switch that is found on various SoCs from Texas Instruments. This patch adds a simple driver (based on the Linux driver) for this hardware module. Signed-off-by: Cyril Chemparathy --- drivers/net/Makefile |1 + drivers/net/cpsw.c | 86

Re: [U-Boot] [PATCH 1/2] TI: netdev: add driver for cpsw ethernet device

2010-09-01 Thread Ben Warren
On 8/31/2010 8:58 AM, Cyril Chemparathy wrote: > Hi Ben, > > [...] >>> +COBJS-$(CONFIG_DRIVER_TI_CPSW) += cpsw.o >> Please don't use the word DRIVER here. If possible, use something more >> verbose than "CPSW" too. > Will TI_CPSW_SWITCH work better considering that "CPSW" is the name of > the ha

Re: [U-Boot] [PATCH 1/2] TI: netdev: add driver for cpsw ethernet device

2010-09-01 Thread Ben Warren
Hi Cyril, On 9/1/2010 8:34 AM, Cyril Chemparathy wrote: > Hi Ben, > > I seem to have missed a comment while responding earlier: > > [...] >>> +int cpsw_register(struct cpsw_platform_data *data) >> Please redo things so that this function takes generic arguments. Build >> up your struct internal

Re: [U-Boot] [PATCH 1/2] TI: netdev: add driver for cpsw ethernet device

2010-09-01 Thread Cyril Chemparathy
Hi Ben, I seem to have missed a comment while responding earlier: [...] >> +int cpsw_register(struct cpsw_platform_data *data) > Please redo things so that this function takes generic arguments. Build > up your struct internally. Could you elaborate on the generic arguments here? Are you refer

Re: [U-Boot] [PATCH 1/2] TI: netdev: add driver for cpsw ethernet device

2010-08-31 Thread Cyril Chemparathy
Hi Ben, [...] >> +COBJS-$(CONFIG_DRIVER_TI_CPSW) += cpsw.o > Please don't use the word DRIVER here. If possible, use something more > verbose than "CPSW" too. Will TI_CPSW_SWITCH work better considering that "CPSW" is the name of the hardware block? [...] >> +++ b/drivers/net/cpsw.c > Please re

Re: [U-Boot] [PATCH 1/2] TI: netdev: add driver for cpsw ethernet device

2010-08-30 Thread Ben Warren
Hi Cyril, Sorry for taking so long to look at this. On 8/3/2010 6:33 PM, Cyril Chemparathy wrote: > CPSW is an on-chip ethernet switch that is found on various SoCs from Texas > Instruments. This patch adds a simple driver (based on the Linux driver) for > this hardware module. > > Signed-off-

[U-Boot] [PATCH 1/2] TI: netdev: add driver for cpsw ethernet device

2010-08-03 Thread Cyril Chemparathy
CPSW is an on-chip ethernet switch that is found on various SoCs from Texas Instruments. This patch adds a simple driver (based on the Linux driver) for this hardware module. Signed-off-by: Cyril Chemparathy --- drivers/net/Makefile |1 + drivers/net/cpsw.c | 861