Hi Cyril,
On 9/1/2010 8:34 AM, Cyril Chemparathy wrote: > Hi Ben, > > I seem to have missed a comment while responding earlier: > > [...] >>> +int cpsw_register(struct cpsw_platform_data *data) >> Please redo things so that this function takes generic arguments. Build >> up your struct internally. > Could you elaborate on the generic arguments here? Are you referring to > the eth_device struct and bd_t args? > By generic I mean primitive, or structs that are defined in headers that are universally included. Ideally, you'll pass in arguments that don't require another header file to resolve, such as a base address or index number. As you've proposed, anybody that includes <netdev.h> will need to know what a 'struct cpsw_platform_data' is, and that's not appropriate. > Regards > Cyril. regards, Ben _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
