Re: [U-Boot] [PATCH 05/22] RFC: x86: Split up arch_cpu_init()

2015-03-04 Thread Simon Glass
Hi Bin, On 26 February 2015 at 00:15, Bin Meng wrote: > Hi Simon, > > On Thu, Feb 26, 2015 at 8:55 AM, Simon Glass wrote: >> Hi Bin, >> >> On 25 February 2015 at 01:45, Bin Meng wrote: >>> Hi Simon, >>> >>> On Thu, Feb 19, 2015 at 5:10 AM, Simon Glass wrote: At present we do more in this

Re: [U-Boot] [PATCH 05/22] RFC: x86: Split up arch_cpu_init()

2015-02-25 Thread Bin Meng
Hi Simon, On Thu, Feb 26, 2015 at 8:55 AM, Simon Glass wrote: > Hi Bin, > > On 25 February 2015 at 01:45, Bin Meng wrote: >> Hi Simon, >> >> On Thu, Feb 19, 2015 at 5:10 AM, Simon Glass wrote: >>> At present we do more in this function than we should. Create a new >>> x86_post_cpu_init() which

Re: [U-Boot] [PATCH 05/22] RFC: x86: Split up arch_cpu_init()

2015-02-25 Thread Simon Glass
Hi Bin, On 25 February 2015 at 01:45, Bin Meng wrote: > Hi Simon, > > On Thu, Feb 19, 2015 at 5:10 AM, Simon Glass wrote: >> At present we do more in this function than we should. Create a new >> x86_post_cpu_init() which can be called from the board file when needed >> (e.g. in board_early_init

Re: [U-Boot] [PATCH 05/22] RFC: x86: Split up arch_cpu_init()

2015-02-25 Thread Bin Meng
Hi Simon, On Thu, Feb 19, 2015 at 5:10 AM, Simon Glass wrote: > At present we do more in this function than we should. Create a new > x86_post_cpu_init() which can be called from the board file when needed > (e.g. in board_early_init_f(). This allows us to use driver model for > our x86_post_cpu_

[U-Boot] [PATCH 05/22] RFC: x86: Split up arch_cpu_init()

2015-02-18 Thread Simon Glass
At present we do more in this function than we should. Create a new x86_post_cpu_init() which can be called from the board file when needed (e.g. in board_early_init_f(). This allows us to use driver model for our x86_post_cpu_init() function. It is likely that some future refactoring will improve