Re: [U-Boot] [PATCH] stx: create common vendor hierarchy for Silicon Turnkey boards

2009-08-06 Thread Wolfgang Denk
Dear Alex Dubov, In message <963516.31353...@web37603.mail.mud.yahoo.com> you wrote: > > However, the real issue here is whether you prefer a #define sprawl or > having a couple of additional short files for each board in question. Until > now, as I can see, the second option was preferred. I ex

Re: [U-Boot] [PATCH] stx: create common vendor hierarchy for Silicon Turnkey boards

2009-08-05 Thread Alex Dubov
> > > > Just a general observation: if you are not sure that > tlb/law files can be > > safely factored out and most of the ddr.c files are > actually board specific > > overrides (common part being less than 10 lines) why > had you requested me > > to create a common board hierarchy for these ST

Re: [U-Boot] [PATCH] stx: create common vendor hierarchy for Silicon Turnkey boards

2009-08-05 Thread Wolfgang Denk
Dear Alex Dubov, In message <3287.56311...@web37604.mail.mud.yahoo.com> you wrote: > > Just a general observation: if you are not sure that tlb/law files can be > safely factored out and most of the ddr.c files are actually board specific > overrides (common part being less than 10 lines) why had

Re: [U-Boot] [PATCH] stx: create common vendor hierarchy for Silicon Turnkey boards

2009-08-05 Thread Wolfgang Denk
Dear Alex Dubov, In message <21798.45018...@web37604.mail.mud.yahoo.com> you wrote: > > > > --- a/board/stxgp3/Makefile > > > +++ b/board/stx/common/Makefile > > > @@ -1,5 +1,5 @@ > > >  # > > > -# (C) Copyright 2001-2006 > > > +# (C) Copyright 2006 > > >  # Wolfgang Denk, DENX Software Engineeri

Re: [U-Boot] [PATCH] stx: create common vendor hierarchy for Silicon Turnkey boards

2009-08-04 Thread Alex Dubov
Just a general observation: if you are not sure that tlb/law files can be safely factored out and most of the ddr.c files are actually board specific overrides (common part being less than 10 lines) why had you requested me to create a common board hierarchy for these STX boards in the first place

Re: [U-Boot] [PATCH] stx: create common vendor hierarchy for Silicon Turnkey boards

2009-08-04 Thread Alex Dubov
> > > > Move board definition files for STx XTC, GP3 and SSA > boards into > > common subdirectory and factor out common code. > > > > "-mno-spe" flag common to all MPC85xx configurations > does not work > > so change it to "-mspe=no" which does (GCC bug > 37759). > > > > Signed-off-by: Alex Du

Re: [U-Boot] [PATCH] stx: create common vendor hierarchy for Silicon Turnkey boards

2009-08-04 Thread Kumar Gala
On Aug 4, 2009, at 6:01 AM, oa...@yahoo.com wrote: > From: Alex Dubov > > Move board definition files for STx XTC, GP3 and SSA boards into > common subdirectory and factor out common code. > > "-mno-spe" flag common to all MPC85xx configurations does not work > so change it to "-mspe=no" which d

Re: [U-Boot] [PATCH] stx: create common vendor hierarchy for Silicon Turnkey boards

2009-08-04 Thread Wolfgang Denk
Dear oa...@yahoo.com, In message <1249383697-28141-1-git-send-email-oa...@yahoo.com> you wrote: > From: Alex Dubov > > Move board definition files for STx XTC, GP3 and SSA boards into > common subdirectory and factor out common code. > > "-mno-spe" flag common to all MPC85xx configurations does

[U-Boot] [PATCH] stx: create common vendor hierarchy for Silicon Turnkey boards

2009-08-04 Thread oakad
From: Alex Dubov Move board definition files for STx XTC, GP3 and SSA boards into common subdirectory and factor out common code. "-mno-spe" flag common to all MPC85xx configurations does not work so change it to "-mspe=no" which does (GCC bug 37759). Signed-off-by: Alex Dubov --- Makefile