Re: [U-Boot] [PATCH] omap3: allow slection of NAND GPMC settings based on board config

2009-11-15 Thread Tom
Nishanth Menon wrote: > On Sun, Nov 15, 2009 at 10:36 AM, Tom wrote: >> Mike Rapoport wrote: >>> Any comments on this? >>> >> This is a good idea but.. >> >> These defines are used in the TI codebase but >> it doesn't look like the samsung nand is used here. >> >> As a test I removed the samsung d

Re: [U-Boot] [PATCH] omap3: allow slection of NAND GPMC settings based on board config

2009-11-15 Thread Nishanth Menon
On Sun, Nov 15, 2009 at 10:36 AM, Tom wrote: > Mike Rapoport wrote: >> Any comments on this? >> > > This is a good idea but.. > > These defines are used in the TI codebase but > it doesn't look like the samsung nand is used here. > > As a test I removed the samsung defines > and reran MAKEALL arm.

Re: [U-Boot] [PATCH] omap3: allow slection of NAND GPMC settings based on board config

2009-11-15 Thread Mike Rapoport
On Sun, Nov 15, 2009 at 6:36 PM, Tom wrote: > Mike Rapoport wrote: >> Any comments on this? >> > > This is a good idea but.. > > These defines are used in the TI codebase but > it doesn't look like the samsung nand is used here. > > As a test I removed the samsung defines > and reran MAKEALL arm.

Re: [U-Boot] [PATCH] omap3: allow slection of NAND GPMC settings based on board config

2009-11-15 Thread Tom
Mike Rapoport wrote: > Any comments on this? > This is a good idea but.. These defines are used in the TI codebase but it doesn't look like the samsung nand is used here. As a test I removed the samsung defines and reran MAKEALL arm. No failures. Also grepping the code shows that it isn't used.

Re: [U-Boot] [PATCH] omap3: allow slection of NAND GPMC settings based on board config

2009-11-15 Thread Mike Rapoport
Any comments on this? Mike Rapoport wrote: > There are several presets for GPMC registers defined in > include/asm-arm/arch-omap3/mem.h. Allow selection between SMNAND and > M_NAND presets based on OMAP34XX_GPMC_NAND_ defines > > Signed-off-by: Mike Rapoport > --- > cpu/arm_cortexa8/omap3/mem.c

[U-Boot] [PATCH] omap3: allow slection of NAND GPMC settings based on board config

2009-11-11 Thread Mike Rapoport
There are several presets for GPMC registers defined in include/asm-arm/arch-omap3/mem.h. Allow selection between SMNAND and M_NAND presets based on OMAP34XX_GPMC_NAND_ defines Signed-off-by: Mike Rapoport --- cpu/arm_cortexa8/omap3/mem.c | 25 - 1 files changed, 16 ins