Re: [U-Boot] [PATCH] mpq101: initial support for Mercury Computer Systems MPQ101 board

2011-01-17 Thread Kumar Gala
On Jan 17, 2011, at 4:38 PM, Wolfgang Denk wrote: > Dear Alex Dubov, > > In message <369392.26813...@web37607.mail.mud.yahoo.com> you wrote: >>> >>> Could you please be a bit more specific, i. e. like quoting >>> file names >>> and line numbers? >>> >> >> These were produced by >> grep -nr d

Re: [U-Boot] [PATCH] mpq101: initial support for Mercury Computer Systems MPQ101 board

2011-01-17 Thread Wolfgang Denk
Dear Alex Dubov, In message <369392.26813...@web37607.mail.mud.yahoo.com> you wrote: > > > > Could you please be a bit more specific, i. e. like quoting > > file names > > and line numbers? > > > > These were produced by > grep -nr ddr\-\> board/ | grep -v out_be > > I can attach a listing, b

Re: [U-Boot] [PATCH] mpq101: initial support for Mercury Computer Systems MPQ101 board

2011-01-10 Thread Alex Dubov
> > > > atum8548 > > mpc8540 > > pm854/6 > > sbc8560 > > sbc8641d > > socrates > > mpc8536ds > > mpc8540ads > > mpc8560ads > > mpc8572ds > > mpc8610hpdc > > mpc8641hpcn > > p2020ds > > tqm85xx > > Could you please be a bit more specific, i. e. like quoting > file names > and line numbers? > The

Re: [U-Boot] [PATCH] mpq101: initial support for Mercury Computer Systems MPQ101 board

2011-01-10 Thread Wolfgang Denk
Dear Alex Dubov, In message <328503.45731...@web37602.mail.mud.yahoo.com> you wrote: > > > Can you please point out where this was missed, so it can > > be fixed? > > > > Some of the boards in question: > > atum8548 > mpc8540 > pm854/6 > sbc8560 > sbc8641d > socrates > mpc8536ds > mpc8540ads >

Re: [U-Boot] [PATCH] mpq101: initial support for Mercury Computer Systems MPQ101 board

2011-01-10 Thread Alex Dubov
> > In which case, why are not these used when writing > config values to DDR > > registers (for instance) even in some very recently > added boards, such as > > p2020ds? > > Because this escaped review? > > Can you please point out where this was missed, so it can > be fixed? > Some of the bo

Re: [U-Boot] [PATCH] mpq101: initial support for Mercury Computer Systems MPQ101 board

2011-01-10 Thread Wolfgang Denk
Dear Alex Dubov, In message <24.88500...@web37608.mail.mud.yahoo.com> you wrote: > > > +CONFIG_SYS_TEXT_BASE = 0xfffc0800 > > > +LDFLAGS += > > --section-start=.ppcenv=$(CONFIG_ENV_ADDR) > > > > Please mode defines to board config file and get rid of > > config.mk > > And another question: h

Re: [U-Boot] [PATCH] mpq101: initial support for Mercury Computer Systems MPQ101 board

2011-01-10 Thread Wolfgang Denk
Dear Alex Dubov, In message <754013.38475...@web37602.mail.mud.yahoo.com> you wrote: > > You should use get_ram_size(). > > I still need to call setup_ddr_tlbs because get_ram_size won't do it for > me. So what get_ram_size actually does? It checks the size of available memory and performs a sim

Re: [U-Boot] [PATCH] mpq101: initial support for Mercury Computer Systems MPQ101 board

2010-12-27 Thread Alex Dubov
> > +CONFIG_SYS_TEXT_BASE = 0xfffc0800 > > +LDFLAGS += > --section-start=.ppcenv=$(CONFIG_ENV_ADDR) > > Please mode defines to board config file and get rid of > config.mk And another question: how am I supposed to specify linker flags in the board config file (I suppose, you mean boards.cfg). Th

Re: [U-Boot] [PATCH] mpq101: initial support for Mercury Computer Systems MPQ101 board

2010-12-27 Thread Alex Dubov
> > +phys_size_t > > +initdram (int board_type) > > +{ > ... > > +    dram_size = setup_ddr_tlbs(1ull > << (CONFIG_SYS_SDRAM_SIZE_LOG - 20)); > > + > > +    puts("    DDR: "); > > + > > +    return dram_size << 20; > > You should use get_ram_size(). I still need to call setup_ddr_tlbs because get

Re: [U-Boot] [PATCH] mpq101: initial support for Mercury Computer Systems MPQ101 board

2010-12-27 Thread Wolfgang Denk
Dear Alex Dubov, In message <25288.34605...@web37607.mail.mud.yahoo.com> you wrote: > Mpq101 is a RapidIO development board in AMC form factor, featuring MPC8548 > processor, 512MB of hardwired DDR2 RAM and 128MB of hardwired NAND flash > memory. USB controller is available, but not presently enab

[U-Boot] [PATCH] mpq101: initial support for Mercury Computer Systems MPQ101 board

2010-12-26 Thread Alex Dubov
Mpq101 is a RapidIO development board in AMC form factor, featuring MPC8548 processor, 512MB of hardwired DDR2 RAM and 128MB of hardwired NAND flash memory. USB controller is available, but not presently enabled. Additional board information is available at: http://www.mc.com/products/boards/ensem