Re: [U-Boot] [PATCH] i.MX25: Prepare for LCD driver in board adaptation

On Thu, 26 Apr 2012 14:18:29 +0300 Timo Ketola wrote: ... > Then I might resubmit the original patch. Is there basically anything > else than the lack of proper attributions? Some minor coding style issues. I've sent my comments to both patches. Thanks, Anatolij _

Re: [U-Boot] [PATCH] i.MX25: Prepare for LCD driver in board adaptation

On 26.04.2012 12:57, Anatolij Gustschin wrote: ... > On Fri, 20 Apr 2012 14:01:48 +0300 "Timo Ketola" > wrote: ... >> What if I implement the driver in my board folder instead? ... > I would prefer not including the driver in the board code. The > disadvantage of using the video API is increased

Re: [U-Boot] [PATCH] i.MX25: Prepare for LCD driver in board adaptation

Hi Timo, sorry for my late reply. On Fri, 20 Apr 2012 14:01:48 +0300 "Timo Ketola" wrote: > Dear Stefano, Anatolij, Scott, > > On 18.04.2012 13:47, Stefano Babic wrote: > > On 18/04/2012 10:54, Timo Ketola wrote: > >> Signed-off-by: Timo Ketola > ... > >> diff --git a/drivers/video/mx2fb.c b/

[U-Boot] [PATCH] i.MX25: Prepare for LCD driver in board adaptation

Dear Stefano, Anatolij, Scott, On 18.04.2012 13:47, Stefano Babic wrote: > On 18/04/2012 10:54, Timo Ketola wrote: >> Signed-off-by: Timo Ketola ... >> diff --git a/drivers/video/mx2fb.c b/drivers/video/mx2fb.c >> new file mode 100644 >> index 000..9ee4a3e > > IMHO it is better if you use th