Re: [U-Boot] [PATCH] fsl: remove _IO_BASE and KSEG1ADDR from board configuration files

2009-06-19 Thread Timur Tabi
2009/6/19 André Schwarz : > MVBLM7 is mpc8343 ... please apply your patch. I posted another version of my patch that include MVBLM7. Please ACK that patch. -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de

Re: [U-Boot] [PATCH] fsl: remove _IO_BASE and KSEG1ADDR from board configuration files

2009-06-19 Thread André Schwarz
On Tue, 2009-06-16 at 13:31 -0500, Timur Tabi wrote: > Kim Phillips wrote: > > > it's missing other boards like the MVBLM7, mpc7448hpc2... > > I'm not familiar with those boards, so I didn't touch them. If you give me a > list of which boards I should add, I can post an updated version of the p

Re: [U-Boot] [PATCH] fsl: remove _IO_BASE and KSEG1ADDR from board configuration files

2009-06-17 Thread Nobuhiro Iwamatsu
Hi, all. 2009/6/17 Timur Tabi > > Kim Phillips wrote: > > > based on the content of the patch: > > > > -/* This macro is used by RTL8139 but not defined in PPC architecture */ > > > > I'd say 2, all ppc boards. > > rd2plus.h, which is an SH board, has this: > > /* >  * Network device (RTL8139) su

Re: [U-Boot] [PATCH] fsl: remove _IO_BASE and KSEG1ADDR from board configuration files

2009-06-16 Thread Timur Tabi
Kim Phillips wrote: > based on the content of the patch: > > -/* This macro is used by RTL8139 but not defined in PPC architecture */ > > I'd say 2, all ppc boards. rd2plus.h, which is an SH board, has this: /* * Network device (RTL8139) support */ #define CONFIG_NET_MULTI #define CONFIG_RTL

Re: [U-Boot] [PATCH] fsl: remove _IO_BASE and KSEG1ADDR from board configuration files

2009-06-16 Thread Kim Phillips
On Tue, 16 Jun 2009 16:23:40 -0500 Timur Tabi wrote: > Ok, I need a consensus. It's not clear to me if I should post a patch that > > 1) Updates only FSL boards > 2) Updates all PPC boards > 3) Updates all boards based on the content of the patch: -/* This macro is used by RTL8139 but not def

Re: [U-Boot] [PATCH] fsl: remove _IO_BASE and KSEG1ADDR from board configuration files

2009-06-16 Thread Timur Tabi
Ok, I need a consensus. It's not clear to me if I should post a patch that 1) Updates only FSL boards 2) Updates all PPC boards 3) Updates all boards -- Timur Tabi Linux kernel developer at Freescale ___ U-Boot mailing list U-Boot@lists.denx.de http:/

Re: [U-Boot] [PATCH] fsl: remove _IO_BASE and KSEG1ADDR from board configuration files

2009-06-16 Thread Kumar Gala
On Jun 16, 2009, at 1:49 PM, Timur Tabi wrote: > HIDDEN_DRAGON.h > M5253DEMO.h > M5253EVBE.h > M54455EVB.h I think these three are FSL coldfire/m68k boards. > mpc7448hpc2.h this is a FSL board. > MVBLM7.h > PN62.h > r2dplus.h - k ___ U-Boot mailin

Re: [U-Boot] [PATCH] fsl: remove _IO_BASE and KSEG1ADDR from board configuration files

2009-06-16 Thread Kim Phillips
On Tue, 16 Jun 2009 13:49:57 -0500 Timur Tabi wrote: > Kim Phillips wrote: > > > all ppc boards with KSEG1ADDR and _IO_BASE? isn't that what your > > commit message says the domain is? > > I was hoping you'd be more specific. The patch title says, "fsl:", so I'm > restricting it to FSL board

Re: [U-Boot] [PATCH] fsl: remove _IO_BASE and KSEG1ADDR from board configuration files

2009-06-16 Thread Timur Tabi
Kim Phillips wrote: > all ppc boards with KSEG1ADDR and _IO_BASE? isn't that what your > commit message says the domain is? I was hoping you'd be more specific. The patch title says, "fsl:", so I'm restricting it to FSL boards. The only config files that have either of these two macros are:

Re: [U-Boot] [PATCH] fsl: remove _IO_BASE and KSEG1ADDR from board configuration files

2009-06-16 Thread Kim Phillips
On Tue, 16 Jun 2009 13:31:38 -0500 Timur Tabi wrote: > Kim Phillips wrote: > > > it's missing other boards like the MVBLM7, mpc7448hpc2... > > I'm not familiar with those boards, so I didn't touch them. If you give me a > list of which boards I should add, I can post an updated version of the

Re: [U-Boot] [PATCH] fsl: remove _IO_BASE and KSEG1ADDR from board configuration files

2009-06-16 Thread Timur Tabi
Kim Phillips wrote: > it's missing other boards like the MVBLM7, mpc7448hpc2... I'm not familiar with those boards, so I didn't touch them. If you give me a list of which boards I should add, I can post an updated version of the patch. -- Timur Tabi Linux kernel developer at Freescale ___

Re: [U-Boot] [PATCH] fsl: remove _IO_BASE and KSEG1ADDR from board configuration files

2009-06-16 Thread Kim Phillips
On Mon, 15 Jun 2009 21:51:14 -0500 Kumar Gala wrote: > On Jun 15, 2009, at 4:53 PM, Timur Tabi wrote: > > > The KSEG1ADDR macro used to be necessary for the RTL8139 Ethernet > > driver, but > > the code that used that macro was removed over a year ago, so board > > configuration files no longe

Re: [U-Boot] [PATCH] fsl: remove _IO_BASE and KSEG1ADDR from board configuration files

2009-06-15 Thread Kumar Gala
On Jun 15, 2009, at 4:53 PM, Timur Tabi wrote: > The KSEG1ADDR macro used to be necessary for the RTL8139 Ethernet > driver, but > the code that used that macro was removed over a year ago, so board > configuration files no longer need to define it. > > The _IO_BASE macro is also automatically

[U-Boot] [PATCH] fsl: remove _IO_BASE and KSEG1ADDR from board configuration files

2009-06-15 Thread Timur Tabi
The KSEG1ADDR macro used to be necessary for the RTL8139 Ethernet driver, but the code that used that macro was removed over a year ago, so board configuration files no longer need to define it. The _IO_BASE macro is also automatically defined to 0 if it isn't already set, so there's no need to de