Re: [U-Boot] [PATCH] bug fix and cleanup for s3c44b0 serial driver

2010-08-10 Thread Minkyu Kang
Dear Reinhard Meyer, On 10 August 2010 15:10, Reinhard Meyer wrote: > Dear Minkyu Kang, > > my five cents: > >>>  #define REGL(addr)     (*(volatile unsigned int *)(REGBASE+addr)) >>>  #define REGW(addr)     (*(volatile unsigned short *)(REGBASE+addr)) >>>  #define REGB(addr)     (*(volatile unsi

Re: [U-Boot] [PATCH] bug fix and cleanup for s3c44b0 serial driver

2010-08-09 Thread Reinhard Meyer
Dear Minkyu Kang, my five cents: >> #define REGL(addr) (*(volatile unsigned int *)(REGBASE+addr)) >> #define REGW(addr) (*(volatile unsigned short *)(REGBASE+addr)) >> #define REGB(addr) (*(volatile unsigned char *)(REGBASE+addr)) isn't that way of accessing hardware VERY deprecia

Re: [U-Boot] [PATCH] bug fix and cleanup for s3c44b0 serial driver

2010-08-09 Thread Minkyu Kang
Dear Brian Cavagnolo, On 30 June 2010 01:58, Brian Cavagnolo wrote: > Specifically, don't dereference the URXH0 register twice; calculate the BRD > based on the formula in the databook instead of using a messy switch > statement; > and migrate the BRD calculation to the hardware hardware header

Re: [U-Boot] [PATCH] bug fix and cleanup for s3c44b0 serial driver

2010-08-08 Thread Wolfgang Denk
Dear Minkyu Kang, In message <1277830727-1794-1-git-send-email-br...@cozybit.com> Brian Cavagnolo wrote: > Specifically, don't dereference the URXH0 register twice; calculate the BRD > based on the formula in the databook instead of using a messy switch > statement; > and migrate the BRD calcula

[U-Boot] [PATCH] bug fix and cleanup for s3c44b0 serial driver

2010-06-29 Thread Brian Cavagnolo
Specifically, don't dereference the URXH0 register twice; calculate the BRD based on the formula in the databook instead of using a messy switch statement; and migrate the BRD calculation to the hardware hardware header because it's board specific. Signed-off-by: Brian Cavagnolo --- arch/arm/inc