Re: [U-Boot] [PATCH] TI: DaVinci: GPIO header file and definitions

2009-09-30 Thread Wolfgang Denk
Dear Tom, In message <4ac3d231.1090...@windriver.com> you wrote: > > I will defer to Wolfgang on this. > Since I caused the problem, I will fix it. It's not a problem. I just wanted to make sure we are not too narrow with our rules. Best regards, Wolfgang Denk -- DENX Software Engineering Gmb

Re: [U-Boot] [PATCH] TI: DaVinci: GPIO header file and definitions

2009-09-30 Thread Tom
Paulraj, Sandeep wrote: >> Wolfgang Denk wrote: >>> Dear Tom, >>> >>> In message <4ac1fe5c.4070...@windriver.com> you wrote: > +struct davinci_gpio { > + unsigned intdir; > + unsigned intout_data; > + unsigned intset_data; > + unsigned intclr_data; > + unsign

Re: [U-Boot] [PATCH] TI: DaVinci: GPIO header file and definitions

2009-09-30 Thread Wolfgang Denk
Dear "Paulraj, Sandeep", In message <0554bef07d437848af01b9c9b5f0bc5d92ec0...@dlee01.ent.ti.com> you wrote: > > > > Why? It is not really important here, but especially when mixing data > > > types, TABs are preferred, as they will allow for nice vertical > > > alignment. > > > > OK. TABs are p

Re: [U-Boot] [PATCH] TI: DaVinci: GPIO header file and definitions

2009-09-30 Thread Paulraj, Sandeep
> > Wolfgang Denk wrote: > > Dear Tom, > > > > In message <4ac1fe5c.4070...@windriver.com> you wrote: > >>> +struct davinci_gpio { > >>> + unsigned intdir; > >>> + unsigned intout_data; > >>> + unsigned intset_data; > >>> + unsigned intclr_data; > >>> + unsigned intin_data; >

Re: [U-Boot] [PATCH] TI: DaVinci: GPIO header file and definitions

2009-09-30 Thread Tom
Wolfgang Denk wrote: > Dear Tom, > > In message <4ac1fe5c.4070...@windriver.com> you wrote: >>> +struct davinci_gpio { >>> + unsigned intdir; >>> + unsigned intout_data; >>> + unsigned intset_data; >>> + unsigned intclr_data; >>> + unsigned intin_data; >>> + unsigne

Re: [U-Boot] [PATCH] TI: DaVinci: GPIO header file and definitions

2009-09-30 Thread Wolfgang Denk
Dear Tom, In message <4ac1fe5c.4070...@windriver.com> you wrote: > > > +struct davinci_gpio { > > + unsigned intdir; > > + unsigned intout_data; > > + unsigned intset_data; > > + unsigned intclr_data; > > + unsigned intin_data; > > + unsigned intset_rising; > >

Re: [U-Boot] [PATCH] TI: DaVinci: GPIO header file and definitions

2009-09-29 Thread Tom
s-paul...@ti.com wrote: > From: Sandeep Paulraj > > Some DaVinci SOC's use GPIOs to enable EMAC and DM9000. > This patch adds some definitions for GPIO registers and also adds > structures for GPIO. > A separate header file is being added so that in future we > can have a DaVinci GPIO driver simi

[U-Boot] [PATCH] TI: DaVinci: GPIO header file and definitions

2009-09-28 Thread s-paulraj
From: Sandeep Paulraj Some DaVinci SOC's use GPIOs to enable EMAC and DM9000. This patch adds some definitions for GPIO registers and also adds structures for GPIO. A separate header file is being added so that in future we can have a DaVinci GPIO driver similer to OMAP. Signed-off-by: Sandeep P