Dear Tom,
In message <4ac1fe5c.4070...@windriver.com> you wrote:
>
> > +struct davinci_gpio {
> > + unsigned int dir;
> > + unsigned int out_data;
> > + unsigned int set_data;
> > + unsigned int clr_data;
> > + unsigned int in_data;
> > + unsigned int set_rising;
> > + unsigned int clr_rising;
> > + unsigned int set_falling;
> > + unsigned int clr_falling;
> > + unsigned int intstat;
> > +};
>
> Convert the tabs to spaces in the in the whitespace between
> type and elemement names
> unsigned int dir; -> unsigned int dir;
> For all of the elements
Why? It is not really important here, but especially when mixing data
types, TABs are preferred, as they will allow for nice vertical
alignment.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
The price of curiosity is a terminal experience.
- Terry Pratchett, _The Dark Side of the Sun_
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
