Re: [U-Boot] [PATCH] Olimex SAM9-L9260 board support

2008-11-01 Thread Jean-Christophe PLAGNIOL-VILLARD
On 14:49 Sat 01 Nov , Cristian Birsan wrote: > Dear Jean-Christophe PLAGNIOL-VILLARD, > > I will remove all unnecessary white spaces from the previous patch. I > have now a patch version for u-boot u-boot v2008.10 > > > > " > > > > > > > > > #

Re: [U-Boot] [PATCH] Olimex SAM9-L9260 board support

2008-11-01 Thread Cristian Birsan
Dear Jean-Christophe PLAGNIOL-VILLARD, I will remove all unnecessary white spaces from the previous patch. I have now a patch version for u-boot u-boot v2008.10 > > " > > > > # > > diff --git a/Makefile b/Makefile > > in

Re: [U-Boot] [PATCH] Olimex SAM9-L9260 board support

2008-10-31 Thread Jean-Christophe PLAGNIOL-VILLARD
On 09:48 Fri 31 Oct , Wolfgang Denk wrote: > Dear Cristian > > In message <[EMAIL PROTECTED]> Jean-Christophe wrote: > > > > I've forget one think please add an entry to the MAINTAINER file > > This can be done by sending an additional patch - no need to resubmit > all the stuff. Yes but the

Re: [U-Boot] [PATCH] Olimex SAM9-L9260 board support

2008-10-31 Thread Wolfgang Denk
Dear Cristian In message <[EMAIL PROTECTED]> Jean-Christophe wrote: > > I've forget one think please add an entry to the MAINTAINER file This can be done by sending an additional patch - no need to resubmit all the stuff. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD:

Re: [U-Boot] [PATCH] Olimex SAM9-L9260 board support

2008-10-31 Thread Jean-Christophe PLAGNIOL-VILLARD
On 08:05 Fri 31 Oct , Jean-Christophe PLAGNIOL-VILLARD wrote: > On 21:03 Mon 06 Oct , Cristian Birsan wrote: > > Added support for the Olimex SAM9-L9260 development board. > > This patch is based on u-boot v1.3.4. > > > > Tested with data flash only (not with NAND). > > > > Signed-off-by:

Re: [U-Boot] [PATCH] Olimex SAM9-L9260 board support

2008-10-31 Thread Jean-Christophe PLAGNIOL-VILLARD
On 21:03 Mon 06 Oct , Cristian Birsan wrote: > Added support for the Olimex SAM9-L9260 development board. > This patch is based on u-boot v1.3.4. > > Tested with data flash only (not with NAND). > > Signed-off-by: Cristian Birsan <[EMAIL PROTECTED]> > --- > MAKEALL

Re: [U-Boot] [PATCH] Olimex SAM9-L9260 board support

2008-10-31 Thread Jean-Christophe PLAGNIOL-VILLARD
On 01:41 Fri 31 Oct , Cristian Birsan wrote: > Dear Wolfgang Denk, > > I have submitted a few weeks ago a patch for Olimex SAM9-L9260 (similar to > AT91SAM9260-EK board from Atmel). > > Is is possible to include that patch in the new version of u-boot ? > > If it's needed I can resend a new pa

Re: [U-Boot] [PATCH] Olimex SAM9-L9260 board support

2008-10-30 Thread Cristian Birsan
Dear Wolfgang Denk, I have submitted a few weeks ago a patch for Olimex SAM9-L9260 (similar to AT91SAM9260-EK board from Atmel). Is is possible to include that patch in the new version of u-boot ? If it's needed I can resend a new patch for the u-boot v2008.10 Please let me know what should I

Re: [U-Boot] [PATCH] Olimex SAM9-L9260 board support

2008-10-10 Thread Cristian Birsan
Dear Wolfgang Denk, On Wed, Oct 8, 2008 at 1:55 AM, Wolfgang Denk <[EMAIL PROTECTED]> wrote: > setenv affects only the U-Boot environment variables. It doe snot > program any device registers for you. > > And PLEASE: restrict your line length to 70 characters or less. > >> Nfs works only with the

Re: [U-Boot] [PATCH] Olimex SAM9-L9260 board support

2008-10-07 Thread Wolfgang Denk
Dear Cristian Birsan, In message <[EMAIL PROTECTED]> you wrote: > > I used again setenv ethaddr 00:04:25:12:34:56 in u-boot. After saveenv and > reboot i used md command to display the EMAC 0xFFFC4000 (named MACB in the > driver ) > registers setenv affects only the U-Boot environment variable

Re: [U-Boot] [PATCH] Olimex SAM9-L9260 board support

2008-10-07 Thread Cristian Birsan
Dear all, In the previous patch i removed the code from the section below. >> +#ifdef CONFIG_RESET_PHY_R >> +void reset_phy(void) >> +{ >> +#ifdef CONFIG_MACB >> +/* >> + * Initialize ethernet HW addr prior to starting Linux, >> + * needed for nfsroot >> + */ >> +eth_

Re: [U-Boot] [PATCH] Olimex SAM9-L9260 board support

2008-10-07 Thread Cristian Birsan
Dear Wolfgang Denk, > In message <[EMAIL PROTECTED]> you wrote: >> I tried to include the common.h file in my configuration file but this >> breaks u-boot compilation (it's >> not safe to include common.h standalone) .I noticed that none of other > > What do you mean by "include common.h standalo

Re: [U-Boot] [PATCH] Olimex SAM9-L9260 board support

2008-10-07 Thread Wolfgang Denk
Dear Cristian, In message <[EMAIL PROTECTED]> you wrote: > > I tried to include the common.h file in my configuration file but this > breaks u-boot compilation (it's > not safe to include common.h standalone) .I noticed that none of other What do you mean by "include common.h standalone" ? > bo

Re: [U-Boot] [PATCH] Olimex SAM9-L9260 board support

2008-10-07 Thread Cristian Birsan
Dear Wolfgang Denk, Regarding the following: +#define ROUND(A, B)(((A) + (B)) & ~((B) - 1)) +/* + * Size of malloc() pool + */ +#define CFG_MALLOC_LEN ROUND(3 * CONFIG_ENV_SIZE + 128*1024, 0x1000) I tried to include the common.h file in my configuration file but this breaks u

Re: [U-Boot] [PATCH] Olimex SAM9-L9260 board support

2008-10-06 Thread Wolfgang Denk
Dear Cristian Birsan, In message <[EMAIL PROTECTED]> you wrote: > > > Carelessly leaving ports or devices in an initialized stated has been > > the source for problems too many times before. > > > > Don't do that. > > The above code section is used also in other ATMEL boards like > at91sam92

Re: [U-Boot] [PATCH] Olimex SAM9-L9260 board support

2008-10-06 Thread Cristian Birsan
Dear Wolfgang Denk, Thank you for your quick response. >> +#ifdef CONFIG_RESET_PHY_R >> +void reset_phy(void) >> +{ >> +#ifdef CONFIG_MACB >> +/* >> + * Initialize ethernet HW addr prior to starting Linux, >> + * needed for nfsroot >> + */ >> +eth_init(gd->bd); >> +#

Re: [U-Boot] [PATCH] Olimex SAM9-L9260 board support

2008-10-06 Thread Wolfgang Denk
Dear Cristian Birsan, > +#ifdef CONFIG_RESET_PHY_R > +void reset_phy(void) > +{ > +#ifdef CONFIG_MACB > + /* > + * Initialize ethernet HW addr prior to starting Linux, > + * needed for nfsroot > + */ > + eth_init(gd->bd); > +#endif Please do NOT do this. It's a violati

[U-Boot] [PATCH] Olimex SAM9-L9260 board support

2008-10-06 Thread Cristian Birsan
Added support for the Olimex SAM9-L9260 development board. This patch is based on u-boot v1.3.4. Tested with data flash only (not with NAND). Signed-off-by: Cristian Birsan <[EMAIL PROTECTED]> --- MAKEALL|1 + Makefile | 21 ++-- boa