Re: [U-Boot] [PATCH] Fix bug in io64 target (introduced by commit aba27ac)

2014-06-18 Thread Tom Rini
On Mon, Jun 16, 2014 at 05:40:59PM +0300, Vasili Galka wrote: > From comparison of current logic and the logic that was prior to commit > aba27ac, we see that first parameter of FPGA_GET_REG() shall be the > FPGA index and not channel number. The re-factoring in commit aba27ac > accidentally chang

Re: [U-Boot] [PATCH] Fix bug in io64 target (introduced by commit aba27ac)

2014-06-17 Thread Vasili Galka
Hi Dirk, On Tue, Jun 17, 2014 at 9:18 AM, Dirk Eibach wrote: > Heh. Good catch. thanks! > But now I'm curious: how did you find this? > > Acked-by: dirk.eib...@gdsys.cc > > Cheers > Dirk I had the following compiler warning (and I actually don't understand why it was generated here): In file in

Re: [U-Boot] [PATCH] Fix bug in io64 target (introduced by commit aba27ac)

2014-06-16 Thread Dirk Eibach
Heh. Good catch. thanks! But now I'm curious: how did you find this? Acked-by: dirk.eib...@gdsys.cc Cheers Dirk ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH] Fix bug in io64 target (introduced by commit aba27ac)

2014-06-16 Thread Vasili Galka
>From comparison of current logic and the logic that was prior to commit aba27ac, we see that first parameter of FPGA_GET_REG() shall be the FPGA index and not channel number. The re-factoring in commit aba27ac accidentally changed that. Signed-off-by: Vasili Galka Cc: Dirk Eibach , Stefan Roese