Re: [U-Boot] [PATCH] Davinci: SPI performance enhancements

2010-06-23 Thread Nick Thompson
On 22/06/10 16:27, Paulraj, Sandeep wrote: > >> The following restructuring and optimisations increase the SPI >> read performance from 1.3MiB/s (on da850) to 2.87MiB/s (on da830): >> >> Remove continual revaluation of driver state from the core of the >> copy loop. State can not change during the

Re: [U-Boot] [PATCH] Davinci: SPI performance enhancements

2010-06-22 Thread Paulraj, Sandeep
> The following restructuring and optimisations increase the SPI > read performance from 1.3MiB/s (on da850) to 2.87MiB/s (on da830): > > Remove continual revaluation of driver state from the core of the > copy loop. State can not change during the copy loop, so it is > possible to move these eva

Re: [U-Boot] [PATCH] Davinci: SPI performance enhancements

2010-06-22 Thread Delio Brignoli
Hello Sandeep, Yes, please apply the patch. Regards -- Delio On 22/06/2010, at 16:27, Paulraj, Sandeep wrote: > > >>> >>> Not testing the txp and rxp pointers in the loop was a significant >>> gain for me and pipe-lining the TX and RX operations is going to be >>> a little trickier, but giv

Re: [U-Boot] [PATCH] Davinci: SPI performance enhancements

2010-06-22 Thread Paulraj, Sandeep
> > > > Not testing the txp and rxp pointers in the loop was a significant > > gain for me and pipe-lining the TX and RX operations is going to be > > a little trickier, but give it a go by all means. > > Yes, it's unlikely I will be able to get my version to work as fast as > yours > because of

Re: [U-Boot] [PATCH] Davinci: SPI performance enhancements

2010-06-22 Thread Delio Brignoli
On 22/06/2010, at 10:29, Nick Thompson wrote: > On 21/06/10 19:38, Delio Brignoli wrote: >> Hello Nick, >> >> On 21/06/2010, at 11:27, Nick Thompson wrote: >>> The following restructuring and optimisations increase the SPI >>> read performance from 1.3MiB/s (on da850) to 2.87MiB/s (on da830): >>

Re: [U-Boot] [PATCH] Davinci: SPI performance enhancements

2010-06-22 Thread Nick Thompson
On 21/06/10 19:38, Delio Brignoli wrote: > Hello Nick, > > On 21/06/2010, at 11:27, Nick Thompson wrote: >> The following restructuring and optimisations increase the SPI >> read performance from 1.3MiB/s (on da850) to 2.87MiB/s (on da830): > > Using this patch I get 2.21MiB/s on my L138 EVM (da8

Re: [U-Boot] [PATCH] Davinci: SPI performance enhancements

2010-06-21 Thread Delio Brignoli
Hello Nick, On 21/06/2010, at 11:27, Nick Thompson wrote: > The following restructuring and optimisations increase the SPI > read performance from 1.3MiB/s (on da850) to 2.87MiB/s (on da830): Using this patch I get 2.21MiB/s on my L138 EVM (da850), quite an improvement! I would like to see how m

Re: [U-Boot] [PATCH] Davinci: SPI performance enhancements

2010-06-21 Thread Nick Thompson
On 21/06/10 15:41, Paulraj, Sandeep wrote: > > >> >> The following restructuring and optimisations increase the SPI >> read performance from 1.3MiB/s (on da850) to 2.87MiB/s (on da830): >> >> Remove continual revaluation of driver state from the core of the >> copy loop. State can not change duri

Re: [U-Boot] [PATCH] Davinci: SPI performance enhancements

2010-06-21 Thread Nick Thompson
On 21/06/10 15:41, Paulraj, Sandeep wrote: > > >> >> The following restructuring and optimisations increase the SPI >> read performance from 1.3MiB/s (on da850) to 2.87MiB/s (on da830): >> >> Remove continual revaluation of driver state from the core of the >> copy loop. State can not change duri

Re: [U-Boot] [PATCH] Davinci: SPI performance enhancements

2010-06-21 Thread Paulraj, Sandeep
> > The following restructuring and optimisations increase the SPI > read performance from 1.3MiB/s (on da850) to 2.87MiB/s (on da830): > > Remove continual revaluation of driver state from the core of the > copy loop. State can not change during the copy loop, so it is > possible to move these

[U-Boot] [PATCH] Davinci: SPI performance enhancements

2010-06-21 Thread Nick Thompson
The following restructuring and optimisations increase the SPI read performance from 1.3MiB/s (on da850) to 2.87MiB/s (on da830): Remove continual revaluation of driver state from the core of the copy loop. State can not change during the copy loop, so it is possible to move these evaluations to b